Use mojom.InputTargetClient for targeting touch-events in oopif |
||
Issue descriptionIssue 796656 changed to use mojom.InputTargetClient for targeting moues-events in oopif. We need to do the same thing for touchscreen events. Issue 799473 tracks the fix for mouse-wheel events.
,
Jan 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/18a151ec456d68e63c632907001a6f427fd889fd commit 18a151ec456d68e63c632907001a6f427fd889fd Author: W. James MacLean <wjmaclean@chromium.org> Date: Wed Jan 10 20:04:14 2018 Refactor RouteTouchcreenGestureEvent() to match RenderWidgetTargeter. This CL refactors RWHIER::RouteTouchscreenGestureEvent() logic into the FindTouchscreenGestureEventTarget() / DispatchTouchscreenGestureEventTarget() pattern needed to use it with RenderWidgetTargeter. Bug: 799474 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I7b09073b69e2812e2c0aafcd4fa4d47dbf30b9a2 Reviewed-on: https://chromium-review.googlesource.com/857417 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#528401} [modify] https://crrev.com/18a151ec456d68e63c632907001a6f427fd889fd/content/browser/renderer_host/render_widget_host_input_event_router.cc [modify] https://crrev.com/18a151ec456d68e63c632907001a6f427fd889fd/content/browser/renderer_host/render_widget_host_input_event_router.h
,
Jan 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/da13bef77e0585eb28a86fca3a6bd130afcb4a3f commit da13bef77e0585eb28a86fca3a6bd130afcb4a3f Author: W. James MacLean <wjmaclean@chromium.org> Date: Fri Jan 12 18:45:40 2018 Enable async Touch/Gesture hit testing. This CL adds the RenderWidgetTargeter plumbing to enable async hit testing for touch and gesture events. Bug: 799474 Change-Id: I3a6cad3cfae0aae7778c4ac9e52f2765f4728b26 Reviewed-on: https://chromium-review.googlesource.com/860338 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by: Nasko Oskov <nasko@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Cr-Commit-Position: refs/heads/master@{#529005} [modify] https://crrev.com/da13bef77e0585eb28a86fca3a6bd130afcb4a3f/chrome/browser/apps/guest_view/web_view_browsertest.cc [modify] https://crrev.com/da13bef77e0585eb28a86fca3a6bd130afcb4a3f/content/browser/renderer_host/render_widget_host_input_event_router.cc [modify] https://crrev.com/da13bef77e0585eb28a86fca3a6bd130afcb4a3f/content/browser/renderer_host/render_widget_targeter.cc [modify] https://crrev.com/da13bef77e0585eb28a86fca3a6bd130afcb4a3f/content/browser/site_per_process_browsertest.cc
,
Jan 12 2018
Assuming the three CLs above stick, this should be fixed now.
,
Jan 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed1f011d02f001dc643338cc5eed086f153f4204 commit ed1f011d02f001dc643338cc5eed086f153f4204 Author: Ria Jiang <riajiang@chromium.org> Date: Fri Jan 12 21:13:01 2018 Change touchpad-gesture to use async targeting. Change touchpad-gesture to use mojom::InputTargetClient to do async targeting. Bug: 799474 Test: content_browsertests Change-Id: I8b3ea653a72d12a0aa9d181d4a62c6c9afc6980f Reviewed-on: https://chromium-review.googlesource.com/862632 Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: James MacLean <wjmaclean@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: Ken Buchanan <kenrb@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#529068} [modify] https://crrev.com/ed1f011d02f001dc643338cc5eed086f153f4204/content/browser/renderer_host/render_widget_host_input_event_router.cc [modify] https://crrev.com/ed1f011d02f001dc643338cc5eed086f153f4204/content/browser/renderer_host/render_widget_host_input_event_router.h [modify] https://crrev.com/ed1f011d02f001dc643338cc5eed086f153f4204/content/browser/renderer_host/render_widget_targeter.cc [modify] https://crrev.com/ed1f011d02f001dc643338cc5eed086f153f4204/content/browser/site_per_process_browsertest.cc [modify] https://crrev.com/ed1f011d02f001dc643338cc5eed086f153f4204/content/browser/site_per_process_mac_browsertest.mm
,
Jan 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6b841e233df961f906aafc18b7d5a7a830318fe7 commit 6b841e233df961f906aafc18b7d5a7a830318fe7 Author: Ria Jiang <riajiang@chromium.org> Date: Thu Jan 18 14:33:00 2018 Use RenderWidgetTargeter for touchscreen gesture events. Unifying code paths between touchscreen gesture events and other types of events by updating touchscreen to use RenderWidgetTargeter. Event targeting and dispatching should still be synchronous, which is why tests don't need to be updated. Bug: 799474 Change-Id: Icd2f2aa59dbfe2e9515150d58481033f09eebe39 Reviewed-on: https://chromium-review.googlesource.com/872094 Commit-Queue: Ria Jiang <riajiang@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#530138} [modify] https://crrev.com/6b841e233df961f906aafc18b7d5a7a830318fe7/content/browser/renderer_host/render_widget_host_input_event_router.cc |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jan 10 2018