GpuPreferencesUtilTest.EncodeDecode in gpu_unittests failing on chromium.win/Win7 Tests (dbg)(1) |
||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of dvadym@google.com GpuPreferencesUtilTest.EncodeDecode in gpu_unittests failing on chromium.win/Win7 Tests (dbg)(1) Builders failed on: - Win7 Tests (dbg)(1): https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29
,
Jan 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1549ef4edadec01dec392658d5524758e6468033 commit 1549ef4edadec01dec392658d5524758e6468033 Author: Vadym Doroshenko <dvadym@chromium.org> Date: Fri Jan 05 14:49:08 2018 Disabling test GpuPreferencesUtilTest.EncodeDecode on Windows. This tests fails on Windows bots, probably https://chromium-review.googlesource.com/c/chromium/src/+/849491 is culprit. TBR=vmiura@chromium.org TBR=piman@chromium.org TBR=dcheng@chromium.org Bug: 799458 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Idbb3d4aae25bbd70df9b22eb2bc3ae9c9b6ff615 Reviewed-on: https://chromium-review.googlesource.com/852113 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#527276} [modify] https://crrev.com/1549ef4edadec01dec392658d5524758e6468033/gpu/ipc/common/gpu_preferences_util_unittest.cc
,
Jan 5 2018
Thanks, I will take a look. The test needs fixing (can't memcmp to test equality after adding std::vector member.
,
Feb 5 2018
,
Feb 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/015cbc255a73cefb26c2b9fbe3102f4ac26eece1 commit 015cbc255a73cefb26c2b9fbe3102f4ac26eece1 Author: Victor Miura <vmiura@chromium.org> Date: Sat Feb 10 02:56:46 2018 Fix and re-enable GpuPreferencesUtilTest.EncodeDecode test. BUG=799458 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ib2898c97168b164c718dcc3c0303950c4c271659 Reviewed-on: https://chromium-review.googlesource.com/852639 Reviewed-by: Daniel Cheng <dcheng@chromium.org> Reviewed-by: Antoine Labour <piman@chromium.org> Commit-Queue: Victor Miura <vmiura@chromium.org> Cr-Commit-Position: refs/heads/master@{#535944} [modify] https://crrev.com/015cbc255a73cefb26c2b9fbe3102f4ac26eece1/gpu/command_buffer/service/gpu_preferences.h [modify] https://crrev.com/015cbc255a73cefb26c2b9fbe3102f4ac26eece1/gpu/ipc/common/gpu_preferences_util_unittest.cc |
||
►
Sign in to add a comment |
||
Comment 1 by dvadym@chromium.org
, Jan 5 2018