The AdaptiveToolbar will use lot of previous toolbar functionalities. This bug is made to track the CL done to port the functinalities.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/964f1b53dcba6d2e07a96b66f969cb4472e2f01d commit 964f1b53dcba6d2e07a96b66f969cb4472e2f01d Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Jan 10 14:00:09 2018 Create Coordinator/ViewController for AdaptiveToolbar This CL creates the coordinators and view controllers for the adaptive primary toolbar. Those objects are mainly copy-pasted from the clean toolbar. They are not connected to any flag yet. As the toolbar is needed to enable/disable flags, the flag will be added once the toolbar is reaching a state where it is usable. This CL is only creating the base of the adaptive toolbar. Other CL will follow to enable it. This will allow better readability. Bug: 799422, 799438 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I55b737e43acde8bbbe65d7d27af7ae69a93adc78 Reviewed-on: https://chromium-review.googlesource.com/852292 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#528299} [modify] https://crrev.com/964f1b53dcba6d2e07a96b66f969cb4472e2f01d/ios/chrome/browser/ui/BUILD.gn [modify] https://crrev.com/964f1b53dcba6d2e07a96b66f969cb4472e2f01d/ios/chrome/browser/ui/browser_view_controller.mm [add] https://crrev.com/964f1b53dcba6d2e07a96b66f969cb4472e2f01d/ios/chrome/browser/ui/toolbar/adaptive/BUILD.gn [add] https://crrev.com/964f1b53dcba6d2e07a96b66f969cb4472e2f01d/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_coordinator.h [add] https://crrev.com/964f1b53dcba6d2e07a96b66f969cb4472e2f01d/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_coordinator.mm [add] https://crrev.com/964f1b53dcba6d2e07a96b66f969cb4472e2f01d/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.h [add] https://crrev.com/964f1b53dcba6d2e07a96b66f969cb4472e2f01d/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.mm [add] https://crrev.com/964f1b53dcba6d2e07a96b66f969cb4472e2f01d/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.h [add] https://crrev.com/964f1b53dcba6d2e07a96b66f969cb4472e2f01d/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view_controller.mm [modify] https://crrev.com/964f1b53dcba6d2e07a96b66f969cb4472e2f01d/ios/chrome/browser/ui/toolbar/clean/toolbar_coordinator.h [modify] https://crrev.com/964f1b53dcba6d2e07a96b66f969cb4472e2f01d/ios/chrome/browser/ui/toolbar/legacy_toolbar_coordinator.mm [modify] https://crrev.com/964f1b53dcba6d2e07a96b66f969cb4472e2f01d/ios/chrome/browser/ui/toolbar/public/primary_toolbar_coordinator.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fbc92a7cf5e08e13664a1739fbaa68657cb5263c commit fbc92a7cf5e08e13664a1739fbaa68657cb5263c Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Jan 10 15:17:37 2018 Create secondary toolbar ViewController/Coordinator This CL creates the secondary toolbar ViewController and Coordinator. For now they are not used. Bug: 799438 , 799422 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I332788d513aa95f86e0bf409afd07238c149ec2a Reviewed-on: https://chromium-review.googlesource.com/854277 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#528316} [modify] https://crrev.com/fbc92a7cf5e08e13664a1739fbaa68657cb5263c/ios/chrome/browser/ui/toolbar/adaptive/BUILD.gn [add] https://crrev.com/fbc92a7cf5e08e13664a1739fbaa68657cb5263c/ios/chrome/browser/ui/toolbar/adaptive/secondary_toolbar_coordinator.h [add] https://crrev.com/fbc92a7cf5e08e13664a1739fbaa68657cb5263c/ios/chrome/browser/ui/toolbar/adaptive/secondary_toolbar_coordinator.mm [add] https://crrev.com/fbc92a7cf5e08e13664a1739fbaa68657cb5263c/ios/chrome/browser/ui/toolbar/adaptive/secondary_toolbar_view.h [add] https://crrev.com/fbc92a7cf5e08e13664a1739fbaa68657cb5263c/ios/chrome/browser/ui/toolbar/adaptive/secondary_toolbar_view.mm [add] https://crrev.com/fbc92a7cf5e08e13664a1739fbaa68657cb5263c/ios/chrome/browser/ui/toolbar/adaptive/secondary_toolbar_view_controller.h [add] https://crrev.com/fbc92a7cf5e08e13664a1739fbaa68657cb5263c/ios/chrome/browser/ui/toolbar/adaptive/secondary_toolbar_view_controller.mm [modify] https://crrev.com/fbc92a7cf5e08e13664a1739fbaa68657cb5263c/ios/chrome/browser/ui/toolbar/clean/toolbar_button_factory.h [modify] https://crrev.com/fbc92a7cf5e08e13664a1739fbaa68657cb5263c/ios/chrome/browser/ui/toolbar/clean/toolbar_button_factory.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7c8ade1b5551a3e23b6b82b66fe6957f620b99ab commit 7c8ade1b5551a3e23b6b82b66fe6957f620b99ab Author: Gauthier Ambard <gambard@chromium.org> Date: Mon Jan 15 13:16:41 2018 Update visibility for SecondaryToolbar buttons This CL changes the visibility of the secondary toolbar buttons. The buttons will be hidden when the toolbar is not visible, allowing the toolbar to be hidden by having no content. Bug: 799438 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Idb470d7ae7d0a4cf738010be7a6b87e3b66a8119 Reviewed-on: https://chromium-review.googlesource.com/866501 Commit-Queue: Louis Romero <lpromero@chromium.org> Reviewed-by: Louis Romero <lpromero@chromium.org> Cr-Commit-Position: refs/heads/master@{#529264} [modify] https://crrev.com/7c8ade1b5551a3e23b6b82b66fe6957f620b99ab/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_coordinator.mm [modify] https://crrev.com/7c8ade1b5551a3e23b6b82b66fe6957f620b99ab/ios/chrome/browser/ui/toolbar/adaptive/toolbar_coordinator_adaptor.mm [modify] https://crrev.com/7c8ade1b5551a3e23b6b82b66fe6957f620b99ab/ios/chrome/browser/ui/toolbar/clean/toolbar_button_visibility_configuration.mm [modify] https://crrev.com/7c8ade1b5551a3e23b6b82b66fe6957f620b99ab/ios/chrome/browser/ui/toolbar/clean/toolbar_component_options.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a5c13ad3ef0bf420bfb6194b875d73253512fc74 commit a5c13ad3ef0bf420bfb6194b875d73253512fc74 Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Jan 17 16:00:48 2018 Hide the status bar in landscape with AdaptiveToolbar This CL hides the status bar when the Adaptive Toolbar is enabled and the device has a compact height. Bug: 799438 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ia97a5d97dbe02e081ce8cfdde20a07d529e785db Reviewed-on: https://chromium-review.googlesource.com/868353 Reviewed-by: Mark Cogan <marq@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#529756} [modify] https://crrev.com/a5c13ad3ef0bf420bfb6194b875d73253512fc74/ios/chrome/browser/ui/browser_view_controller.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8d2f057a95356727a612738cc4ff345b6088945e commit 8d2f057a95356727a612738cc4ff345b6088945e Author: Gauthier Ambard <gambard@chromium.org> Date: Wed Jan 17 16:11:52 2018 Polish the AdaptiveToolbar UI This CL adds some polish to the Adaptive Toolbar UI to make it look like its final state. Bug: 799438 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I6f40507c48f6c9176fd5b5ca0f202d631859534f Reviewed-on: https://chromium-review.googlesource.com/868434 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#529760} [modify] https://crrev.com/8d2f057a95356727a612738cc4ff345b6088945e/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_view.mm [modify] https://crrev.com/8d2f057a95356727a612738cc4ff345b6088945e/ios/chrome/browser/ui/toolbar/adaptive/secondary_toolbar_view.mm [modify] https://crrev.com/8d2f057a95356727a612738cc4ff345b6088945e/ios/chrome/browser/ui/toolbar/clean/toolbar_configuration.mm [modify] https://crrev.com/8d2f057a95356727a612738cc4ff345b6088945e/ios/chrome/browser/ui/toolbar/clean/toolbar_constants.h [modify] https://crrev.com/8d2f057a95356727a612738cc4ff345b6088945e/ios/chrome/browser/ui/toolbar/clean/toolbar_constants.mm [modify] https://crrev.com/8d2f057a95356727a612738cc4ff345b6088945e/ios/chrome/browser/ui/toolbar/clean/toolbar_view.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/286f9df80a798c985145c09fe2d8e7f421a80ae2 commit 286f9df80a798c985145c09fe2d8e7f421a80ae2 Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Jan 19 17:28:16 2018 Update the TODO in the Adaptive Toolbar This CL updates the TODO numbers of the Adaptive Toolbar from a generic bug to bugs number specific to the place where the TODO is. It also updates the omnibox state when the toolbar is updated by BVC. Bug: 799438 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: I878ff2d1f1a59f460f953b3c5a5c26ce39bc2b7b Reviewed-on: https://chromium-review.googlesource.com/873130 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#530548} [modify] https://crrev.com/286f9df80a798c985145c09fe2d8e7f421a80ae2/ios/chrome/browser/ui/toolbar/adaptive/adaptive_toolbar_coordinator.mm [modify] https://crrev.com/286f9df80a798c985145c09fe2d8e7f421a80ae2/ios/chrome/browser/ui/toolbar/adaptive/primary_toolbar_coordinator.mm [modify] https://crrev.com/286f9df80a798c985145c09fe2d8e7f421a80ae2/ios/chrome/browser/ui/toolbar/clean/toolbar_coordinator.mm
Comment 1 by bugdroid1@chromium.org
, Jan 10 2018