New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 799417 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug-Regression



Sign in to add a comment

New context menu is not opening LINK tab by default

Project Member Reported by mar...@mwiacek.com, Jan 5 2018

Issue description

Steps to reproduce the problem:
1. open new context menu on entry with picture/video with link

What is the expected behavior?
LINK tab is opened by default; I believe, that users are more interested in options like "Open link in new tab" or "Open link in new incognito tab" than options related to pictures or videos.

This is my guess based on some observations, in worst case some statistics should be collected and solution should be based on it

What went wrong?
PICTURE/VIDEO tab is opened by default

Did this work before? Yes Problem didn't exist in old context menu

Chrome version: 65.0.3311.0  Channel: canary
OS Version: 7
Flash Version:
 
attachment.png
598 KB View Download
Labels: Needs-triage-Mobile
Cc: sandeepkumars@chromium.org
Components: -UI UI>Browser>Mobile>NavPanel
Labels: Triaged-Mobile
Tested the issue in Android and could not reproduce the issue. Observed the context menu with all available options.

Steps Followed:
1. Launched Chrome .
2. Navigated to http://m.demotywatory.pl/
3. Observed the context menu with all available options.


Chrome versions tested:
65.0.3312.0

OS
Android 7.0.0

Android Devices
S7, 7.0.0; SM-G935F Build/NRD90M

Adding related component for further triaging of the issue.

Thanks!!

Comment 3 by mar...@mwiacek.com, Jan 8 2018

OK, I will ask this way - when you have two tabs in new context menu, which open is selected by default?

Bug/FR is about this that LINK is not selected.
Cc: danielpark@chromium.org hannahs@chromium.org
I believe hannahs@ is investigating a new menu spec that does not include tabs, so hopefully that would get addressed by that.
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6ada544c49a900ff6e94ea8ae7f3361967b1b879

commit 6ada544c49a900ff6e94ea8ae7f3361967b1b879
Author: Marcin <marcin@mwiacek.com>
Date: Tue Feb 06 13:58:41 2018

Move LINK tab to the beginning in the new Android context menu

Currently Android Chrome is opening LINK tab as second in
new context menu with two tabs. It can lead to many mistakes
when user want to use fast "Open in new menu" for links.

Patch is forcing changing tabs order and opening this menu
on LINK tab in every situation.

Bug:  799417 
Change-Id: I1ef989a62501859c45e8a0ee36e6e685e234ed72
Reviewed-on: https://chromium-review.googlesource.com/880945
Commit-Queue: Marcin WiÄ…cek <marcin@mwiacek.com>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534683}
[modify] https://crrev.com/6ada544c49a900ff6e94ea8ae7f3361967b1b879/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/ChromeContextMenuPopulator.java

Comment 7 by mar...@mwiacek.com, Feb 6 2018

Owner: mar...@mwiacek.com
Status: Started (was: Unconfirmed)

Comment 8 by mar...@mwiacek.com, Feb 7 2018

Status: Fixed (was: Started)

Sign in to add a comment