Move browser_backend._forwarder to devtools_client |
|||||
Issue descriptionWe've realized that the right place for the browser_backend._forwarder to live is actually _within_ the DevToolsClientBackend, as it created specifically to connect to it, and their lifetimes should be tied together (i.e. when closing the devtools_client one should also close the forwarder).
,
Apr 30 2018
,
May 14 2018
Some pointers. DevToolsClientBackend: https://cs.chromium.org/chromium/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py?rcl=b424d15a6070120cc1d332856fc5649e3d9a5efc&l=40 Clients that need to be moved: https://cs.chromium.org/search/?q=TODO.*799415%5C)+-file:%5Esrc/third_party/android_tools+-file:%5Einfra/infra/services/android_docker
,
Jul 13
Short test to excersize the code: ./bin/run_tests testStopTracingWhileBrowserIsRunning --browser android-system-chrome
,
Jul 25
The following revision refers to this bug: https://chromium.googlesource.com/catapult/+/a4627f217f29223ed342a3551991fbd33874c863 commit a4627f217f29223ed342a3551991fbd33874c863 Author: Simon Pick <picksi@chromium.org> Date: Wed Jul 25 15:22:30 2018 Moving forwarder creation into DevToolsClientConfig Bug: chromium:799415 Change-Id: Iacd9246a89c82257ab9bed1a22c2f36f9c344ca8 Reviewed-on: https://chromium-review.googlesource.com/1138321 Commit-Queue: Simon Pick <picksi@chromium.org> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> [modify] https://crrev.com/a4627f217f29223ed342a3551991fbd33874c863/telemetry/telemetry/internal/backends/chrome/chrome_browser_backend.py [modify] https://crrev.com/a4627f217f29223ed342a3551991fbd33874c863/telemetry/telemetry/internal/app/android_process.py [modify] https://crrev.com/a4627f217f29223ed342a3551991fbd33874c863/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py
,
Jul 25
,
Jul 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/929f61802478736d69921f1ec03f49f80eba22d5 commit 929f61802478736d69921f1ec03f49f80eba22d5 Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Wed Jul 25 19:38:38 2018 Roll src/third_party/catapult d35e4d092bb2..b76f0192a83a (3 commits) https://chromium.googlesource.com/catapult.git/+log/d35e4d092bb2..b76f0192a83a git log d35e4d092bb2..b76f0192a83a --date=short --no-merges --format='%ad %ae %s' 2018-07-25 dtu@chromium.org [pinpoint] Add ability to add aliases to bot configurations. 2018-07-25 picksi@chromium.org Moving forwarder creation into DevToolsClientConfig 2018-07-25 anthonyalridge@google.com Create ability to zoom on line charts. Created with: gclient setdep -r src/third_party/catapult@b76f0192a83a The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:799415 ,chromium:866423 TBR=sullivan@chromium.org Change-Id: I65ceb8a478e95740887a081eeb2c246730c02f58 Reviewed-on: https://chromium-review.googlesource.com/1150361 Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#578018} [modify] https://crrev.com/929f61802478736d69921f1ec03f49f80eba22d5/DEPS
,
Jan 16
(6 days ago)
,
Jan 16
(6 days ago)
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by perezju@chromium.org
, Jan 5 2018