New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 799415 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Move browser_backend._forwarder to devtools_client

Project Member Reported by perezju@chromium.org, Jan 5 2018

Issue description

We've realized that the right place for the browser_backend._forwarder to live is actually _within_ the DevToolsClientBackend, as it created specifically to connect to it, and their lifetimes should be tied together (i.e. when closing the devtools_client one should also close the forwarder).

 
Components: Speed>Telemetry
Labels: -Pri-2 Pri-3
Short test to excersize the code:

./bin/run_tests testStopTracingWhileBrowserIsRunning --browser android-system-chrome

Cc: perezju@chromium.org
Owner: picksi@chromium.org
Status: Fixed (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/929f61802478736d69921f1ec03f49f80eba22d5

commit 929f61802478736d69921f1ec03f49f80eba22d5
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Wed Jul 25 19:38:38 2018

Roll src/third_party/catapult d35e4d092bb2..b76f0192a83a (3 commits)

https://chromium.googlesource.com/catapult.git/+log/d35e4d092bb2..b76f0192a83a


git log d35e4d092bb2..b76f0192a83a --date=short --no-merges --format='%ad %ae %s'
2018-07-25 dtu@chromium.org [pinpoint] Add ability to add aliases to bot configurations.
2018-07-25 picksi@chromium.org Moving forwarder creation into DevToolsClientConfig
2018-07-25 anthonyalridge@google.com Create ability to zoom on line charts.


Created with:
  gclient setdep -r src/third_party/catapult@b76f0192a83a

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:799415 ,chromium:866423
TBR=sullivan@chromium.org

Change-Id: I65ceb8a478e95740887a081eeb2c246730c02f58
Reviewed-on: https://chromium-review.googlesource.com/1150361
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#578018}
[modify] https://crrev.com/929f61802478736d69921f1ec03f49f80eba22d5/DEPS

Comment 8 by benhenry@google.com, Jan 16 (6 days ago)

Components: Test>Telemetry

Comment 9 by benhenry@google.com, Jan 16 (6 days ago)

Components: -Speed>Telemetry

Sign in to add a comment