New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 799414 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 2
Type: Bug



Sign in to add a comment

Password entry vanishes after hitting enter key twice in password bubble of twitter.com

Reported by vku...@etouch.net, Jan 5 2018

Issue description

Chrome Version: 65.0.3311.3 (Official Build) 5ee9dc045602ca225269c3f27f12305955de9ffb-refs/branch-heads/3311@{#5} (32/64-bit)
OS:Win(7,8,8.1,10), Linux(14.04 LTS)

Precondition: Navigate to https://twitter.com/ and save two password entries from password bubble.

What steps will reproduce the problem?
(1)Launch chrome navigate to https://twitter.com/ click on "logout" button
(2)Click on bubble, press tab key > enter to delete > tab key > enter key to undo delete, again press enter key such that overlay closes.
(3)Now click on password bubble and observe the entry.

Actual: Password entry vanishes after hitting enter key twice (i.e after step 2 & 3)

Expected: Password entry should be displayed even if enter key is press twice (i.e after step 2 & 3)

This is a Non-regression issue seen from 'M45' series i.e 45.0.2404.0

Note: Issue not seen on Mac OS.

 
Actual_twitter.mp4
1.5 MB View Download
Labels: Target-65 FoundIn-65
Status: Untriaged (was: Unconfirmed)
Untriaged it so that issue gets addressed.
Cc: vasi...@chromium.org kolos@chromium.org
Labels: -M-65 -Target-65
Status: Available (was: Untriaged)
Thanks for reporting. This is a bug... Given that not data is lost, I am removing the M65 target. Maybe we can fix this in the scope of looking into polishing the save and update bubbles.
Owner: vasi...@chromium.org
Status: Started (was: Available)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/83996e4d8a2538580bc12487d02a8573b1080186

commit 83996e4d8a2538580bc12487d02a8573b1080186
Author: Vasilii Sukhanov <vasilii@chromium.org>
Date: Fri Jan 12 16:43:59 2018

Handle properly addition of a new credential in the password UI.

ManagePasswordsUIController tracks changes to the password store in order to show relevant credentials in the bubble. The condition was comparing the whole URL. When a credential for the same origin is added it should be depicted in the "Manage passwords" bubble.

Bug:  799414 
Change-Id: Ibd167e02ff0aa6b573ed73f954dacd3363f632a7
Reviewed-on: https://chromium-review.googlesource.com/860012
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Maxim Kolosovskiy <kolos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528969}
[modify] https://crrev.com/83996e4d8a2538580bc12487d02a8573b1080186/chrome/browser/ui/passwords/manage_passwords_state.cc
[modify] https://crrev.com/83996e4d8a2538580bc12487d02a8573b1080186/chrome/browser/ui/passwords/manage_passwords_state_unittest.cc

Status: Fixed (was: Started)
Labels: ET-MUM-Reported

Sign in to add a comment