Non-Regression : Able to click on disabled Backspace option in 'Enter your PIN' overlay of chrome://settings/lockScreen page |
|||
Issue descriptionChrome Version: 65.0.3311.0/10280.0.0 dev channel Daisy,Kip,Reks OS: Chrome What steps will reproduce the problem? (1)Sign into User -> Go to chrome://settings -> Now under 'People' section click on 'Screen lock' option 2)Now enter User Password in 'Confirm your password' dialog box -> At 'screen lock options' section select 'PIN or Password' option -> click on 'SET UP PIN' (3)In 'Enter your PIN' overlay hover mouse on 'Backspace' option and observe unnecessary hand pointer is seen and on able to click (Please refer Video) (4)In 'Enter your PIN' overlay (Observe default focus is on 'PIN' field) press 'Tab' button and wait until wait until focus reaches to '0' (Focus moves from digit '1') -> Now again press 'Tab' button and observe focus is on disabled 'Backspace' option and click on 'Enter' button and observe able to click (Please refer Video and screenshot) Expected: a)Arrow pointer should be seen on disabled 'Backspace' option and should not be able to click b)Tab Focus should not be seen on disabled 'Backspace' option Actual: Instead a)unnecessary hand pointer is seen on disabled 'Backspace' option and should be able to click b)Tab Focus is seen on disabled 'Backspace' option This is Non-Regression Issue as 'Screen lock' option is introduced from M-57 @sammiequon : Please confirm the Issue
,
Jan 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/02b2e2dc078d01b1bd4e273126f02fcf58ade6c8 commit 02b2e2dc078d01b1bd4e273126f02fcf58ade6c8 Author: Mike Wittman <wittman@chromium.org> Date: Tue Jan 09 00:17:57 2018 Revert "settings: Disable backspace button on setup pin dialog when nothing entered." This reverts commit f66cf13a011713683612732274e0713e16dc1456. Reason for revert: CrSettingsPeoplePageSetupPinDialogTest.All failures on linux-chromeos-rel https://uberchromegw.corp.google.com/i/chromium.chromiumos/builders/linux-chromeos-rel [8877:8877:0108/154615.238105:INFO:CONSOLE(1225)] "Running TestCase CrSettingsPeoplePageSetupPinDialogTest.All", source: test_api.js (1225) [8877:8877:0108/154615.760757:ERROR:CONSOLE(48)] "Mocha test failed: setup-pin-dialog BackspaceDisabledWhenNothingEntered AssertionError: expected false to be true at Function.assert.isTrue (chai.js:2423:31) at assertTrue (test_api.js:853:17) at Context.<anonymous> (quick_unlock_authenticate_browsertest_chromeos.js:552:9) ", source: mocha_adapter.js (48) [8877:8877:0108/154615.761596:ERROR:web_ui_test_handler.cc(82)] Test Errors: 1/13 tests had failed assertions. [8877:8877:0108/154615.761615:ERROR:web_ui_browser_test.cc(475)] CONDITION FAILURE: encountered javascript console error(s): [8877:8877:0108/154615.761620:ERROR:web_ui_browser_test.cc(477)] JS ERROR: '[8877:8877:0108/154615.760757:ERROR:CONSOLE(48)] "Mocha test failed: setup-pin-dialog BackspaceDisabledWhenNothingEntered AssertionError: expected false to be true at Function.assert.isTrue (chai.js:2423:31) at assertTrue (test_api.js:853:17) at Context.<anonymous> (quick_unlock_authenticate_browsertest_chromeos.js:552:9) ", source: mocha_adapter.js (48) ' Original change's description: > settings: Disable backspace button on setup pin dialog when nothing entered. > > Test: browser_tests CrSettingsPeoplePageSetupPinDialogTest.* > Bug: 799388 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: Ia1b5ce69bd13c4e9127b04fcbaf67751a6f86cdc > Reviewed-on: https://chromium-review.googlesource.com/854742 > Reviewed-by: Steven Bennetts <stevenjb@chromium.org> > Commit-Queue: Sammie Quon <sammiequon@chromium.org> > Cr-Commit-Position: refs/heads/master@{#527776} TBR=stevenjb@chromium.org,sammiequon@chromium.org Change-Id: I3f62e8657bcc5e2f7dde00104c640508189c7306 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 799388 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/855101 Reviewed-by: Mike Wittman <wittman@chromium.org> Commit-Queue: Mike Wittman <wittman@chromium.org> Cr-Commit-Position: refs/heads/master@{#527822} [modify] https://crrev.com/02b2e2dc078d01b1bd4e273126f02fcf58ade6c8/chrome/browser/resources/chromeos/quick_unlock/md_pin_keyboard.html [modify] https://crrev.com/02b2e2dc078d01b1bd4e273126f02fcf58ade6c8/chrome/browser/resources/chromeos/quick_unlock/pin_keyboard.html [modify] https://crrev.com/02b2e2dc078d01b1bd4e273126f02fcf58ade6c8/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js
,
Feb 2 2018
,
Mar 2 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea6dc5c9361e24734dbbbe19a05a0e82de75fd29 commit ea6dc5c9361e24734dbbbe19a05a0e82de75fd29 Author: Sammie Quon <sammiequon@google.com> Date: Fri Mar 02 01:46:51 2018 settings: Disable backspace button on setup pin when nothing entered. Also rename element -> testElement in the test as it mirrors the a local in a couple places. Test: browser_tests CrSettingsPeoplePageSetupPinDialogTest.* Bug: 799388 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I5ec0de7a85575cd6fa13f64ae5ce76cf5da08573 Reviewed-on: https://chromium-review.googlesource.com/943930 Commit-Queue: Sammie Quon <sammiequon@chromium.org> Reviewed-by: Steven Bennetts <stevenjb@chromium.org> Cr-Commit-Position: refs/heads/master@{#540404} [modify] https://crrev.com/ea6dc5c9361e24734dbbbe19a05a0e82de75fd29/chrome/test/data/webui/settings/quick_unlock_authenticate_browsertest_chromeos.js [modify] https://crrev.com/ea6dc5c9361e24734dbbbe19a05a0e82de75fd29/ui/webui/resources/cr_components/chromeos/quick_unlock/pin_keyboard.html
,
Mar 2 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jan 8 2018