Issue metadata
Sign in to add a comment
|
Regression: Zoom icon stays in omnibox even after the page zoom is reset to 100%.
Reported by
vineetha...@etouch.net,
Jan 5 2018
|
||||||||||||||||||||||
Issue descriptionChrome Version: 65.0.3311.3 5ee9dc045602ca225269c3f27f12305955de9ffb-refs/branch-heads/3311@{#5} (32/64 bit) OS:Win(7,8.1,10) and Linux(14.04 LTS). What steps will reproduce the problem? (1) Launch Chrome, open NTP. (2) Press Ctrl-- to Zoom out and then Click on Reset Button of zoom bubble Observe. Actual: Zoom icon stays in omnibox even after the page zoom is reset to 100%. Expected: Zoom icon should not stay in omnibox even after the page zoom is reset to 100%. This is a regression issue, broken in 'M65',Using the per-revision bisect providing the bisect results, Good Build: 65.0.3310.0 Bad Build: 65.0.3311.0 Kindly refer the Bisect-info: You are probably looking for a change made after 526877 (known good), but no later than 526878 (first known bad). CHANGELOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/4ef1489a3540ce9ba17bef09235f1da8b28ce866..564596564fe028e0ebc0e284906a631318f1ca64 Suspect : https://chromium.googlesource.com/chromium/src/+/564596564fe028e0ebc0e284906a631318f1ca64 @tapted: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Issue is not reproducible on Mac OS. Thank You!
,
Jan 8 2018
tapted@ Gentle ping! This issue is marked as RB-Beta for M65, could you please take a look in to this issue? Thanks!
,
Jan 8 2018
It's in my queue, but not started. (it's only been a weekend after all :). I suspect I know what the problem is.
,
Jan 11 2018
,
Jan 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4522efba74e35026b0f62cb1c97d793a92a0d5da commit 4522efba74e35026b0f62cb1c97d793a92a0d5da Author: Trent Apted <tapted@chromium.org> Date: Mon Jan 15 00:05:45 2018 Fix stray zoom icon remaining after closing zoom bubble at 100% This regressed in r526878 which fixed a site that was passing a deleted WebContents to browser_finder in some cases. Only Mac reliably sets a parent_window() (but not an anchor view). To fix, find the parent window via the SessionID of the Browser* that created the bubble initially. Add a test. Bug: 799384 Change-Id: I95c7f4fcd94bc451e252d489ec6be9dc57deeced Reviewed-on: https://chromium-review.googlesource.com/861363 Commit-Queue: Trent Apted <tapted@chromium.org> Reviewed-by: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#529187} [add] https://crrev.com/4522efba74e35026b0f62cb1c97d793a92a0d5da/chrome/browser/ui/views/location_bar/location_bar_view_browsertest.cc [modify] https://crrev.com/4522efba74e35026b0f62cb1c97d793a92a0d5da/chrome/browser/ui/views/location_bar/zoom_bubble_view.cc [modify] https://crrev.com/4522efba74e35026b0f62cb1c97d793a92a0d5da/chrome/browser/ui/views/location_bar/zoom_bubble_view.h [modify] https://crrev.com/4522efba74e35026b0f62cb1c97d793a92a0d5da/chrome/test/BUILD.gn
,
Jan 15 2018
,
Feb 2 2018
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ranjitkan@chromium.org
, Jan 5 2018