New issue
Advanced search Search tips

Issue 799372 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression

Blocking:
issue angleproject:2264



Sign in to add a comment

72% regression in angle_perftests at 526380:526921

Project Member Reported by jmadill@google.com, Jan 5 2018

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=799372

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=6a9989cfa2f4437e4ba078266f4ad032d1bdb78355d01d99f8d654cb235a7d43


Bot(s) for this bug's original alert(s):

chromium-rel-win7-gpu-nvidia
๐Ÿ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/14bd2ac3040000
Cc: -jmadill@google.com simonhatch@chromium.org
Simon, does the new bisect tool not work with ANGLE?
Oh, nevermind, it's still running I think.
It should work fine with angle, but it looks here like the test was broken in the range, maybe from  crbug.com/798866 ?
Blocking: 2264
Good call, I think you're right. In any case can repro this easily locally, so no problem in fixing it. Thanks. Would it be worth filing a feature request for a message from the pinpoint job explaining when/why it fails?
Blocking: -2264 angleproject:2264
Yep definitely worth filing, just make an issue on github and add me/dtu.
Happy to - can you link me to the github project?
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/angle/angle/+/97f39b3c912be36113252d19946354a525c6618f

commit 97f39b3c912be36113252d19946354a525c6618f
Author: Jamie Madill <jmadill@chromium.org>
Date: Fri Jan 05 19:51:19 2018

Vulkan: Add missing command queue reset to flush.

This was causing a heavy performance regression in the Vulkan perf
test. Local testing shows it recovers most of the performance gap
with this fix.

Bug:  angleproject:2264 
Bug:  chromium:799372 
Change-Id: Ia2bbf526b305e1b2e901d904574dbe5618e6e5ef
Reviewed-on: https://chromium-review.googlesource.com/852365
Reviewed-by: Frank Henigman <fjhenigman@chromium.org>
Commit-Queue: Jamie Madill <jmadill@chromium.org>

[modify] https://crrev.com/97f39b3c912be36113252d19946354a525c6618f/src/libANGLE/renderer/vulkan/RendererVk.cpp

Cc: angle-deps-roller@chromium.org
Owner: angle-deps-roller@chromium.org
๐Ÿ“ Found significant differences after each of 2 commits.
https://pinpoint-dot-chromeperf.appspot.com/job/14bd2ac3040000

Roll src/third_party/angle/ b8cb939f5..49ac74bd4 (1 commit)
By angle-deps-roller@chromium.org ยท Fri Dec 29 21:27:32 2017
chromium @ 73b733a207613d78de0ea885e20b3c47a2ff6753

Roll src/third_party/angle/ 6df487ef1..47c8ea3fb (1 commit)
By angle-deps-roller@chromium.org ยท Thu Jan 04 04:18:39 2018
chromium @ ff297515c4523778f96142ba88f1b8c399630321

Understanding performance regressions:
  http://g.co/ChromePerformanceRegressions
Status: Fixed (was: Assigned)
Graph has seemingly recovered with the fix in comment #12.

Sign in to add a comment