Issue metadata
Sign in to add a comment
|
72% regression in angle_perftests at 526380:526921 |
||||||||||||||||||||
Issue descriptionSee the link to graphs below.
,
Jan 5 2018
๐ Pinpoint job started. https://pinpoint-dot-chromeperf.appspot.com/job/14bd2ac3040000
,
Jan 5 2018
Simon, does the new bisect tool not work with ANGLE?
,
Jan 5 2018
Oh, nevermind, it's still running I think.
,
Jan 5 2018
It should work fine with angle, but it looks here like the test was broken in the range, maybe from crbug.com/798866 ?
,
Jan 5 2018
Good call, I think you're right. In any case can repro this easily locally, so no problem in fixing it. Thanks. Would it be worth filing a feature request for a message from the pinpoint job explaining when/why it fails?
,
Jan 5 2018
,
Jan 5 2018
Yep definitely worth filing, just make an issue on github and add me/dtu.
,
Jan 5 2018
Happy to - can you link me to the github project?
,
Jan 5 2018
,
Jan 5 2018
Thanks, filed https://github.com/catapult-project/catapult/issues/4146
,
Jan 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/97f39b3c912be36113252d19946354a525c6618f commit 97f39b3c912be36113252d19946354a525c6618f Author: Jamie Madill <jmadill@chromium.org> Date: Fri Jan 05 19:51:19 2018 Vulkan: Add missing command queue reset to flush. This was causing a heavy performance regression in the Vulkan perf test. Local testing shows it recovers most of the performance gap with this fix. Bug: angleproject:2264 Bug: chromium:799372 Change-Id: Ia2bbf526b305e1b2e901d904574dbe5618e6e5ef Reviewed-on: https://chromium-review.googlesource.com/852365 Reviewed-by: Frank Henigman <fjhenigman@chromium.org> Commit-Queue: Jamie Madill <jmadill@chromium.org> [modify] https://crrev.com/97f39b3c912be36113252d19946354a525c6618f/src/libANGLE/renderer/vulkan/RendererVk.cpp
,
Jan 7 2018
๐ Found significant differences after each of 2 commits. https://pinpoint-dot-chromeperf.appspot.com/job/14bd2ac3040000 Roll src/third_party/angle/ b8cb939f5..49ac74bd4 (1 commit) By angle-deps-roller@chromium.org ยท Fri Dec 29 21:27:32 2017 chromium @ 73b733a207613d78de0ea885e20b3c47a2ff6753 Roll src/third_party/angle/ 6df487ef1..47c8ea3fb (1 commit) By angle-deps-roller@chromium.org ยท Thu Jan 04 04:18:39 2018 chromium @ ff297515c4523778f96142ba88f1b8c399630321 Understanding performance regressions: http://g.co/ChromePerformanceRegressions
,
Jan 9 2018
Graph has seemingly recovered with the fix in comment #12. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by 42576172...@developer.gserviceaccount.com
, Jan 5 2018