New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 799363 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug-Security

Blocking:
issue 771995



Sign in to add a comment

Crash in mov_read_trun

Project Member Reported by ClusterFuzz, Jan 5 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5374190940323840

Fuzzer: libFuzzer_media_pipeline_integration_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: UNKNOWN WRITE
Crash Address: 0x060db79f3be8
Crash State:
  mov_read_trun
  mov_read_default
  mov_read_default
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=515364:515426

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5374190940323840

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jan 5 2018

Components: Internals>Media>FFmpeg
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jan 5 2018

Cc: jstebb...@jetheaddev.com
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

mov: fix decode of fragments that overlap in time by jstebbins@jetheaddev.com - https://chromium.googlesource.com/chromium/third_party/ffmpeg/+/4a9d32baca3af0d1831f9556a922c7ab5b426b10

If this is incorrect, please apply the Test-Predator-Wrong-CLs label.
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 5 2018

Labels: M-64
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 5 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Jan 5 2018

Labels: Pri-1
Cc: mich...@niedermayer.cc dalecur...@chromium.org
Labels: OS-Android OS-Chrome OS-Mac OS-Windows
Owner: sande...@chromium.org
Status: Assigned (was: Untriaged)
+some more people. Please follow up on this, thanks!

Comment 7 by cmasso@google.com, Jan 10 2018

sandersd@ are you looking into this issue?
FFmpeg clusterfuzz issues are pending the M65 FFmpeg roll, since some of the issues are likely to have been fixed upstream. The roll is in progress and should be completed soon.
Blocking: 771995
I am able to reproduce this prior to the M65 FFmpeg roll, but cannot after the roll. This issue is probably fixed upstream.
This issue was fixed by upstream commit 2d015d3bf9fed59c65a3819a35fedbb8b7dde623, "lavf/mov: fix huge alloc in mov_read_ctts".
Project Member

Comment 12 by ClusterFuzz, Jan 13 2018

ClusterFuzz has detected this issue as fixed in range 528999:529007.

Detailed report: https://clusterfuzz.com/testcase?key=5374190940323840

Fuzzer: libFuzzer_media_pipeline_integration_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: UNKNOWN WRITE
Crash Address: 0x060db79f3be8
Crash State:
  mov_read_trun
  mov_read_default
  mov_read_default
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=515364:515426
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=528999:529007

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5374190940323840

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 13 by ClusterFuzz, Jan 13 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 5374190940323840 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 14 by sheriffbot@chromium.org, Jan 13 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: Merge-Request-64
MR-64 for ffmpeg DEPS update to pull in commit in c#11
Project Member

Comment 16 by sheriffbot@chromium.org, Jan 16 2018

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: We are only 6 days from stable.
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 17 by cmasso@google.com, Jan 16 2018

Cc: awhalley@google.com
Labels: -Hotlist-Merge-Review -Merge-Review-64 Merge-Approved-64
Approving the merge since this is a severe security regression. Added awhalley@ to take a look as well.
Cc: abdulsyed@chromium.org
yep, would be great to take this - not looked into the size/coverage of the change, but if we get this merged today it'll still make the last 64 beta.
Project Member

Comment 19 by bugdroid1@chromium.org, Jan 16 2018

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chrome/tools/buildspec/+/d3f81700982851914e334ba680bf4613263de293

commit d3f81700982851914e334ba680bf4613263de293
Author: Dale Curtis <dalecurtis@chromium.org>
Date: Tue Jan 16 21:26:26 2018

Labels: -Merge-Approved-64 merge-merged-3282
Project Member

Comment 21 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Beta -M-64 M-65 Security_Impact-Stable
Labels: -ReleaseBlock-Stable
Project Member

Comment 23 by sheriffbot@chromium.org, Apr 21 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment