New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 799355 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Feb 2018
Cc:
Components:
EstimatedDays: 1
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Add CTAP request object with empty parameter

Project Member Reported by hongjunchoi@chromium.org, Jan 5 2018

Issue description

AuthenticatorGetNextAssertion, AuthenticatorCancel, AuthenticatorGetInfo, AuthenticatorReset commands in CTAP protocol does not have any parameters and can be serialized into one byte representing command type. Add objects to encapsulate theses requests. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 25 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/49c5cc87fc99ed67cb34d006f116dd8142205be7

commit 49c5cc87fc99ed67cb34d006f116dd8142205be7
Author: Jun Choi <hongjunchoi@chromium.org>
Date: Thu Jan 25 17:55:42 2018

Add CTAPRequest objects with empty parameter

AuthenticatorGetInfo, AuthenticatorGetNextAssertion, AuthenticatorReset,
and AuthenticatorCancel commands in CTAP protocol are requests with empty
parameter and are serialized to a single byte that represents command
type. Add object construct to encapsulate/serialize requests with empty
parameter.

Bug:  799355 
Change-Id: I05a876a17bfb3dc1c1ef21d830f330db503856f6
Reviewed-on: https://chromium-review.googlesource.com/851673
Commit-Queue: Jun Choi <hongjunchoi@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#531937}
[modify] https://crrev.com/49c5cc87fc99ed67cb34d006f116dd8142205be7/device/ctap/BUILD.gn
[add] https://crrev.com/49c5cc87fc99ed67cb34d006f116dd8142205be7/device/ctap/ctap_authenticator_request_param.cc
[add] https://crrev.com/49c5cc87fc99ed67cb34d006f116dd8142205be7/device/ctap/ctap_authenticator_request_param.h
[modify] https://crrev.com/49c5cc87fc99ed67cb34d006f116dd8142205be7/device/ctap/ctap_get_assertion_request_param.cc
[modify] https://crrev.com/49c5cc87fc99ed67cb34d006f116dd8142205be7/device/ctap/ctap_get_assertion_request_param.h
[modify] https://crrev.com/49c5cc87fc99ed67cb34d006f116dd8142205be7/device/ctap/ctap_make_credential_request_param.cc
[modify] https://crrev.com/49c5cc87fc99ed67cb34d006f116dd8142205be7/device/ctap/ctap_make_credential_request_param.h
[modify] https://crrev.com/49c5cc87fc99ed67cb34d006f116dd8142205be7/device/ctap/ctap_request_param.h
[modify] https://crrev.com/49c5cc87fc99ed67cb34d006f116dd8142205be7/device/ctap/ctap_request_unittest.cc

Status: Fixed (was: Untriaged)

Sign in to add a comment