New issue
Advanced search Search tips

Issue 799354 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Feature



Sign in to add a comment

chromium-build-stats: https only

Project Member Reported by ukai@google.com, Jan 5 2018

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/63.0.3239.108 Safari/537.36

Steps to reproduce the problem:
access http://chromium-build-stats.appspot.com

What is the expected behavior?
chromium-build-stats.appspot.com should be https only 
(http redirect to https)

What went wrong?
it served with http if requested.

Did this work before? N/A 

Chrome version: 63.0.3239.108  Channel: n/a
OS Version: 
Flash Version:
 

Comment 1 by ukai@chromium.org, Jan 5 2018

Components: Infra>Goma
Labels: -Pri-2 -Via-Wizard-Other Pri-3
Owner: ukai@chromium.org
Status: Assigned (was: Unconfirmed)
Project Member

Comment 2 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra/+/acbd3acc74d9dd27482309330b5b3f6c78ca1982

commit acbd3acc74d9dd27482309330b5b3f6c78ca1982
Author: Fumitoshi Ukai <ukai@google.com>
Date: Wed Mar 28 03:51:25 2018

chromium-build-stats: https only

add "secure: always" to redirect to https if http is used.
https://cloud.google.com/appengine/docs/standard/go/config/appref

Bug:  799354 
Change-Id: Ib9ba5ca999e52a80a4cd597c71a104984405eafc
Reviewed-on: https://chromium-review.googlesource.com/983073
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Yoshisato Yanagisawa <yyanagisawa@chromium.org>
Commit-Queue: Fumitoshi Ukai <ukai@chromium.org>

[modify] https://crrev.com/acbd3acc74d9dd27482309330b5b3f6c78ca1982/appengine/chromium_build_stats/default/app.yaml

Comment 3 by ukai@chromium.org, Mar 28 2018

Status: Fixed (was: Assigned)

Sign in to add a comment