New issue
Advanced search Search tips

Issue 799325 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security



Sign in to add a comment

Use-of-uninitialized-value in cc::PaintOpReader::Read

Project Member Reported by ClusterFuzz, Jan 5 2018

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4870900498563072

Fuzzer: libFuzzer_paint_op_buffer_eq_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  cc::PaintOpReader::Read
  cc::DrawImageRectOp::Deserialize
  cc::PaintOp::Deserialize
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=527091:527111

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4870900498563072

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jan 5 2018

Components: Internals>Compositing
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jan 5 2018

Labels: Test-Predator-Auto-Owner
Owner: ericrk@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/8b8436915204fb6de906de699e125123bf9b4b94 (OOP: Image Support).

If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.

Comment 3 by mmoroz@google.com, Jan 5 2018

Cc: enne@chromium.org
Project Member

Comment 4 by sheriffbot@chromium.org, Jan 5 2018

Labels: M-65
Project Member

Comment 5 by sheriffbot@chromium.org, Jan 5 2018

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 6 by sheriffbot@chromium.org, Jan 5 2018

Labels: Pri-1
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0552d25ffb709becf42d8e99ffb6a52f2d04002a

commit 0552d25ffb709becf42d8e99ffb6a52f2d04002a
Author: Eric Karl <ericrk@chromium.org>
Date: Mon Jan 08 18:57:30 2018

OOP: Check for reader validity in PaintImage deserialization

We were using a potentially uninitialized |transfer_cache_entry_id|, as
we didn't check for a successful read.

R=enne@chromium.org

Bug:  799325 
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
Change-Id: I1cf64698a85583ca96532ee5dfd2a75d4b3e8187
Reviewed-on: https://chromium-review.googlesource.com/853254
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527691}
[modify] https://crrev.com/0552d25ffb709becf42d8e99ffb6a52f2d04002a/cc/paint/paint_op_reader.cc

Project Member

Comment 8 by ClusterFuzz, Jan 9 2018

ClusterFuzz has detected this issue as fixed in range 527681:527694.

Detailed report: https://clusterfuzz.com/testcase?key=4870900498563072

Fuzzer: libFuzzer_paint_op_buffer_eq_fuzzer
Job Type: libfuzzer_chrome_msan
Platform Id: linux

Crash Type: Use-of-uninitialized-value
Crash Address: 
Crash State:
  cc::PaintOpReader::Read
  cc::DrawImageRectOp::Deserialize
  cc::PaintOp::Deserialize
  
Sanitizer: memory (MSAN)

Recommended Security Severity: Medium

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=527091:527111
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_msan&range=527681:527694

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4870900498563072

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Jan 9 2018

Labels: ClusterFuzz-Verified
Status: Verified (was: Assigned)
ClusterFuzz testcase 4870900498563072 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 10 by sheriffbot@chromium.org, Jan 9 2018

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Stable
Project Member

Comment 12 by sheriffbot@chromium.org, Mar 27 2018

Labels: -Security_Impact-Head Security_Impact-Stable
Project Member

Comment 13 by sheriffbot@chromium.org, Apr 17 2018

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment