New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 799319 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Feature

Blocked on:
issue 780980



Sign in to add a comment

Implement Face Detection on Mac OS based on Vision Framework

Project Member Reported by junwei...@intel.com, Jan 5 2018

Issue description


Vision Framework[1] supports high-performance image analysis and computer vision
techniques to identify faces in images and video which is more accurate than Core Image [2]. Adding nose landmarks which is 2D geometry, the proposal has been merged in commit[3].

[1] https://developer.apple.com/documentation/vision
[2] https://developer.apple.com/documentation/coreimage
[3] https://github.com/WICG/shape-detection-api/commit/a9705e181ba49ff6f4afbc1dec5eeedb79ca30c9

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f5403749bdc5b9f7f286155b0f8203239befd124

commit f5403749bdc5b9f7f286155b0f8203239befd124
Author: junweifu <junwei.fu@intel.com>
Date: Wed Jan 31 05:14:59 2018

ShapeDetection: Split Mac provider from Face Detection implementation

Split the provider in order to support Vision Framework [1] which is more
accurate and can detect more landmarks with computer vision techniques.
This proposal has been merged in Shape Detection specification [2].

Link Mac 10.13 build bots [3] and Face Detection demo[4] here.
Split original large CL[5] up in smaller subpatches including this CL.

[1] https://developer.apple.com/documentation/vision
[2] https://github.com/WICG/shape-detection-api/pull/38
[3] https://codepen.io/miguelao/pen/PmJWro
[4] https://ci.chromium.org/buildbot/chromium.fyi/Chromium%20Mac%2010.13/
[5] https://chromium-review.googlesource.com/c/chromium/src/+/867651/10

BUG= 799319 

Cq-Include-Trybots: master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Change-Id: I1910f572f83ae4def3d1f669af3fcd91d53b6305
Reviewed-on: https://chromium-review.googlesource.com/888478
Commit-Queue: Junwei Fu <junwei.fu@intel.com>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533208}
[modify] https://crrev.com/f5403749bdc5b9f7f286155b0f8203239befd124/services/shape_detection/BUILD.gn
[modify] https://crrev.com/f5403749bdc5b9f7f286155b0f8203239befd124/services/shape_detection/face_detection_impl_mac.mm
[add] https://crrev.com/f5403749bdc5b9f7f286155b0f8203239befd124/services/shape_detection/face_detection_provider_mac.h
[add] https://crrev.com/f5403749bdc5b9f7f286155b0f8203239befd124/services/shape_detection/face_detection_provider_mac.mm
[modify] https://crrev.com/f5403749bdc5b9f7f286155b0f8203239befd124/services/shape_detection/shape_detection_service.cc

Comment 2 by junwei...@intel.com, Feb 24 2018

Blockedon: 780980
Project Member

Comment 3 by bugdroid1@chromium.org, Mar 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b108a8db67a4eb1d508868b6af8573b54b7ac9e4

commit b108a8db67a4eb1d508868b6af8573b54b7ac9e4
Author: junweifu <junwei.fu@intel.com>
Date: Fri Mar 02 06:42:43 2018

ShapeDetection: Forward declaring the necessary symbols of Vision APIs

Forward declaring the necessary symbols in sdk_forward_declarations.h [1],
then use the @available(macOS 10.13, *) in the face detection provider to choose
different implementation.
Load dynamically Vision.framework with dlopen function[2].
Start the minimum implementation of mojom::FaceDetection based on Vision Framework.

Link Mac 10.13 build bots [3] and Face Detection demo[4] here.
Split original large CL[5] up in smaller subpatches including this CL.

[1] https://cs.chromium.org/chromium/src/base/mac/sdk_forward_declarations.h?sq=package:chromium&dr=CSs&l=5
[2] https://developer.apple.com/library/content/documentation/DeveloperTools/Conceptual/DynamicLibraries/100-Articles/DynamicLibraryUsageGuidelines.html
[3] https://ci.chromium.org/buildbot/chromium.fyi/Chromium%20Mac%2010.13/
[4] https://codepen.io/miguelao/pen/PmJWro
[5] https://chromium-review.googlesource.com/c/chromium/src/+/867651/10

BUG= 799319 

TBR=thakis@chromium.org

Cq-Include-Trybots: master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Change-Id: I18d06c7cadd9088d2c637258c8bd36299cb3c250
Reviewed-on: https://chromium-review.googlesource.com/900707
Commit-Queue: Junwei Fu <junwei.fu@intel.com>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#540465}
[modify] https://crrev.com/b108a8db67a4eb1d508868b6af8573b54b7ac9e4/base/mac/sdk_forward_declarations.h
[modify] https://crrev.com/b108a8db67a4eb1d508868b6af8573b54b7ac9e4/services/shape_detection/BUILD.gn
[add] https://crrev.com/b108a8db67a4eb1d508868b6af8573b54b7ac9e4/services/shape_detection/face_detection_impl_mac_vision.h
[add] https://crrev.com/b108a8db67a4eb1d508868b6af8573b54b7ac9e4/services/shape_detection/face_detection_impl_mac_vision.mm
[modify] https://crrev.com/b108a8db67a4eb1d508868b6af8573b54b7ac9e4/services/shape_detection/face_detection_provider_mac.mm

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 16 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa2bc5560ff1494349882bfe272affc5cfb973d5

commit aa2bc5560ff1494349882bfe272affc5cfb973d5
Author: junweifu <junwei.fu@intel.com>
Date: Fri Mar 16 09:07:03 2018

ShapeDetection: Dispatch asynchronously an image analysis request on a queue

Add AsyncRequest class to submit an image analysis request for asynchronous
execution on a dispatch queue with default priority.

Link Mac 10.13 build bots [2] and Face Detection demo[3] here.
Split original large CL[4] up in smaller subpatches including this CL.

[1] https://cs.chromium.org/chromium/src/base/mac/sdk_forward_declarations.h?sq=package:chromium&dr=CSs&l=5
[2] https://ci.chromium.org/buildbot/chromium.fyi/Chromium%20Mac%2010.13/
[3] https://codepen.io/miguelao/pen/PmJWro
[4] https://chromium-review.googlesource.com/c/chromium/src/+/912780/2

BUG= 799319 

Cq-Include-Trybots: master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Change-Id: I993d9f94299db464a109fb284356213413396f37
Reviewed-on: https://chromium-review.googlesource.com/947818
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Junwei Fu <junwei.fu@intel.com>
Cr-Commit-Position: refs/heads/master@{#543653}
[modify] https://crrev.com/aa2bc5560ff1494349882bfe272affc5cfb973d5/base/mac/sdk_forward_declarations.h
[modify] https://crrev.com/aa2bc5560ff1494349882bfe272affc5cfb973d5/services/shape_detection/detection_utils_mac.h
[modify] https://crrev.com/aa2bc5560ff1494349882bfe272affc5cfb973d5/services/shape_detection/detection_utils_mac.mm
[modify] https://crrev.com/aa2bc5560ff1494349882bfe272affc5cfb973d5/services/shape_detection/face_detection_impl_mac_vision.h
[modify] https://crrev.com/aa2bc5560ff1494349882bfe272affc5cfb973d5/services/shape_detection/face_detection_impl_mac_vision.mm
[modify] https://crrev.com/aa2bc5560ff1494349882bfe272affc5cfb973d5/services/shape_detection/face_detection_provider_mac.mm

Comment 5 by mcasas@chromium.org, Mar 16 2018

Does #4 fix this issue? Or do we still need more (unit) testing?
The implementation is incomplete. Parsing of the macOS SDK result into a shape detection result has not yet been landed.
Project Member

Comment 7 by bugdroid1@chromium.org, Mar 28 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3c492e35a14eccfcae1fc554d785e11f2b79cfb2

commit 3c492e35a14eccfcae1fc554d785e11f2b79cfb2
Author: junweifu <junwei.fu@intel.com>
Date: Wed Mar 28 01:08:39 2018

ShapeDetection: Parse the bounding box of the detected face

The coordinate are normalized to the dimensions of the processed image, with the
origin at the image's lower-left corner.

Link Mac 10.13 build bots [1] and Face Detection demo[2] here.
Split original large CL[3] up in smaller subpatches including this CL.

[1] https://ci.chromium.org/buildbot/chromium.fyi/Chromium%20Mac%2010.13/
[2] https://codepen.io/miguelao/pen/PmJWro
[3] https://chromium-review.googlesource.com/c/chromium/src/+/912780

BUG= 799319 

Cq-Include-Trybots: master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Change-Id: I6a370f45224f38328ea432b3cdde2cc9f7d17d01
Reviewed-on: https://chromium-review.googlesource.com/967566
Reviewed-by: Mark Mentovai <mark@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Junwei Fu <junwei.fu@intel.com>
Cr-Commit-Position: refs/heads/master@{#546350}
[modify] https://crrev.com/3c492e35a14eccfcae1fc554d785e11f2b79cfb2/base/mac/sdk_forward_declarations.h
[modify] https://crrev.com/3c492e35a14eccfcae1fc554d785e11f2b79cfb2/services/shape_detection/DEPS
[modify] https://crrev.com/3c492e35a14eccfcae1fc554d785e11f2b79cfb2/services/shape_detection/barcode_detection_impl_mac.mm
[modify] https://crrev.com/3c492e35a14eccfcae1fc554d785e11f2b79cfb2/services/shape_detection/detection_utils_mac.h
[modify] https://crrev.com/3c492e35a14eccfcae1fc554d785e11f2b79cfb2/services/shape_detection/detection_utils_mac.mm
[modify] https://crrev.com/3c492e35a14eccfcae1fc554d785e11f2b79cfb2/services/shape_detection/face_detection_impl_mac.mm
[modify] https://crrev.com/3c492e35a14eccfcae1fc554d785e11f2b79cfb2/services/shape_detection/face_detection_impl_mac_vision.h
[modify] https://crrev.com/3c492e35a14eccfcae1fc554d785e11f2b79cfb2/services/shape_detection/face_detection_impl_mac_vision.mm
[modify] https://crrev.com/3c492e35a14eccfcae1fc554d785e11f2b79cfb2/services/shape_detection/text_detection_impl_mac.mm

Project Member

Comment 8 by bugdroid1@chromium.org, Apr 2 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/756acd697b0cb2ac998ad3aa7799f28a6d4d3113

commit 756acd697b0cb2ac998ad3aa7799f28a6d4d3113
Author: Miguel Casas-Sanchez <mcasas@chromium.org>
Date: Mon Apr 02 18:01:54 2018

Face detection mac: extend unittests

This CL extends FaceDetectionImplMacTest to also use
FaceDetectionImplMacVision when appropriate.

services_unittests --gtest_filter=*Face* --use-gpu-in-tests

Bug:  799319 
Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Change-Id: I06c04d9773cac223f5f3612daa6a534a744fa9d8
Reviewed-on: https://chromium-review.googlesource.com/968671
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#547469}
[modify] https://crrev.com/756acd697b0cb2ac998ad3aa7799f28a6d4d3113/services/shape_detection/face_detection_impl_mac_unittest.mm
[modify] https://crrev.com/756acd697b0cb2ac998ad3aa7799f28a6d4d3113/services/shape_detection/face_detection_impl_mac_vision.mm

Project Member

Comment 9 by bugdroid1@chromium.org, Apr 12 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3620c48fea162c6ed38334f2213f564fb1d4c549

commit 3620c48fea162c6ed38334f2213f564fb1d4c549
Author: junweifu <junwei.fu@intel.com>
Date: Thu Apr 12 07:36:22 2018

ShapeDetection: Update location of landmark to a sequence of points in WebIDL

These points describe a well-defined area along the detected landmark.
The modification of Spec has been merged with PR-40[1].

[1] https://github.com/WICG/shape-detection-api/pull/40

BUG= 799319 

Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Change-Id: If82ed74ab3c85afd7ac525b089b17839970e89c7
Reviewed-on: https://chromium-review.googlesource.com/997760
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Commit-Queue: Junwei Fu <junwei.fu@intel.com>
Cr-Commit-Position: refs/heads/master@{#550080}
[modify] https://crrev.com/3620c48fea162c6ed38334f2213f564fb1d4c549/third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
[modify] https://crrev.com/3620c48fea162c6ed38334f2213f564fb1d4c549/third_party/blink/renderer/modules/shapedetection/face_detector.cc
[modify] https://crrev.com/3620c48fea162c6ed38334f2213f564fb1d4c549/third_party/blink/renderer/modules/shapedetection/landmark.idl

Project Member

Comment 10 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5e1aa79bdbec0c9e4dfdb1bb45a4aa2a1aee73c5

commit 5e1aa79bdbec0c9e4dfdb1bb45a4aa2a1aee73c5
Author: junweifu <junwei.fu@intel.com>
Date: Fri Apr 20 00:35:41 2018

ShapeDetection: Parse landmarks of the detected face on Mac Vision

Update the mojom interface definition of landmark to match the Spec, and adjust
the usage in services/blink/LayoutTests.
Export eyes and mouth landmarks that detect with Mac Vision Framework, the points
are normalized to the bounding box of the detected face, with the origin at the
bounding box of the detected face's lower-left corner.

Link Mac 10.13 build bots [1] and Face Detection demo[2] here.

[1] https://ci.chromium.org/buildbot/chromium.fyi/Chromium%20Mac%2010.13/
[2] https://codepen.io/miguelao/pen/PmJWro

BUG= 799319 

Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Change-Id: Id034721a517e4ab2a6b9aa0e3eec9d10997b5b80
Reviewed-on: https://chromium-review.googlesource.com/982579
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Mark Mentovai <mark@chromium.org>
Commit-Queue: Junwei Fu <junwei.fu@intel.com>
Cr-Commit-Position: refs/heads/master@{#552217}
[modify] https://crrev.com/5e1aa79bdbec0c9e4dfdb1bb45a4aa2a1aee73c5/base/mac/sdk_forward_declarations.h
[modify] https://crrev.com/5e1aa79bdbec0c9e4dfdb1bb45a4aa2a1aee73c5/services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImplGmsCore.java
[modify] https://crrev.com/5e1aa79bdbec0c9e4dfdb1bb45a4aa2a1aee73c5/services/shape_detection/face_detection_impl_mac.mm
[modify] https://crrev.com/5e1aa79bdbec0c9e4dfdb1bb45a4aa2a1aee73c5/services/shape_detection/face_detection_impl_mac_vision.mm
[modify] https://crrev.com/5e1aa79bdbec0c9e4dfdb1bb45a4aa2a1aee73c5/services/shape_detection/public/mojom/facedetection.mojom
[modify] https://crrev.com/5e1aa79bdbec0c9e4dfdb1bb45a4aa2a1aee73c5/third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
[modify] https://crrev.com/5e1aa79bdbec0c9e4dfdb1bb45a4aa2a1aee73c5/third_party/WebKit/LayoutTests/shapedetection/resources/mock-facedetection.js
[modify] https://crrev.com/5e1aa79bdbec0c9e4dfdb1bb45a4aa2a1aee73c5/third_party/blink/renderer/modules/shapedetection/face_detector.cc

Status: Fixed (was: Started)
Project Member

Comment 12 by bugdroid1@chromium.org, Apr 20 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7789a10073046b74e4b42290128f03e0f6452646

commit 7789a10073046b74e4b42290128f03e0f6452646
Author: Miguel Casas <mcasas@chromium.org>
Date: Fri Apr 20 22:04:26 2018

Revert "ShapeDetection: Parse landmarks of the detected face on Mac Vision"

This reverts commit 5e1aa79bdbec0c9e4dfdb1bb45a4aa2a1aee73c5.

Reason for revert: broke some tests, see  https://crbug.com/835379 

Bug:835379

Original change's description:
> ShapeDetection: Parse landmarks of the detected face on Mac Vision
> 
> Update the mojom interface definition of landmark to match the Spec, and adjust
> the usage in services/blink/LayoutTests.
> Export eyes and mouth landmarks that detect with Mac Vision Framework, the points
> are normalized to the bounding box of the detected face, with the origin at the
> bounding box of the detected face's lower-left corner.
> 
> Link Mac 10.13 build bots [1] and Face Detection demo[2] here.
> 
> [1] https://ci.chromium.org/buildbot/chromium.fyi/Chromium%20Mac%2010.13/
> [2] https://codepen.io/miguelao/pen/PmJWro
> 
> BUG= 799319 
> 
> Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng
> Change-Id: Id034721a517e4ab2a6b9aa0e3eec9d10997b5b80
> Reviewed-on: https://chromium-review.googlesource.com/982579
> Reviewed-by: Miguel Casas <mcasas@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Junwei Fu <junwei.fu@intel.com>
> Cr-Commit-Position: refs/heads/master@{#552217}

TBR=dcheng@chromium.org,reillyg@chromium.org,mcasas@chromium.org,junwei.fu@intel.com,mark@chromium.org

Change-Id: Ia6de675508ad324e12b4b9e98ae510b12d06b672
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  799319 
Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/1022891
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552488}
[modify] https://crrev.com/7789a10073046b74e4b42290128f03e0f6452646/base/mac/sdk_forward_declarations.h
[modify] https://crrev.com/7789a10073046b74e4b42290128f03e0f6452646/services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImplGmsCore.java
[modify] https://crrev.com/7789a10073046b74e4b42290128f03e0f6452646/services/shape_detection/face_detection_impl_mac.mm
[modify] https://crrev.com/7789a10073046b74e4b42290128f03e0f6452646/services/shape_detection/face_detection_impl_mac_vision.mm
[modify] https://crrev.com/7789a10073046b74e4b42290128f03e0f6452646/services/shape_detection/public/mojom/facedetection.mojom
[modify] https://crrev.com/7789a10073046b74e4b42290128f03e0f6452646/third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
[modify] https://crrev.com/7789a10073046b74e4b42290128f03e0f6452646/third_party/WebKit/LayoutTests/shapedetection/resources/mock-facedetection.js
[modify] https://crrev.com/7789a10073046b74e4b42290128f03e0f6452646/third_party/blink/renderer/modules/shapedetection/face_detector.cc

Status: Assigned (was: Fixed)
Reopening due to the revert.
Project Member

Comment 14 by bugdroid1@chromium.org, Apr 24 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/582398369d641cbd697faf73a8238c2343b0fb97

commit 582398369d641cbd697faf73a8238c2343b0fb97
Author: junweifu <junwei.fu@intel.com>
Date: Tue Apr 24 00:33:35 2018

Reland "ShapeDetection: Parse landmarks of the detected face on Mac Vision"

Original CL got reverted because the num of landmarks aren't updated in services
tests that aren't checked on GPU FYI.

This is a reland of 5e1aa79bdbec0c9e4dfdb1bb45a4aa2a1aee73c5

Original change's description:
> ShapeDetection: Parse landmarks of the detected face on Mac Vision
>
> Update the mojom interface definition of landmark to match the Spec, and adjust
> the usage in services/blink/LayoutTests.
> Export eyes and mouth landmarks that detect with Mac Vision Framework, the points
> are normalized to the bounding box of the detected face, with the origin at the
> bounding box of the detected face's lower-left corner.
>
> Link Mac 10.13 build bots [1] and Face Detection demo[2] here.
>
> [1] https://ci.chromium.org/buildbot/chromium.fyi/Chromium%20Mac%2010.13/
> [2] https://codepen.io/miguelao/pen/PmJWro
>
> BUG= 799319 
>
> Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng
> Change-Id: Id034721a517e4ab2a6b9aa0e3eec9d10997b5b80
> Reviewed-on: https://chromium-review.googlesource.com/982579
> Reviewed-by: Miguel Casas <mcasas@chromium.org>
> Reviewed-by: Daniel Cheng <dcheng@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Reviewed-by: Mark Mentovai <mark@chromium.org>
> Commit-Queue: Junwei Fu <junwei.fu@intel.com>
> Cr-Commit-Position: refs/heads/master@{#552217}

TBR=mark@chromium.org

Bug:  799319 
Change-Id: Id521f2a92dd3e1c6d8ac29d571bc1c58cfdb020e
Cq-Include-Trybots: luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Reviewed-on: https://chromium-review.googlesource.com/1023181
Commit-Queue: Junwei Fu <junwei.fu@intel.com>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552924}
[modify] https://crrev.com/582398369d641cbd697faf73a8238c2343b0fb97/base/mac/sdk_forward_declarations.h
[modify] https://crrev.com/582398369d641cbd697faf73a8238c2343b0fb97/services/shape_detection/android/java/src/org/chromium/shape_detection/FaceDetectionImplGmsCore.java
[modify] https://crrev.com/582398369d641cbd697faf73a8238c2343b0fb97/services/shape_detection/face_detection_impl_mac.mm
[modify] https://crrev.com/582398369d641cbd697faf73a8238c2343b0fb97/services/shape_detection/face_detection_impl_mac_unittest.mm
[modify] https://crrev.com/582398369d641cbd697faf73a8238c2343b0fb97/services/shape_detection/face_detection_impl_mac_vision.mm
[modify] https://crrev.com/582398369d641cbd697faf73a8238c2343b0fb97/services/shape_detection/public/mojom/facedetection.mojom
[modify] https://crrev.com/582398369d641cbd697faf73a8238c2343b0fb97/third_party/WebKit/LayoutTests/shapedetection/detection-HTMLImageElement.html
[modify] https://crrev.com/582398369d641cbd697faf73a8238c2343b0fb97/third_party/WebKit/LayoutTests/shapedetection/resources/mock-facedetection.js
[modify] https://crrev.com/582398369d641cbd697faf73a8238c2343b0fb97/third_party/blink/renderer/modules/shapedetection/face_detector.cc

Status: Fixed (was: Assigned)

Sign in to add a comment