[Findit] Flake Analyzer - Staging version is blocked due to culprit keys being strings |
|||
Issue descriptionIf you deploy a staging version, you won't be able to use the flake part of it because the culprit and suspect keys that are stored in the analyses are strings. This causes the app to search production data which isn't allowed. Example here: https://cs.chromium.org/chromium/infra/appengine/findit/model/flake/master_flake_analysis.py?l=470
,
Jan 5 2018
This is blocking use of staging app.
,
Jan 17 2018
,
Jan 17 2018
I'll do a quick fix, but the correct thing to do is to use ndb key properties for these keys instead of strings that hold the urlsafe keys. https://cloud.google.com/appengine/docs/standard/python/ndb/entity-property-reference
,
Jan 27 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/c5254ea4d0efb50193eb56f0f53d5bebbe557467 commit c5254ea4d0efb50193eb56f0f53d5bebbe557467 Author: Brandon Wylie <wylieb@chromium.org> Date: Sat Jan 27 00:00:58 2018 [Findit] Flake Analyzer - Fix culprit/suspect key errors for staging This is a quick workaround for the errors on staging, but not the correct fix. Added todos for proper fixes. Working staging: http://shortn/_DfwxIRzFWM Bug:799308 Change-Id: I8103e22ec525c2d4c892c148f64fd4d6c583374f Reviewed-on: https://chromium-review.googlesource.com/871770 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> Reviewed-by: Jeffrey Li <lijeffrey@chromium.org> [modify] https://crrev.com/c5254ea4d0efb50193eb56f0f53d5bebbe557467/appengine/findit/handlers/flake/check_flake.py [modify] https://crrev.com/c5254ea4d0efb50193eb56f0f53d5bebbe557467/appengine/findit/handlers/flake/list_flakes.py [modify] https://crrev.com/c5254ea4d0efb50193eb56f0f53d5bebbe557467/appengine/findit/model/flake/master_flake_analysis.py
,
Feb 1 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by wylieb@chromium.org
, Jan 5 2018