New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 799278 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Add a test validating the ZipFileInstaller fails with bad ZIP.

Project Member Reported by jcivelli@chromium.org, Jan 4 2018

Issue description

The unit-tests that test ZipFileInstaller don't test that it fails with bad extensions (missing a manifest).
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9b4ae6132876bb60b6f030b6d09ab67f2d270b1e

commit 9b4ae6132876bb60b6f030b6d09ab67f2d270b1e
Author: Jay Civelli <jcivelli@google.com>
Date: Fri Jan 05 23:49:35 2018

Adding a test validating the ZipFileInstaller fails with bad ZIP.

Adding a test that validates extensions with no manifest fail to be
unzipped by the ZipFileInstaller.
In an in-progress CL I broke it and realized the test did not check for
it.

Bug:  799278 
Change-Id: Ic7911c3cf07fd83d8cd3a9bf354ab3d03e4e594d
Reviewed-on: https://chromium-review.googlesource.com/851063
Commit-Queue: Jay Civelli <jcivelli@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527432}
[modify] https://crrev.com/9b4ae6132876bb60b6f030b6d09ab67f2d270b1e/chrome/browser/extensions/zipfile_installer_unittest.cc
[add] https://crrev.com/9b4ae6132876bb60b6f030b6d09ab67f2d270b1e/chrome/test/data/extensions/zipfile_installer/bad.zip
[add] https://crrev.com/9b4ae6132876bb60b6f030b6d09ab67f2d270b1e/chrome/test/data/extensions/zipfile_installer/bad/hello.txt

Status: Fixed (was: Untriaged)

Sign in to add a comment