This tracks the process of enabling window dragging in VR.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3e1646f63020a9a250e5e0e7af9368c56f746bb4 commit 3e1646f63020a9a250e5e0e7af9368c56f746bb4 Author: Biao She <bshe@chromium.org> Date: Sat Jan 06 00:25:13 2018 Window dragging in VR This CL adds the ability to drag window when "p" is pressed in test app. Currently, when drag started, the content window will snap to the new position first. And then the window (and all browsing elements) will move as the reticle move. Note that it is only enabled for test app yet. A follow up CL will enable it on Android behind a flag. Bug: 799270 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I8f3f6cb66e4f6edd1218d922d52c3aa4ac47516e Reviewed-on: https://chromium-review.googlesource.com/850833 Commit-Queue: Biao She <bshe@chromium.org> Reviewed-by: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#527452} [modify] https://crrev.com/3e1646f63020a9a250e5e0e7af9368c56f746bb4/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/3e1646f63020a9a250e5e0e7af9368c56f746bb4/chrome/browser/vr/elements/content_element.cc [add] https://crrev.com/3e1646f63020a9a250e5e0e7af9368c56f746bb4/chrome/browser/vr/elements/repositioner.cc [add] https://crrev.com/3e1646f63020a9a250e5e0e7af9368c56f746bb4/chrome/browser/vr/elements/repositioner.h [add] https://crrev.com/3e1646f63020a9a250e5e0e7af9368c56f746bb4/chrome/browser/vr/elements/repositioner_unittest.cc [modify] https://crrev.com/3e1646f63020a9a250e5e0e7af9368c56f746bb4/chrome/browser/vr/elements/ui_element_name.cc [modify] https://crrev.com/3e1646f63020a9a250e5e0e7af9368c56f746bb4/chrome/browser/vr/elements/ui_element_name.h [modify] https://crrev.com/3e1646f63020a9a250e5e0e7af9368c56f746bb4/chrome/browser/vr/elements/viewport_aware_root.cc [modify] https://crrev.com/3e1646f63020a9a250e5e0e7af9368c56f746bb4/chrome/browser/vr/elements/viewport_aware_root.h [modify] https://crrev.com/3e1646f63020a9a250e5e0e7af9368c56f746bb4/chrome/browser/vr/model/model.cc [modify] https://crrev.com/3e1646f63020a9a250e5e0e7af9368c56f746bb4/chrome/browser/vr/model/model.h [modify] https://crrev.com/3e1646f63020a9a250e5e0e7af9368c56f746bb4/chrome/browser/vr/model/ui_mode.h [modify] https://crrev.com/3e1646f63020a9a250e5e0e7af9368c56f746bb4/chrome/browser/vr/testapp/vr_test_context.cc [modify] https://crrev.com/3e1646f63020a9a250e5e0e7af9368c56f746bb4/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/3e1646f63020a9a250e5e0e7af9368c56f746bb4/chrome/browser/vr/vr_gl_util.cc [modify] https://crrev.com/3e1646f63020a9a250e5e0e7af9368c56f746bb4/chrome/browser/vr/vr_gl_util.h [modify] https://crrev.com/3e1646f63020a9a250e5e0e7af9368c56f746bb4/chrome/browser/vr/vr_gl_util_unittest.cc
Seems like this won't make 65.
Ian mentioned he was looking at this
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed26c34e32ebd478ebd8e42866d92fcfeeac0b58 commit ed26c34e32ebd478ebd8e42866d92fcfeeac0b58 Author: Ian Vollick <vollick@chromium.org> Date: Sat Jan 27 03:06:52 2018 [vr] Create a button to enable repositioning the content quad This CL creates a button that enters window repositioning mode. There is still a great deal of work to be done -- the behavior once we're in the mode is not what we ultimately want -- but this gets some of the infrastructure out of the way. Subsequent patches will refine the repositioning UX. Bug: 799270 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I826a5868d17ee2d1ed5e69b7e1c75eb81142623e Reviewed-on: https://chromium-review.googlesource.com/888540 Reviewed-by: Christopher Grant <cjgrant@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#532142} [modify] https://crrev.com/ed26c34e32ebd478ebd8e42866d92fcfeeac0b58/chrome/browser/vr/elements/button.h [modify] https://crrev.com/ed26c34e32ebd478ebd8e42866d92fcfeeac0b58/chrome/browser/vr/elements/repositioner.cc [modify] https://crrev.com/ed26c34e32ebd478ebd8e42866d92fcfeeac0b58/chrome/browser/vr/elements/repositioner.h [modify] https://crrev.com/ed26c34e32ebd478ebd8e42866d92fcfeeac0b58/chrome/browser/vr/elements/scaled_depth_adjuster.cc [modify] https://crrev.com/ed26c34e32ebd478ebd8e42866d92fcfeeac0b58/chrome/browser/vr/elements/scaled_depth_adjuster.h [modify] https://crrev.com/ed26c34e32ebd478ebd8e42866d92fcfeeac0b58/chrome/browser/vr/elements/ui_element.cc [modify] https://crrev.com/ed26c34e32ebd478ebd8e42866d92fcfeeac0b58/chrome/browser/vr/elements/ui_element.h [modify] https://crrev.com/ed26c34e32ebd478ebd8e42866d92fcfeeac0b58/chrome/browser/vr/elements/ui_element_name.cc [modify] https://crrev.com/ed26c34e32ebd478ebd8e42866d92fcfeeac0b58/chrome/browser/vr/elements/ui_element_name.h [modify] https://crrev.com/ed26c34e32ebd478ebd8e42866d92fcfeeac0b58/chrome/browser/vr/testapp/vr_test_context.cc [modify] https://crrev.com/ed26c34e32ebd478ebd8e42866d92fcfeeac0b58/chrome/browser/vr/ui.cc [modify] https://crrev.com/ed26c34e32ebd478ebd8e42866d92fcfeeac0b58/chrome/browser/vr/ui_scene_constants.h [modify] https://crrev.com/ed26c34e32ebd478ebd8e42866d92fcfeeac0b58/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/ed26c34e32ebd478ebd8e42866d92fcfeeac0b58/chrome/browser/vr/ui_scene_creator.h [modify] https://crrev.com/ed26c34e32ebd478ebd8e42866d92fcfeeac0b58/chrome/browser/vr/ui_unittest.cc [modify] https://crrev.com/ed26c34e32ebd478ebd8e42866d92fcfeeac0b58/chrome/browser/vr/vector_icons/BUILD.gn [add] https://crrev.com/ed26c34e32ebd478ebd8e42866d92fcfeeac0b58/chrome/browser/vr/vector_icons/reposition.icon
Moving this to M67 and downgrading to p2 as it is not on our required P1 features list; if I missed something please revert.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/77904f2529ae7adbe21a63153ca66ea6a82dd597 commit 77904f2529ae7adbe21a63153ca66ea6a82dd597 Author: Ian Vollick <vollick@chromium.org> Date: Fri Mar 09 21:12:00 2018 [vr] Support content resizing With this change, a user may both resize and reposition the content quad when in "repositioning" mode. Bug: 799270 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I86aed8d83db82998c64e982922e21298c6a243ec Reviewed-on: https://chromium-review.googlesource.com/956499 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Reviewed-by: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#542224} [modify] https://crrev.com/77904f2529ae7adbe21a63153ca66ea6a82dd597/chrome/browser/vr/BUILD.gn [modify] https://crrev.com/77904f2529ae7adbe21a63153ca66ea6a82dd597/chrome/browser/vr/elements/repositioner.h [add] https://crrev.com/77904f2529ae7adbe21a63153ca66ea6a82dd597/chrome/browser/vr/elements/resizer.cc [add] https://crrev.com/77904f2529ae7adbe21a63153ca66ea6a82dd597/chrome/browser/vr/elements/resizer.h [add] https://crrev.com/77904f2529ae7adbe21a63153ca66ea6a82dd597/chrome/browser/vr/elements/resizer_unittest.cc [modify] https://crrev.com/77904f2529ae7adbe21a63153ca66ea6a82dd597/chrome/browser/vr/elements/shadow.cc [modify] https://crrev.com/77904f2529ae7adbe21a63153ca66ea6a82dd597/chrome/browser/vr/elements/shadow.h [modify] https://crrev.com/77904f2529ae7adbe21a63153ca66ea6a82dd597/chrome/browser/vr/elements/ui_element.cc [modify] https://crrev.com/77904f2529ae7adbe21a63153ca66ea6a82dd597/chrome/browser/vr/elements/ui_element.h [modify] https://crrev.com/77904f2529ae7adbe21a63153ca66ea6a82dd597/chrome/browser/vr/elements/ui_element_name.cc [modify] https://crrev.com/77904f2529ae7adbe21a63153ca66ea6a82dd597/chrome/browser/vr/elements/ui_element_name.h [modify] https://crrev.com/77904f2529ae7adbe21a63153ca66ea6a82dd597/chrome/browser/vr/testapp/vr_test_context.cc [modify] https://crrev.com/77904f2529ae7adbe21a63153ca66ea6a82dd597/chrome/browser/vr/testapp/vr_test_context.h [modify] https://crrev.com/77904f2529ae7adbe21a63153ca66ea6a82dd597/chrome/browser/vr/ui_scene_constants.h [modify] https://crrev.com/77904f2529ae7adbe21a63153ca66ea6a82dd597/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/77904f2529ae7adbe21a63153ca66ea6a82dd597/chrome/browser/vr/ui_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/af05373481b3e4a0ec4e72e4faab88dbd5d97c87 commit af05373481b3e4a0ec4e72e4faab88dbd5d97c87 Author: Ian Vollick <vollick@chromium.org> Date: Mon Mar 19 16:39:57 2018 [vr] Reposition / resize via window frame Previously, we would reposition using the backplane, but with this change, we introduce a frame around the content window that can be dragged. This change also fixes the positioning of the fullscreen toast and the close button so that they adapt to a resized window. It also removes some now-useless code for setting the center position of a gradient quad and fixes a bug in the "bounds contain children" code where we weren't updating positioning correctly for children with asymmetric padding. Bug: 799270 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ia6d9759b3e8b6fc80bc0d1ae2f0c739cc9cd0f7f Reviewed-on: https://chromium-review.googlesource.com/967350 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#544061} [modify] https://crrev.com/af05373481b3e4a0ec4e72e4faab88dbd5d97c87/chrome/browser/vr/elements/full_screen_rect.cc [modify] https://crrev.com/af05373481b3e4a0ec4e72e4faab88dbd5d97c87/chrome/browser/vr/elements/rect.cc [modify] https://crrev.com/af05373481b3e4a0ec4e72e4faab88dbd5d97c87/chrome/browser/vr/elements/rect.h [modify] https://crrev.com/af05373481b3e4a0ec4e72e4faab88dbd5d97c87/chrome/browser/vr/elements/resizer.cc [modify] https://crrev.com/af05373481b3e4a0ec4e72e4faab88dbd5d97c87/chrome/browser/vr/elements/resizer.h [modify] https://crrev.com/af05373481b3e4a0ec4e72e4faab88dbd5d97c87/chrome/browser/vr/elements/shadow.cc [modify] https://crrev.com/af05373481b3e4a0ec4e72e4faab88dbd5d97c87/chrome/browser/vr/elements/ui_element.cc [modify] https://crrev.com/af05373481b3e4a0ec4e72e4faab88dbd5d97c87/chrome/browser/vr/elements/ui_element.h [modify] https://crrev.com/af05373481b3e4a0ec4e72e4faab88dbd5d97c87/chrome/browser/vr/elements/ui_element_name.cc [modify] https://crrev.com/af05373481b3e4a0ec4e72e4faab88dbd5d97c87/chrome/browser/vr/elements/ui_element_name.h [modify] https://crrev.com/af05373481b3e4a0ec4e72e4faab88dbd5d97c87/chrome/browser/vr/elements/ui_element_unittest.cc [modify] https://crrev.com/af05373481b3e4a0ec4e72e4faab88dbd5d97c87/chrome/browser/vr/model/color_scheme.cc [modify] https://crrev.com/af05373481b3e4a0ec4e72e4faab88dbd5d97c87/chrome/browser/vr/model/color_scheme.h [modify] https://crrev.com/af05373481b3e4a0ec4e72e4faab88dbd5d97c87/chrome/browser/vr/renderers/gradient_quad_renderer.cc [modify] https://crrev.com/af05373481b3e4a0ec4e72e4faab88dbd5d97c87/chrome/browser/vr/renderers/gradient_quad_renderer.h [modify] https://crrev.com/af05373481b3e4a0ec4e72e4faab88dbd5d97c87/chrome/browser/vr/target_property.h [modify] https://crrev.com/af05373481b3e4a0ec4e72e4faab88dbd5d97c87/chrome/browser/vr/test/fake_ui_element_renderer.cc [modify] https://crrev.com/af05373481b3e4a0ec4e72e4faab88dbd5d97c87/chrome/browser/vr/test/fake_ui_element_renderer.h [modify] https://crrev.com/af05373481b3e4a0ec4e72e4faab88dbd5d97c87/chrome/browser/vr/ui_element_renderer.cc [modify] https://crrev.com/af05373481b3e4a0ec4e72e4faab88dbd5d97c87/chrome/browser/vr/ui_element_renderer.h [modify] https://crrev.com/af05373481b3e4a0ec4e72e4faab88dbd5d97c87/chrome/browser/vr/ui_scene_constants.h [modify] https://crrev.com/af05373481b3e4a0ec4e72e4faab88dbd5d97c87/chrome/browser/vr/ui_scene_creator.cc [modify] https://crrev.com/af05373481b3e4a0ec4e72e4faab88dbd5d97c87/chrome/browser/vr/ui_unittest.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/73a7e13d9d1e62fb0760860b4ec816d8b19052f1 commit 73a7e13d9d1e62fb0760860b4ec816d8b19052f1 Author: Ian Vollick <vollick@chromium.org> Date: Tue Mar 20 02:01:54 2018 [vr] Fix reposition cursor legibility This CL changes the reposition icon, its size, and the color of the shadow. Bug: 799270 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I5b4700c80e8731e17627ff3a35aab54b5e74bb40 Reviewed-on: https://chromium-review.googlesource.com/969614 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#544259} [modify] https://crrev.com/73a7e13d9d1e62fb0760860b4ec816d8b19052f1/chrome/browser/vr/model/color_scheme.cc [modify] https://crrev.com/73a7e13d9d1e62fb0760860b4ec816d8b19052f1/chrome/browser/vr/ui_scene_constants.h [modify] https://crrev.com/73a7e13d9d1e62fb0760860b4ec816d8b19052f1/chrome/browser/vr/vector_icons/reposition.icon
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8ab5c23c75307c409262bed91529870a59be73e commit e8ab5c23c75307c409262bed91529870a59be73e Author: Ian Vollick <vollick@chromium.org> Date: Tue Mar 20 17:38:41 2018 [vr] Fix reticle roll Since the reticle had been circular, there was no need to correct the roll, but now we have cursors that must be oriented correctly. Bug: 799270 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I9f375142967ebbc1b3732ee402be4f791e8d6d85 Reviewed-on: https://chromium-review.googlesource.com/971062 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#544426} [modify] https://crrev.com/e8ab5c23c75307c409262bed91529870a59be73e/chrome/browser/vr/elements/reticle.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/faa8271b923f3de41f49f6f472abf49247a07d47 commit faa8271b923f3de41f49f6f472abf49247a07d47 Author: Ian Vollick <vollick@chromium.org> Date: Tue Mar 20 18:48:07 2018 [vr] Combine overlay and content texture in a single quad The content and its overlay had been previously been drawn into two, separate quads. The result was that when the opacity of the content quad was reduced, you could "see through" an opaque overlay. This could cause "ghosting" of a bogus content texture that should have been hidden. The solution in this CL is to composite the textures together before applying the opacity. Bug: 799270 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I2df1382a2acc5e20cb115ff7b8cde5460e1db388 Reviewed-on: https://chromium-review.googlesource.com/971204 Reviewed-by: Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Ian Vollick <vollick@chromium.org> Cr-Commit-Position: refs/heads/master@{#544452} [modify] https://crrev.com/faa8271b923f3de41f49f6f472abf49247a07d47/chrome/browser/vr/elements/content_element.cc [modify] https://crrev.com/faa8271b923f3de41f49f6f472abf49247a07d47/chrome/browser/vr/elements/textured_element.cc [modify] https://crrev.com/faa8271b923f3de41f49f6f472abf49247a07d47/chrome/browser/vr/renderers/external_textured_quad_renderer.cc [modify] https://crrev.com/faa8271b923f3de41f49f6f472abf49247a07d47/chrome/browser/vr/renderers/textured_quad_renderer.cc [modify] https://crrev.com/faa8271b923f3de41f49f6f472abf49247a07d47/chrome/browser/vr/renderers/textured_quad_renderer.h [modify] https://crrev.com/faa8271b923f3de41f49f6f472abf49247a07d47/chrome/browser/vr/test/fake_ui_element_renderer.cc [modify] https://crrev.com/faa8271b923f3de41f49f6f472abf49247a07d47/chrome/browser/vr/test/fake_ui_element_renderer.h [modify] https://crrev.com/faa8271b923f3de41f49f6f472abf49247a07d47/chrome/browser/vr/testapp/test_keyboard_renderer.cc [modify] https://crrev.com/faa8271b923f3de41f49f6f472abf49247a07d47/chrome/browser/vr/ui.cc [modify] https://crrev.com/faa8271b923f3de41f49f6f472abf49247a07d47/chrome/browser/vr/ui_element_renderer.cc [modify] https://crrev.com/faa8271b923f3de41f49f6f472abf49247a07d47/chrome/browser/vr/ui_element_renderer.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7e81ef70bfea65dad7c300fe73102e9a887a3cb1 commit 7e81ef70bfea65dad7c300fe73102e9a887a3cb1 Author: Ian Vollick <vollick@chromium.org> Date: Wed Mar 21 15:57:43 2018 [vr] Repositioning tweaks This changes the direction you need to scroll to increase the size of the content window to match the spec. It also adds sounds for repositioning (and introduces a struct ot hang onto a bunch of sounds). Bug: 799270 Cq-Include-Trybots: luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Ifa538a70575e8c508db07d9d12d588e3ecbabc6e Reviewed-on: https://chromium-review.googlesource.com/973263 Commit-Queue: Ian Vollick <vollick@chromium.org> Reviewed-by: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#544719} [modify] https://crrev.com/7e81ef70bfea65dad7c300fe73102e9a887a3cb1/chrome/browser/vr/elements/disc_button.cc [modify] https://crrev.com/7e81ef70bfea65dad7c300fe73102e9a887a3cb1/chrome/browser/vr/elements/resizer.cc [modify] https://crrev.com/7e81ef70bfea65dad7c300fe73102e9a887a3cb1/chrome/browser/vr/elements/resizer_unittest.cc [modify] https://crrev.com/7e81ef70bfea65dad7c300fe73102e9a887a3cb1/chrome/browser/vr/elements/ui_element.cc [modify] https://crrev.com/7e81ef70bfea65dad7c300fe73102e9a887a3cb1/chrome/browser/vr/elements/ui_element.h [add] https://crrev.com/7e81ef70bfea65dad7c300fe73102e9a887a3cb1/chrome/browser/vr/model/sounds.h [modify] https://crrev.com/7e81ef70bfea65dad7c300fe73102e9a887a3cb1/chrome/browser/vr/ui_scene_creator.cc
Comment 1 by bugdroid1@chromium.org
, Jan 6 2018