New issue
Advanced search Search tips

Issue 799265 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Feature



Sign in to add a comment

[Media Router UI] Show both domain and page title in dialog details view for wired display presentations

Project Member Reported by taku...@chromium.org, Jan 4 2018

Issue description

The details view should show both the presentation page title and the origin ("Presenting: example.com"). For this we need to make WiredDisplayMediaRouteProvider provide route controllers to push media title status updates.
 
Labels: Hotlist-LocalScreenCasting
Components: Internals>Cast>Providers
Project Member

Comment 3 by bugdroid1@chromium.org, Feb 14 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1acd95409a06dff9ecff29e2af46c81981249ca1

commit 1acd95409a06dff9ecff29e2af46c81981249ca1
Author: Takumi Fujimoto <takumif@chromium.org>
Date: Wed Feb 14 07:44:38 2018

[Local Screen Casting] Show page origin in route details view

This change adds the presentation page origin (www.example.com) to the
route details view for local screen casting. The details view also
shows the page title.

Screenshot:
https://drive.google.com/open?id=1linGuorVH62K9bx83iXTWHBJ8EbEmLRH

Bug:  799265 
Change-Id: Ieaeb5feab2b429e9e643df0449b5ee9b082e2512
Reviewed-on: https://chromium-review.googlesource.com/910031
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536669}
[modify] https://crrev.com/1acd95409a06dff9ecff29e2af46c81981249ca1/chrome/app/media_router_strings.grdp
[modify] https://crrev.com/1acd95409a06dff9ecff29e2af46c81981249ca1/chrome/browser/media/router/providers/wired_display/wired_display_media_route_provider.cc
[modify] https://crrev.com/1acd95409a06dff9ecff29e2af46c81981249ca1/chrome/browser/media/router/providers/wired_display/wired_display_media_route_provider.h
[modify] https://crrev.com/1acd95409a06dff9ecff29e2af46c81981249ca1/chrome/browser/media/router/providers/wired_display/wired_display_media_route_provider_unittest.cc
[modify] https://crrev.com/1acd95409a06dff9ecff29e2af46c81981249ca1/chrome/browser/media/router/test/media_router_mojo_test.cc
[modify] https://crrev.com/1acd95409a06dff9ecff29e2af46c81981249ca1/chrome/browser/media/router/test/media_router_mojo_test.h

Status: Fixed (was: Assigned)

Sign in to add a comment