mac_views_browser build regression |
|||
Issue descriptionChrome Version : 65.0.33ish Good: https://uberchromegw.corp.google.com/i/chromium.fyi/builders/Chromium%20Mac%2010.10%20MacViews/builds/28151 Bad: https://uberchromegw.corp.google.com/i/chromium.fyi/builders/Chromium%20Mac%2010.10%20MacViews/builds/28152 failing in generate_build_files /b/c/builder/mac/src/buildtools/mac/gn gen //out/Release --check -> returned 1 ERROR at //chrome/browser/ui/cocoa/test/cocoa_test_helper.h:10:10: Can't include this header from here. #import "ui/base/test/cocoa_helper.h" ^-------------------------- The target: //chrome/browser/ui:test_support is including a file from the target: //ui/base:test_support Probably ui/gfx/test/ui_cocoa_test_helper.h → ui/base/test/cocoa_helper.h This didn't need to be in gfx/ and moving it gives it slightly more appropriate OWNERS. Bug: Change-Id: Iaa670a82d8d7c9906b723e8056e8d14f195cf338 Reviewed-on: https://chromium-review.googlesource.com/840643 Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#525865}
,
Jan 8 2018
[Mac triage]
,
Jan 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bde7c60e1721ba1aa3749404b750ff7c39aa108a commit bde7c60e1721ba1aa3749404b750ff7c39aa108a Author: Sidney San Martín <sdy@chromium.org> Date: Wed Jan 10 23:24:45 2018 Fix a MacViews gn error by explicitly depending on //ui/base:test_support. Bug: 799260 Change-Id: I8e33c23a69dcd464a3852bad8b69ed197e02effd Reviewed-on: https://chromium-review.googlesource.com/860477 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#528473} [modify] https://crrev.com/bde7c60e1721ba1aa3749404b750ff7c39aa108a/chrome/browser/ui/BUILD.gn
,
Jan 11 2018
Is this fixed now?
,
Jan 12 2018
There's now a link error at go/macviewsbuilder FAILED: browser_tests Undefined symbols for architecture x86_64: "SessionCrashedInfoBarDelegate::Create(Browser*)", referenced from: InfoBarUiTest::ShowUi(std::__1::basic_string<char, std::__1::char_traits<char>, std::__1::allocator<char> > const&) in infobars_browsertest.o ld: symbol(s) not found for architecture x86_64 maybe r527152 or r524855 I'll try to fix today so we have a good log of builds to pinpoint regressions.
,
Jan 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ff0f97aa07d4ca929ca2cc22f30bce4e5541c084 commit ff0f97aa07d4ca929ca2cc22f30bce4e5541c084 Author: Trent Apted <tapted@chromium.org> Date: Mon Jan 22 04:17:44 2018 Fix browser_tests linking under mac_views_browser build mac_views_browser doesn't use SessionCrashedInfoBarDelegate, but a bubble instead. Update the browsertest to guard the call to Create() similar to StartupBrowserCreatorImpl:: AddInfoBarsIfNecessary(). TBR=pkasting@chromium.org Bug: 799260 Change-Id: I8bb3536fe9cac0b483a9a65182fc6c8744fa18fb Reviewed-on: https://chromium-review.googlesource.com/877680 Reviewed-by: Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#530807} [modify] https://crrev.com/ff0f97aa07d4ca929ca2cc22f30bce4e5541c084/chrome/browser/infobars/infobars_browsertest.cc
,
Jan 22 2018
,
Jan 22 2018
|
|||
►
Sign in to add a comment |
|||
Comment 1 by sdy@chromium.org
, Jan 8 2018Components: Build
Owner: sdy@chromium.org
Status: Assigned (was: Unconfirmed)