New issue
Advanced search Search tips

Issue 799244 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR
Proj-XR-VR

Blocking:
issue 799216



Sign in to add a comment

VR omnibox: Cancelling voice input should preserve any previously-entered omnibox text

Project Member Reported by cjgrant@chromium.org, Jan 4 2018

Issue description

As per the omnibox PRD, if the user types text into the omnibox, triggers voice, but then cancels voice, the originally-typed text should still be present.

Currently, triggering and cancelling voice clears input text.
 
Blocking: 799216
Owner: cjgrant@chromium.org
Reclaiming
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 9 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/331a3ec24339b1d06ba82fd9e3ca0f07b49ddd8e

commit 331a3ec24339b1d06ba82fd9e3ca0f07b49ddd8e
Author: Christopher Grant <cjgrant@chromium.org>
Date: Tue Jan 09 23:14:28 2018

VR: Preserve omnibox text through a failed voice search attempt

When voice input is triggered via omnibox, an unsuccessful voice search should
land the user back at the omnibox with any previously typed text still present.
This change moves the omnibox-clearing action from "when the omnibox changes
visibility" to "when the omnibox is in the mode stack".  This way, even when
omnibox is hidden by voice input, it's still considered to be active, and the
field isn't cleared.

Similarly, also leave the autocomplete controller running if we enter
voice mode, rather than restarting it when we leave voice mode.

BUG= 799244 
R=ymalik

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: If29729867ad0810be92f9b7b089cfeab17cf1f12
Reviewed-on: https://chromium-review.googlesource.com/857543
Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528158}
[modify] https://crrev.com/331a3ec24339b1d06ba82fd9e3ca0f07b49ddd8e/chrome/browser/vr/model/model.cc
[modify] https://crrev.com/331a3ec24339b1d06ba82fd9e3ca0f07b49ddd8e/chrome/browser/vr/model/model.h
[modify] https://crrev.com/331a3ec24339b1d06ba82fd9e3ca0f07b49ddd8e/chrome/browser/vr/ui_scene_creator.cc

Status: Fixed (was: Assigned)
Labels: Test-Manual
Labels: Test-Manual
Labels: M-65
Labels: -Test-Manual Test-Complete
Status: Verified (was: Fixed)
Fix verified in M66 Canary build.
Covered by testcase "Exit Voice input by clicking close button or controller app button returns back to text entry mode." in the "VR Browsing: Omnibox text entry manual test plan"

Sign in to add a comment