Merge Mojo unit test suites |
|||||
Issue descriptionWe have two mojo test binaries for public API tests: mojo_public_bindings_unittests mojo_public_system_unittests I'm looking to add another public API component (base, for common base type helpers), and I don't want to introduce a third test binary. I think it makes sense to just merge it all into a unified mojo_public_unittests.
,
Feb 13 2018
Just to persist what I wrote in the doc and correct my original report, I now think we should also merge mojo_system_unittests into the same suite and just call it mojo_unittests
,
Feb 14 2018
,
Feb 15 2018
Copied issue chromium:799242 to issue chromium:812773
,
Feb 15 2018
,
Feb 15 2018
,
Feb 16 2018
Copied issue chromium:799242 to issue chromium:813209
,
Feb 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1792d19f00263b0fc8a8378dbb280aadc0a27c2a commit 1792d19f00263b0fc8a8378dbb280aadc0a27c2a Author: Oksana Zhuravlova <oksamyt@chromium.org> Date: Thu Feb 22 19:13:31 2018 Combined several mojo unit test binaries into one mojo_unittests mojo_unittests includes tests from mojo_public_bindings_unittests, mojo_public_system_unittests and mojo_system_unittests. Relevant infrastructure files were updated. - added a new target in mojo/BUILD.gn and included existing tests as dependencies, removed unused public_tests group; - replaced mojo_system_unittests target with a source_set in mojo/edk/system/BUILD.gn and removed unused tests group; - added the new binary to top-level and mojo build files; - updated some comments to reference mojo_unittests instead of mojo_system_unittests; - renamed //mojo/public/c/system/tests/core_unittest.cc to core_api_unittest.cc and updated the tests in it to resolve test name collision with the ones in //mojo/edk/system/core_unittest.cc; - added new entries to buildbot configuration files (including test_suite_exceptions.pyl) and a new filter file. - removed references to old binaries from build and testing config files master.tryserver.chromium.android:android_optional_gpu_tests_rel;master. tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver. chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win: win_optional_gpu_tests_rel Bug: 799242 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I400e88606ffde0547faffb115b804a6786b52fb2 Reviewed-on: https://chromium-review.googlesource.com/919364 Commit-Queue: Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by: Scott Violet <sky@chromium.org> Reviewed-by: Ken Rockot <rockot@chromium.org> Cr-Commit-Position: refs/heads/master@{#538514} [modify] https://crrev.com/1792d19f00263b0fc8a8378dbb280aadc0a27c2a/BUILD.gn [modify] https://crrev.com/1792d19f00263b0fc8a8378dbb280aadc0a27c2a/build/android/pylib/gtest/gtest_test_instance.py [modify] https://crrev.com/1792d19f00263b0fc8a8378dbb280aadc0a27c2a/content/test/gpu/generate_buildbot_json.py [modify] https://crrev.com/1792d19f00263b0fc8a8378dbb280aadc0a27c2a/mojo/BUILD.gn [modify] https://crrev.com/1792d19f00263b0fc8a8378dbb280aadc0a27c2a/mojo/edk/embedder/BUILD.gn [modify] https://crrev.com/1792d19f00263b0fc8a8378dbb280aadc0a27c2a/mojo/edk/embedder/README.md [modify] https://crrev.com/1792d19f00263b0fc8a8378dbb280aadc0a27c2a/mojo/edk/system/BUILD.gn [modify] https://crrev.com/1792d19f00263b0fc8a8378dbb280aadc0a27c2a/mojo/edk/test/BUILD.gn [modify] https://crrev.com/1792d19f00263b0fc8a8378dbb280aadc0a27c2a/mojo/public/c/system/tests/BUILD.gn [rename] https://crrev.com/1792d19f00263b0fc8a8378dbb280aadc0a27c2a/mojo/public/c/system/tests/core_api_unittest.cc [modify] https://crrev.com/1792d19f00263b0fc8a8378dbb280aadc0a27c2a/testing/buildbot/chromium.android.fyi.json [modify] https://crrev.com/1792d19f00263b0fc8a8378dbb280aadc0a27c2a/testing/buildbot/chromium.android.json [modify] https://crrev.com/1792d19f00263b0fc8a8378dbb280aadc0a27c2a/testing/buildbot/chromium.clang.json [modify] https://crrev.com/1792d19f00263b0fc8a8378dbb280aadc0a27c2a/testing/buildbot/chromium.fyi.json [modify] https://crrev.com/1792d19f00263b0fc8a8378dbb280aadc0a27c2a/testing/buildbot/chromium.linux.json [modify] https://crrev.com/1792d19f00263b0fc8a8378dbb280aadc0a27c2a/testing/buildbot/chromium.mac.json [modify] https://crrev.com/1792d19f00263b0fc8a8378dbb280aadc0a27c2a/testing/buildbot/chromium.memory.json [modify] https://crrev.com/1792d19f00263b0fc8a8378dbb280aadc0a27c2a/testing/buildbot/chromium.sandbox.json [modify] https://crrev.com/1792d19f00263b0fc8a8378dbb280aadc0a27c2a/testing/buildbot/chromium.win.json [modify] https://crrev.com/1792d19f00263b0fc8a8378dbb280aadc0a27c2a/testing/buildbot/client.v8.fyi.json [modify] https://crrev.com/1792d19f00263b0fc8a8378dbb280aadc0a27c2a/testing/buildbot/filters/BUILD.gn [add] https://crrev.com/1792d19f00263b0fc8a8378dbb280aadc0a27c2a/testing/buildbot/filters/fuchsia.mojo_unittests.filter [modify] https://crrev.com/1792d19f00263b0fc8a8378dbb280aadc0a27c2a/testing/buildbot/gn_isolate_map.pyl [modify] https://crrev.com/1792d19f00263b0fc8a8378dbb280aadc0a27c2a/testing/buildbot/test_suite_exceptions.pyl [modify] https://crrev.com/1792d19f00263b0fc8a8378dbb280aadc0a27c2a/testing/buildbot/test_suites.pyl [modify] https://crrev.com/1792d19f00263b0fc8a8378dbb280aadc0a27c2a/tools/determinism/deterministic_build_whitelist.pyl
,
Feb 22 2018
,
Feb 23 2018
Note: according to Dirk Pranke and Patrik Höglund, the references to mojo_*tests in //third_party/*/valgrind... do not need to be updated because those tests and not supported and will be deleted. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by oksamyt@chromium.org
, Feb 13 2018