New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 799230 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 81712
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Feature



Sign in to add a comment

Mac: Switch tabs on mouse down for speed and consistency with other Chrome platforms

Project Member Reported by sdy@chromium.org, Jan 4 2018

Issue description

Chrome Version: 65.0.3311.0
OS: macOS

The tab strip waits until mouse up to switch tabs but, as far as I can tell, there are no actions the user can take (other than pressing "esc") which don't result in the clicked tab becoming active.

On Views platforms, the active tab changes on mouse down, which may make the tab strip feel more responsive.
 

Comment 1 by sdy@chromium.org, Jan 4 2018

Cc: shrike@chromium.org
shrike@: Does this sound legit to you?

Comment 2 by sdy@chromium.org, Jan 29 2018

Labels: Hotlist-PlatformExcellence
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 31 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a47974deb41061714d3390b7373c174b750edd11

commit a47974deb41061714d3390b7373c174b750edd11
Author: Sidney San Martín <sdy@chromium.org>
Date: Wed Jan 31 20:03:56 2018

Switch tabs on mouse down instead of mouse up.

This is consistent with other Mac apps and with Views, and makes the tab
strip feel more responsive.

Bug:  799230 
Change-Id: I45a375f5892c10e5886e18f27ba049eb6215a17f
Reviewed-on: https://chromium-review.googlesource.com/895925
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#533373}
[modify] https://crrev.com/a47974deb41061714d3390b7373c174b750edd11/chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm

Comment 4 by sdy@chromium.org, Jan 31 2018

Status: Fixed (was: Assigned)

Comment 5 by sdy@chromium.org, Jan 31 2018

Mergedinto: 81712
Status: Duplicate (was: Fixed)
Labels: TE-Verified-M66 TE-Verified-66.0.3336.0
Verified the fix on Mac 10.12.6 using latest chrome version #66.0.3336.0 as per the merged  issue 81712 .
Attaching screen cast for reference.
Observed that tab came to the foreground first and dragged also in the foreground to the left or right side within the tabstrip as expected.
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!
799230.mp4
2.5 MB View Download

Comment 7 by sdy@chromium.org, Feb 1 2018

Thanks for verifying, krajshree@!
Project Member

Comment 8 by bugdroid1@chromium.org, Mar 7 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a58fea8dff2faf5a465fea718a31ebbd58f499ab

commit a58fea8dff2faf5a465fea718a31ebbd58f499ab
Author: Sidney San Martín <sdy@chromium.org>
Date: Wed Mar 07 21:49:39 2018

Revert "Switch tabs on mouse down instead of mouse up."

This reverts commit a47974deb41061714d3390b7373c174b750edd11.

Reason for revert:  https://crbug.com/819339 

This breaks the flow of:

1. Click a tab.
2. Shift-click to select a range of tabs.
3. Release shift and drag the tabs out into a new window.

…because the ListSelectionModel which backs the tab strip clears the selection when the active item is changed. It's going to take some work to make it behave the right way.

Original change's description:
> Switch tabs on mouse down instead of mouse up.
>
> This is consistent with other Mac apps and with Views, and makes the tab
> strip feel more responsive.
>
> Bug:  799230 
> Change-Id: I45a375f5892c10e5886e18f27ba049eb6215a17f
> Reviewed-on: https://chromium-review.googlesource.com/895925
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Commit-Queue: Sidney San Martín <sdy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#533373}

TBR=ellyjones@chromium.org,sdy@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  819339 ,  799230 
Change-Id: I9921e0d41669d6783ff0f8f3f0d4b0746eb72b68
Reviewed-on: https://chromium-review.googlesource.com/953304
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#541597}
[modify] https://crrev.com/a58fea8dff2faf5a465fea718a31ebbd58f499ab/chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm

Labels: TE-Verified-M67 TE-Verified-67.0.3365.0
Able to reproduce the issue having issue id: 819339 using chrome reported version #66.0.3355.0.
Verified the fix at comment #8 for issue id: 819339 as per comment #0 on Mac 10.13.3 using latest chrome version #67.0.3365.0.
Attaching screen cast for reference.
Observed that all selected tabs are dragged into a new window after releasing "command" button as expected.
Hence, the fix is working as expected. 
Adding the verified labels.

Thanks...!!
819339.mp4
2.1 MB View Download
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 9 2018

Labels: merge-merged-3359
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8b7bed18c8c076a6548fc1502567e7b8857be1a1

commit 8b7bed18c8c076a6548fc1502567e7b8857be1a1
Author: Sidney San Martín <sdy@chromium.org>
Date: Fri Mar 09 18:55:47 2018

Revert "Switch tabs on mouse down instead of mouse up."

This reverts commit a47974deb41061714d3390b7373c174b750edd11.

Reason for revert:  https://crbug.com/819339 

This breaks the flow of:

1. Click a tab.
2. Shift-click to select a range of tabs.
3. Release shift and drag the tabs out into a new window.

…because the ListSelectionModel which backs the tab strip clears the selection when the active item is changed. It's going to take some work to make it behave the right way.

Original change's description:
> Switch tabs on mouse down instead of mouse up.
>
> This is consistent with other Mac apps and with Views, and makes the tab
> strip feel more responsive.
>
> Bug:  799230 
> Change-Id: I45a375f5892c10e5886e18f27ba049eb6215a17f
> Reviewed-on: https://chromium-review.googlesource.com/895925
> Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
> Commit-Queue: Sidney San Martín <sdy@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#533373}

TBR=ellyjones@chromium.org,sdy@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  819339 ,  799230 
Change-Id: I9921e0d41669d6783ff0f8f3f0d4b0746eb72b68
Reviewed-on: https://chromium-review.googlesource.com/953304
Commit-Queue: Sidney San Martín <sdy@chromium.org>
Reviewed-by: Sidney San Martín <sdy@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#541597}(cherry picked from commit a58fea8dff2faf5a465fea718a31ebbd58f499ab)
Reviewed-on: https://chromium-review.googlesource.com/957323
Cr-Commit-Position: refs/branch-heads/3359@{#134}
Cr-Branched-From: 66afc5e5d10127546cc4b98b9117aff588b5e66b-refs/heads/master@{#540276}
[modify] https://crrev.com/8b7bed18c8c076a6548fc1502567e7b8857be1a1/chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm

Tested the issue on Mac 10.12.6 using latest chrome version #67.0.3368.0 as per the merged  issue 81712 .
Observed that due to the revert of CL at comment #10, the issue is again observed i.e tab is dragged in the background and after releasing the mousebutton the tab comes to the foreground.

Thanks...!!

Sign in to add a comment