local_device_instrumentation_test_run.py should not require package_info to enable debugging |
|
Issue descriptionCurrently local_device_instrumentation_test_run.py fails to enable debugging or waiting for a debugger if no package_info for the apk is available. However the only thing that is required is the package name which is available elsewhere (under apk_under_test.GetPackageName())
,
Jan 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e7d29252dda05fead8340e77d4b91c5a69abdbe0 commit e7d29252dda05fead8340e77d4b91c5a69abdbe0 Author: Mohamed Heikal <mheikal@google.com> Date: Thu Jan 18 21:33:47 2018 Test Runner: Instrumentation tests no longer require package_info to enable debugging This change makes local_device_instrumentation_test_run.py read the package name from the _test_instance.apk_under_test.GetPackageName() rather than from the _test_instance.package_info.package which may not be available. Bug: 799228 Change-Id: I3cff31d4e9888597719a5be629cd4480e6a58e1d Reviewed-on: https://chromium-review.googlesource.com/850816 Reviewed-by: John Budorick <jbudorick@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#530279} [modify] https://crrev.com/e7d29252dda05fead8340e77d4b91c5a69abdbe0/build/android/pylib/local/device/local_device_instrumentation_test_run.py |
|
►
Sign in to add a comment |
|
Comment 1 by mheikal@chromium.org
, Jan 18 2018