New issue
Advanced search Search tips

Issue 799225 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 772407



Sign in to add a comment

Web Animations: Implement KeyframeEffect{ReadOnly} copy constructors

Project Member Reported by smcgruer@chromium.org, Jan 4 2018

Issue description

This is a tracking bug for implementing KeyframeEffect{ReadOnly} copy constructors. These current account for 7 known WPT test failures.
 
Blocking: 772407
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 15 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0cd4c1a05a431022f5ecc9ec29d505b5c216caf

commit a0cd4c1a05a431022f5ecc9ec29d505b5c216caf
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Mon Jan 15 21:40:40 2018

Implement KeyframeEffect{ReadOnly} copy constructors

Bug:  799225 
Change-Id: I37d97652352ff8884503713844f769e4877a2b5b
Reviewed-on: https://chromium-review.googlesource.com/850744
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Reviewed-by: Xida Chen <xidachen@chromium.org>
Reviewed-by: Robert Flack <flackr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529331}
[delete] https://crrev.com/2395de65c82b1d877b9e6530768dd5a33ba1177c/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/copy-constructor-expected.txt
[modify] https://crrev.com/a0cd4c1a05a431022f5ecc9ec29d505b5c216caf/third_party/WebKit/LayoutTests/external/wpt/web-animations/interfaces/KeyframeEffect/idlharness-expected.txt
[modify] https://crrev.com/a0cd4c1a05a431022f5ecc9ec29d505b5c216caf/third_party/WebKit/Source/core/animation/AnimationEffectReadOnly.h
[modify] https://crrev.com/a0cd4c1a05a431022f5ecc9ec29d505b5c216caf/third_party/WebKit/Source/core/animation/KeyframeEffect.cpp
[modify] https://crrev.com/a0cd4c1a05a431022f5ecc9ec29d505b5c216caf/third_party/WebKit/Source/core/animation/KeyframeEffect.h
[modify] https://crrev.com/a0cd4c1a05a431022f5ecc9ec29d505b5c216caf/third_party/WebKit/Source/core/animation/KeyframeEffect.idl
[modify] https://crrev.com/a0cd4c1a05a431022f5ecc9ec29d505b5c216caf/third_party/WebKit/Source/core/animation/KeyframeEffectModel.h
[modify] https://crrev.com/a0cd4c1a05a431022f5ecc9ec29d505b5c216caf/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.cpp
[modify] https://crrev.com/a0cd4c1a05a431022f5ecc9ec29d505b5c216caf/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.h
[modify] https://crrev.com/a0cd4c1a05a431022f5ecc9ec29d505b5c216caf/third_party/WebKit/Source/core/animation/KeyframeEffectReadOnly.idl

Status: Fixed (was: Started)

Sign in to add a comment