New issue
Advanced search Search tips

Issue 799201 link

Starred by 2 users
Status: Verified
Owner:
cjgrant@chromium.org
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR omnibox: Support autocomplete in-line match

Project Member Reported by cjgrant@chromium.org, Jan 4 2018 
In the omnibox design doc, mpearson@ pointed out that we may need to retool autocomplete matching around our lack of in-line match support.

This bug tracks:

- Obtaining full understanding out how the in-line match is handled in Clank
- Determining when (if ever) we'll support in-line match
- Making necessary code changes (possibly external to VR)

Comment 1 by cjgrant@chromium.org, Jan 4 2018

Summary: VR omnibox: Support autocomplete in-line match (was: VR omnibox: Adapt autocomplete mechanism to account for lack of in-line match)

Comment 2 by cjgrant@chromium.org, Jan 4 2018 

Update:  In early omnibox UX discussion, in-line match was seen as a power-user physical keyboard feature, and hence left as a nice-to-have but out-of-scope feature.  This thinking has changed, and we'd now like to offer in-line match as Clank does.

This will negate the need for any Autocomplete rework to make the "no in-line match" case work better, and we can focus on actually supporting the real deal.

Comment 3 by cjgrant@chromium.org, Jan 24 2018

Labels: M-66
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 2 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8829d676d1e60f78ca54582b38fb5c53ecdbd191

commit 8829d676d1e60f78ca54582b38fb5c53ecdbd191
Author: Christopher Grant <cjgrant@chromium.org>
Date: Fri Feb 02 22:55:37 2018

VR: Groundwork for inline autocompletion

- Plumb more Autocomplete request information out of the UI
- Include input and autocompletion text in suggestions
- Augment Text/TextInput to display a selection, if specified
- Add selection colors to the colorscheme
- Make the testapp's fake keyboard act much more like a keyboard

BUG= 799201 
R=vollick, ymalik

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I6371875a93149496aee4ac80f9fad3b78ebed245
Reviewed-on: https://chromium-review.googlesource.com/899905
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534184}
[modify] https://crrev.com/8829d676d1e60f78ca54582b38fb5c53ecdbd191/chrome/browser/android/vr_shell/autocomplete_controller.cc
[modify] https://crrev.com/8829d676d1e60f78ca54582b38fb5c53ecdbd191/chrome/browser/android/vr_shell/autocomplete_controller.h
[modify] https://crrev.com/8829d676d1e60f78ca54582b38fb5c53ecdbd191/chrome/browser/android/vr_shell/vr_gl_thread.cc
[modify] https://crrev.com/8829d676d1e60f78ca54582b38fb5c53ecdbd191/chrome/browser/android/vr_shell/vr_gl_thread.h
[modify] https://crrev.com/8829d676d1e60f78ca54582b38fb5c53ecdbd191/chrome/browser/android/vr_shell/vr_shell.cc
[modify] https://crrev.com/8829d676d1e60f78ca54582b38fb5c53ecdbd191/chrome/browser/android/vr_shell/vr_shell.h
[modify] https://crrev.com/8829d676d1e60f78ca54582b38fb5c53ecdbd191/chrome/browser/vr/elements/text.cc
[modify] https://crrev.com/8829d676d1e60f78ca54582b38fb5c53ecdbd191/chrome/browser/vr/elements/text.h
[modify] https://crrev.com/8829d676d1e60f78ca54582b38fb5c53ecdbd191/chrome/browser/vr/elements/text_input.cc
[modify] https://crrev.com/8829d676d1e60f78ca54582b38fb5c53ecdbd191/chrome/browser/vr/elements/text_input.h
[modify] https://crrev.com/8829d676d1e60f78ca54582b38fb5c53ecdbd191/chrome/browser/vr/model/color_scheme.cc
[modify] https://crrev.com/8829d676d1e60f78ca54582b38fb5c53ecdbd191/chrome/browser/vr/model/color_scheme.h
[modify] https://crrev.com/8829d676d1e60f78ca54582b38fb5c53ecdbd191/chrome/browser/vr/model/omnibox_suggestions.cc
[modify] https://crrev.com/8829d676d1e60f78ca54582b38fb5c53ecdbd191/chrome/browser/vr/model/omnibox_suggestions.h
[modify] https://crrev.com/8829d676d1e60f78ca54582b38fb5c53ecdbd191/chrome/browser/vr/model/text_input_info.cc
[modify] https://crrev.com/8829d676d1e60f78ca54582b38fb5c53ecdbd191/chrome/browser/vr/model/text_input_info.h
[modify] https://crrev.com/8829d676d1e60f78ca54582b38fb5c53ecdbd191/chrome/browser/vr/test/mock_ui_browser_interface.h
[modify] https://crrev.com/8829d676d1e60f78ca54582b38fb5c53ecdbd191/chrome/browser/vr/testapp/test_keyboard_delegate.cc
[modify] https://crrev.com/8829d676d1e60f78ca54582b38fb5c53ecdbd191/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/8829d676d1e60f78ca54582b38fb5c53ecdbd191/chrome/browser/vr/testapp/vr_test_context.h
[modify] https://crrev.com/8829d676d1e60f78ca54582b38fb5c53ecdbd191/chrome/browser/vr/text_input_unittest.cc
[modify] https://crrev.com/8829d676d1e60f78ca54582b38fb5c53ecdbd191/chrome/browser/vr/ui_browser_interface.h
[modify] https://crrev.com/8829d676d1e60f78ca54582b38fb5c53ecdbd191/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/8829d676d1e60f78ca54582b38fb5c53ecdbd191/chrome/browser/vr/ui_unittest.cc
Project Member

Comment 5 by bugdroid1@chromium.org, Feb 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aa96b3e6edc90f3b734430622737dd1c9c554184

commit aa96b3e6edc90f3b734430622737dd1c9c554184
Author: Christopher Grant <cjgrant@chromium.org>
Date: Wed Feb 07 19:56:48 2018

VR: Enable omnibox inline autcompletion

This CL introduces an initial implementation of inline autocomplete.  It
does not necessarily respect all corner cases of desktop or Clank
implementations, but is a simple and reasonable facsimile in terms of
behavior.

BUG= 799201 
R=vollick, ymalik

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Id36c016934daad9f1e823546f31da10e5751ef10
Reviewed-on: https://chromium-review.googlesource.com/899467
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#535110}
[modify] https://crrev.com/aa96b3e6edc90f3b734430622737dd1c9c554184/chrome/browser/android/vr_shell/gvr_keyboard_delegate.cc
[modify] https://crrev.com/aa96b3e6edc90f3b734430622737dd1c9c554184/chrome/browser/vr/BUILD.gn
[modify] https://crrev.com/aa96b3e6edc90f3b734430622737dd1c9c554184/chrome/browser/vr/elements/content_element.cc
[modify] https://crrev.com/aa96b3e6edc90f3b734430622737dd1c9c554184/chrome/browser/vr/elements/content_element.h
[add] https://crrev.com/aa96b3e6edc90f3b734430622737dd1c9c554184/chrome/browser/vr/elements/omnibox_text_field.cc
[add] https://crrev.com/aa96b3e6edc90f3b734430622737dd1c9c554184/chrome/browser/vr/elements/omnibox_text_field.h
[add] https://crrev.com/aa96b3e6edc90f3b734430622737dd1c9c554184/chrome/browser/vr/elements/omnibox_text_field_unittest.cc
[modify] https://crrev.com/aa96b3e6edc90f3b734430622737dd1c9c554184/chrome/browser/vr/elements/text_input.cc
[modify] https://crrev.com/aa96b3e6edc90f3b734430622737dd1c9c554184/chrome/browser/vr/elements/text_input.h
[modify] https://crrev.com/aa96b3e6edc90f3b734430622737dd1c9c554184/chrome/browser/vr/elements/text_input_unittest.cc
[modify] https://crrev.com/aa96b3e6edc90f3b734430622737dd1c9c554184/chrome/browser/vr/elements/ui_element.cc
[modify] https://crrev.com/aa96b3e6edc90f3b734430622737dd1c9c554184/chrome/browser/vr/elements/ui_element.h
[modify] https://crrev.com/aa96b3e6edc90f3b734430622737dd1c9c554184/chrome/browser/vr/keyboard_ui_interface.h
[modify] https://crrev.com/aa96b3e6edc90f3b734430622737dd1c9c554184/chrome/browser/vr/model/model.h
[modify] https://crrev.com/aa96b3e6edc90f3b734430622737dd1c9c554184/chrome/browser/vr/model/omnibox_suggestions.h
[modify] https://crrev.com/aa96b3e6edc90f3b734430622737dd1c9c554184/chrome/browser/vr/model/text_input_info.cc
[modify] https://crrev.com/aa96b3e6edc90f3b734430622737dd1c9c554184/chrome/browser/vr/model/text_input_info.h
[modify] https://crrev.com/aa96b3e6edc90f3b734430622737dd1c9c554184/chrome/browser/vr/testapp/test_keyboard_delegate.cc
[modify] https://crrev.com/aa96b3e6edc90f3b734430622737dd1c9c554184/chrome/browser/vr/ui.cc
[modify] https://crrev.com/aa96b3e6edc90f3b734430622737dd1c9c554184/chrome/browser/vr/ui.h
[modify] https://crrev.com/aa96b3e6edc90f3b734430622737dd1c9c554184/chrome/browser/vr/ui_input_manager.cc
[modify] https://crrev.com/aa96b3e6edc90f3b734430622737dd1c9c554184/chrome/browser/vr/ui_input_manager.h
[modify] https://crrev.com/aa96b3e6edc90f3b734430622737dd1c9c554184/chrome/browser/vr/ui_input_manager_unittest.cc
[modify] https://crrev.com/aa96b3e6edc90f3b734430622737dd1c9c554184/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/aa96b3e6edc90f3b734430622737dd1c9c554184/chrome/browser/vr/ui_scene_creator.h
Project Member

Comment 6 by bugdroid1@chromium.org, Feb 13 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6df268d7d501e4abef43ca73f46d4ac6eeabedda

commit 6df268d7d501e4abef43ca73f46d4ac6eeabedda
Author: Christopher Grant <cjgrant@chromium.org>
Date: Tue Feb 13 16:55:54 2018

VR: Enable in-line match if keyboard support selection

BUG= 799201 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I8db3a593d13ba7b7c24ec7f04d6ca05c97254e6a
Reviewed-on: https://chromium-review.googlesource.com/916364
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#536387}
[modify] https://crrev.com/6df268d7d501e4abef43ca73f46d4ac6eeabedda/chrome/browser/android/vr_shell/gvr_keyboard_delegate.cc
[modify] https://crrev.com/6df268d7d501e4abef43ca73f46d4ac6eeabedda/chrome/browser/android/vr_shell/gvr_keyboard_delegate.h
[modify] https://crrev.com/6df268d7d501e4abef43ca73f46d4ac6eeabedda/chrome/browser/android/vr_shell/gvr_keyboard_shim.cc
[modify] https://crrev.com/6df268d7d501e4abef43ca73f46d4ac6eeabedda/chrome/browser/vr/keyboard_delegate.h
[modify] https://crrev.com/6df268d7d501e4abef43ca73f46d4ac6eeabedda/chrome/browser/vr/model/model.h
[modify] https://crrev.com/6df268d7d501e4abef43ca73f46d4ac6eeabedda/chrome/browser/vr/test/mock_keyboard_delegate.h
[modify] https://crrev.com/6df268d7d501e4abef43ca73f46d4ac6eeabedda/chrome/browser/vr/testapp/test_keyboard_delegate.cc
[modify] https://crrev.com/6df268d7d501e4abef43ca73f46d4ac6eeabedda/chrome/browser/vr/testapp/test_keyboard_delegate.h
[modify] https://crrev.com/6df268d7d501e4abef43ca73f46d4ac6eeabedda/chrome/browser/vr/ui.cc
[modify] https://crrev.com/6df268d7d501e4abef43ca73f46d4ac6eeabedda/chrome/browser/vr/ui.h
[modify] https://crrev.com/6df268d7d501e4abef43ca73f46d4ac6eeabedda/chrome/browser/vr/ui_scene_creator.cc

Comment 7 by cjgrant@chromium.org, Feb 13 2018

Status: Fixed (was: Assigned)
Note that to enable this feature, a keyboard APK with API version 2 must be present.

Comment 8 by dougman@chromium.org, Feb 13 2018

Labels: Test-TestPlan

Comment 9 by dougman@chromium.org, Mar 7 2018

Labels: -Test-TestPlan Test-Complete
Status: Verified (was: Fixed)
Added test case "Inline Auto-Complete matching" to the "VR Browsing: Omnibox text entry manual test plan".

It appears the current keyboard APK in the Play Store has the API version 2+.
Verified fix on 66.0.3359.10.
►

Sign in to add a comment