New issue
Advanced search Search tips

Issue 799199 link

Starred by 1 user
Status: Fixed
Owner:
pprabhu@chromium.org
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

moblab-vm: Collect logs in case of timed out test

Project Member Reported by pprabhu@chromium.org, Jan 4 2018 
If the test times out in MoblabVMTest, the test_that call will be aborted, and the VM will be stopped.

In this case, we end up with no useful logs to look at.
Instead,
- hint to the test what the timeout is
- have the test set a reasonable timeout for the run_suite call internally.
- have the test collect logs and quit before the overall timeout is reached.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 7 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/3dc370160a024416bc4a31cafd7a67455c74c4f6

commit 3dc370160a024416bc4a31cafd7a67455c74c4f6
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Sun Jan 07 10:48:53 2018

moblab_RunSuite: Add test argument to hint at overall timeout.

For this test, cleanup action is very important. In case the test is
about to timeout, it is important to abort the suite within moblab and
collect logs from the moblab. A new test argument lets us hint at the
overall test timeout.

This will be particularly useful for MoablabVMTest where the test is run
via test_that.

BUG= chromium:799199 
TEST=moblab_RunSuite on moblab-vm, with and without the new argument.

Change-Id: I58bfda46c5e0fe648e04b77fbb00bc57321fb69b
Reviewed-on: https://chromium-review.googlesource.com/851119
Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Prathmesh Prabhu <pprabhu@chromium.org>

[modify] https://crrev.com/3dc370160a024416bc4a31cafd7a67455c74c4f6/server/site_tests/moblab_RunSuite/control.dummyServer
[modify] https://crrev.com/3dc370160a024416bc4a31cafd7a67455c74c4f6/server/site_tests/moblab_RunSuite/moblab_RunSuite.py
[modify] https://crrev.com/3dc370160a024416bc4a31cafd7a67455c74c4f6/server/cros/moblab_test.py
[modify] https://crrev.com/3dc370160a024416bc4a31cafd7a67455c74c4f6/server/site_tests/moblab_RunSuite/control.smoke
[modify] https://crrev.com/3dc370160a024416bc4a31cafd7a67455c74c4f6/server/site_tests/moblab_RunSuite/control.dummyServerNoSsp
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 9 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/bc2f4a335990b8c067ea1dabb61692ac66d5b897

commit bc2f4a335990b8c067ea1dabb61692ac66d5b897
Author: Prathmesh Prabhu <pprabhu@chromium.org>
Date: Tue Jan 09 03:56:47 2018

cbuildbot: Pass in timeout hint to moblab vm test

BUG= chromium:799199 
TEST=tryjob.
CQ-DEPEND=CL:851119

Change-Id: Id850de487856a4ca964737c1f874f332666cc153
Reviewed-on: https://chromium-review.googlesource.com/850731
Commit-Ready: Prathmesh Prabhu <pprabhu@chromium.org>
Tested-by: Prathmesh Prabhu <pprabhu@chromium.org>
Reviewed-by: Aviv Keshet <akeshet@chromium.org>

[modify] https://crrev.com/bc2f4a335990b8c067ea1dabb61692ac66d5b897/cbuildbot/stages/vm_test_stages.py
[modify] https://crrev.com/bc2f4a335990b8c067ea1dabb61692ac66d5b897/cbuildbot/stages/vm_test_stages_unittest.py

Comment 3 by pprabhu@chromium.org, Jan 9 2018

Status: Fixed (was: Started)
►

Sign in to add a comment