New issue
Advanced search Search tips

Issue 799191 link

Starred by 2 users
Status: Verified
Owner:
cjgrant@chromium.org
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR omnibox: Clicking App button should exit omnibox edit mode

Project Member Reported by cjgrant@chromium.org, Jan 4 2018 
According to the PRD, app button clicks should exit omnibox edit mode (P2 priority).

Note that this is currently not done for voice input, which feels inconsistent (especially if voice input is launched via omnibox).  We should close the loop with UX.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 15 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95b0b645da363318b941f70a1eb8f7493c85cc1a

commit 95b0b645da363318b941f70a1eb8f7493c85cc1a
Author: Christopher Grant <cjgrant@chromium.org>
Date: Mon Jan 15 19:33:08 2018

VR: Make app button exit omnibox and voice modes

If in voice search mode, the button will drop the user back to omnibox.

BUG= 799191 
R=ymalik

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ied184b953f001cd56f0a6aec770289e0aacb2a98
Reviewed-on: https://chromium-review.googlesource.com/867150
Reviewed-by: Yash Malik <ymalik@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529320}
[modify] https://crrev.com/95b0b645da363318b941f70a1eb8f7493c85cc1a/chrome/browser/vr/test/mock_ui_browser_interface.h
[modify] https://crrev.com/95b0b645da363318b941f70a1eb8f7493c85cc1a/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/95b0b645da363318b941f70a1eb8f7493c85cc1a/chrome/browser/vr/ui.cc
[modify] https://crrev.com/95b0b645da363318b941f70a1eb8f7493c85cc1a/chrome/browser/vr/ui.h
[modify] https://crrev.com/95b0b645da363318b941f70a1eb8f7493c85cc1a/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/95b0b645da363318b941f70a1eb8f7493c85cc1a/chrome/browser/vr/ui_unittest.cc

Comment 2 by cjgrant@chromium.org, Jan 16 2018

Status: Fixed (was: Assigned)
App button clicks now bail from voice and omnibox modes.

Comment 3 by dbbrooks@chromium.org, Jan 18 2018

Status: Verified (was: Fixed)
verified in 65.0.3323.3

Comment 4 by dougman@chromium.org, Feb 8 2018

Labels: Test-Manual M-65

Comment 5 by dougman@chromium.org, Feb 13 2018

Labels: -Test-Manual Test-Complete
Covered in the "VR Browsing: Omnibox text entry manual test plan".
►

Sign in to add a comment