VR omnibox: Support cursor positioning via click |
||||||||
Issue descriptionThe omnibox PRD specifies the ability to relocate the cursor as a P2. This is handy to ease corrections to typed text. Also for consideration: - Typically, when hovering text, a cursor changes to a text-select cursor (basically an 'I' shape). Currently VR users only the laser reticle.
,
Jan 10 2018
,
Jan 24 2018
The Youtube VR app does not change cursors while hovering or positioning the cursor on its search field. I'm considering that out of scope for this task.
,
Jan 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8ac6530dde84a3d4b3bbbd4ff7624c4a97f3b146 commit 8ac6530dde84a3d4b3bbbd4ff7624c4a97f3b146 Author: Christopher Grant <cjgrant@chromium.org> Date: Thu Jan 25 19:12:54 2018 VR: Let clicks reposition the cursor in text fields. BUG= 799189 R=ymalik Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I055bda2aef02a3278a090a6ebdd31a8769e8d4ce Reviewed-on: https://chromium-review.googlesource.com/884372 Reviewed-by: Yash Malik <ymalik@chromium.org> Commit-Queue: Christopher Grant <cjgrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#531971} [modify] https://crrev.com/8ac6530dde84a3d4b3bbbd4ff7624c4a97f3b146/chrome/browser/vr/elements/text.cc [modify] https://crrev.com/8ac6530dde84a3d4b3bbbd4ff7624c4a97f3b146/chrome/browser/vr/elements/text.h [modify] https://crrev.com/8ac6530dde84a3d4b3bbbd4ff7624c4a97f3b146/chrome/browser/vr/elements/text_input.cc [modify] https://crrev.com/8ac6530dde84a3d4b3bbbd4ff7624c4a97f3b146/chrome/browser/vr/elements/text_input.h [modify] https://crrev.com/8ac6530dde84a3d4b3bbbd4ff7624c4a97f3b146/chrome/browser/vr/testapp/test_keyboard_delegate.cc [modify] https://crrev.com/8ac6530dde84a3d4b3bbbd4ff7624c4a97f3b146/chrome/browser/vr/testapp/test_keyboard_delegate.h [modify] https://crrev.com/8ac6530dde84a3d4b3bbbd4ff7624c4a97f3b146/chrome/browser/vr/text_input_unittest.cc
,
Jan 25 2018
,
Jan 30 2018
Do we want to merge this into M65?
,
Feb 2 2018
I don't think so. It is part of the steady increase in omnibox functionality, and as such, should hit a branch naturally.
,
Feb 8 2018
,
Mar 8 2018
Verified this fix on 66.0.3359.10. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by cjgrant@chromium.org
, Jan 8 2018