blink_perf.events failing on chromium.perf/Android One Perf |
||||
Issue descriptionFiled by sheriff-o-matic@appspot.gserviceaccount.com on behalf of charliea@chromium.org blink_perf.events failing on chromium.perf/Android One Perf Builders failed on: - Android One Perf: https://build.chromium.org/p/chromium.perf/builders/Android%20One%20Perf The failing story seems to be blink_perf.events/EventsDispatchingInShadowTrees.html - the only story still running on Android One. A bisect doesn't look possible because the story went from flaky-pass to flaky fail
,
Jan 4 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dd98ffe7d737411f82f8334461aad799bf8c537f commit dd98ffe7d737411f82f8334461aad799bf8c537f Author: Charlie Andrews <charliea@google.com> Date: Thu Jan 04 20:44:51 2018 Disable blink_perf.events story on Android One NOTRY=true TBR=nednguyen@google.com, hayato@chromium.org Bug: 799184 Change-Id: Ic7ee070882bc1d2db502eccae6cadbb9b4807aa9 Reviewed-on: https://chromium-review.googlesource.com/851117 Reviewed-by: Charlie Andrews <charliea@chromium.org> Commit-Queue: Charlie Andrews <charliea@chromium.org> Cr-Commit-Position: refs/heads/master@{#527087} [modify] https://crrev.com/dd98ffe7d737411f82f8334461aad799bf8c537f/tools/perf/expectations.config
,
Jan 10 2018
> link_perf.events/EventsDispatchingInShadowTrees.html - the only story still running on Android One. Oh, I didn't have any intention to make EventsDispatchingInShadowTrees.html exceptional one. We shouldn't run tests on Android one? Then, how about disabling Android one by default, instead of requesting opt-out from every tests? Let me close this issue without any further action.
,
Jan 11 2018
Sorry - I didn't mean that the story shouldn't be running on Android One. I just wanted to indicate that it was the only story within the benchmark that was running on Android One. In general, unless there's some functional reason that a story shouldn't run on a given platform (for example a story measuring new tab creation time running on Webview, which doesn't have a new tab button), all stories should be running on all applicable platforms. This means that all blink_perf.events stories, unless they have a functional reason not to, should be running on Android One. In practice, many benchmarks have to disable some stories on Android One because of the constrained resource environment. Is there a functional reason why blink_perf.events shouldn't work on Android One?
,
Jan 11 2018
,
Jul 25
|
||||
►
Sign in to add a comment |
||||
Comment 1 by charliea@chromium.org
, Jan 4 2018