Cleanup expired experiments |
|||
Issue descriptionWithin an effort to reduce the variation seed size sent to clients, cleanup expired experiments that are not used anymore or the use can be removed as well.
,
Jan 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/afc138cdff8a1a1dba240fd03f9cc31870765678 commit afc138cdff8a1a1dba240fd03f9cc31870765678 Author: Gayane Petrosyan <gayane@chromium.org> Date: Tue Jan 09 16:43:33 2018 Remove code related to expired WebRTC-ApplicationUDPSendSocketSize study. WebRTC-ApplicationUDPSendSocketSize study is long expired and not useful anymore. All the clients are assigned to the default group which means that AdjustUdpSendBufferSize function will not make any difference. Bug: 799180 Change-Id: I94d42e538001896847c2d26a53836dffa1d96c14 Reviewed-on: https://chromium-review.googlesource.com/854947 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#528017} [modify] https://crrev.com/afc138cdff8a1a1dba240fd03f9cc31870765678/content/renderer/p2p/ipc_socket_factory.cc
,
Jan 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9ced2921c50f699c08877809721e4825d3af4552 commit 9ced2921c50f699c08877809721e4825d3af4552 Author: Gayane Petrosyan <gayane@chromium.org> Date: Tue Jan 09 17:41:52 2018 Remove code related to expired study RapporRollout. Remove code related to expired study RapporRollout. As cients get the default group which does not have the referenced param, the GetServerUrl function will always return the defautl server url. Therefore, this Cl removes GetServerUrl function and the use of RapporRollout. Bug: 799180 Change-Id: Ifcca7c4a16588029b30eb850c99f9c853767e9fa Reviewed-on: https://chromium-review.googlesource.com/855036 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by: Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#528036} [modify] https://crrev.com/9ced2921c50f699c08877809721e4825d3af4552/components/rappor/rappor_service_impl.cc
,
Jan 10 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d6477eec44d8f791963bb9cade352bb9b648461e commit d6477eec44d8f791963bb9cade352bb9b648461e Author: Gayane Petrosyan <gayane@chromium.org> Date: Wed Jan 10 16:29:46 2018 Remove BackgroundHtmlParserTokenLimits and HtmlPreloadScanning studies. Remove BackgroundHtmlParserTokenLimits as it is expired and is not useful anymore. Clients receive only the default group for this study which doesn't have any params. Remove HtmlPreloadScanning study as it doesn't exists. Also change unittests to not use the names of this studies even though it doesn't affect the logic of the tests. Bug: 799180 Change-Id: I57575bfe3cd9ec75067df739ee3aa2b6939e7c64 Reviewed-on: https://chromium-review.googlesource.com/857599 Reviewed-by: Bryan McQuade <bmcquade@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#528335} [modify] https://crrev.com/d6477eec44d8f791963bb9cade352bb9b648461e/chrome/browser/chrome_content_browser_client.cc [modify] https://crrev.com/d6477eec44d8f791963bb9cade352bb9b648461e/chrome/browser/chrome_content_browser_client_unittest.cc
,
Jan 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55e85608a30e1c9e28339be2a324243ee654f8c3 commit 55e85608a30e1c9e28339be2a324243ee654f8c3 Author: Gayane Petrosyan <gayane@chromium.org> Date: Thu Jan 11 14:46:45 2018 Remove ThrottleExtensionBackgroundPages study. ThrottleExtensionBackgroundPages expired study is not useful anymore as all the clients get the default group of this study which is "default". The code only has affect if the clients get groups named "ThrottlePersistent" or "ThrottleAll". Bug: 799180 Change-Id: I4d5a3515c6dbbf54de13127a10f3a84dcafcf8bd Reviewed-on: https://chromium-review.googlesource.com/860557 Reviewed-by: oysteine <oysteine@chromium.org> Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#528621} [modify] https://crrev.com/55e85608a30e1c9e28339be2a324243ee654f8c3/extensions/browser/extension_host.cc
,
Jan 12 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9dd22fe142b48f14765a36f69344ed4dbc289eb3 commit 9dd22fe142b48f14765a36f69344ed4dbc289eb3 Author: Gayane Petrosyan <gayane@chromium.org> Date: Fri Jan 12 19:39:49 2018 Remove LoadStaleCacheExperiment, AutoReloadExperiment and AutoReloadVisibleOnlyExperiment studies LoadStaleCacheExperiment, AutoReloadExperiment and AutoReloadVisibleOnlyExperiment studies are expired. Clients only receive the default groups for these studies which doesn't affect the removed code. Bug: 799180 Change-Id: I8ad0c2b171c8ea2ebf478bd467d6b3c01e47e7d1 Reviewed-on: https://chromium-review.googlesource.com/860531 Reviewed-by: Randy Smith <rdsmith@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#529026} [modify] https://crrev.com/9dd22fe142b48f14765a36f69344ed4dbc289eb3/chrome/browser/chrome_content_browser_client.cc
,
Jan 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/672edb165edd4772b87b53d9fb078a28dd7245ec commit 672edb165edd4772b87b53d9fb078a28dd7245ec Author: Gayane Petrosyan <gayane@chromium.org> Date: Tue Jan 16 05:51:41 2018 Remove expired study information from testing config. Remove testing config for studies that are expired and unused. Bug: 799180 Change-Id: I7d4a29da0f970198d1d2df1466a52d726df82180 Reviewed-on: https://chromium-review.googlesource.com/850438 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by: Jesse Doherty <jwd@chromium.org> Cr-Commit-Position: refs/heads/master@{#529365} [modify] https://crrev.com/672edb165edd4772b87b53d9fb078a28dd7245ec/testing/variations/fieldtrial_testing_config.json
,
Jan 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/85fd1f8059171ff116105753d153ea885d56ee7c commit 85fd1f8059171ff116105753d153ea885d56ee7c Author: Gayane Petrosyan <gayane@chromium.org> Date: Thu Jan 18 15:57:24 2018 Remove unittest that activates expired ShowProfileSwitcher trial. The ShouldShowAvatarMenu function doesn't seem to depend on trial, so there is no need to activate it in the unittest. Bug: 799180 Change-Id: I37d3408b11f4b27c44f6bf1b4a1c1903c9c95f6b Reviewed-on: https://chromium-review.googlesource.com/854396 Reviewed-by: Jesse Doherty <jwd@chromium.org> Reviewed-by: Elliot Glaysher <erg@chromium.org> Reviewed-by: anthonyvd <anthonyvd@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#530150} [modify] https://crrev.com/85fd1f8059171ff116105753d153ea885d56ee7c/chrome/browser/profiles/profile_list_desktop_unittest.cc
,
Jan 30 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f35e553f7c6e49b2a93037dc5a596af173ee7b7 commit 1f35e553f7c6e49b2a93037dc5a596af173ee7b7 Author: Gayane Petrosyan <gayane@chromium.org> Date: Tue Jan 30 20:27:49 2018 Remove WebRTC-SystemUDPSendSocketSize study Remove WebRTC-SystemUDPSendSocketSize which is long expired and not useful anymore. Also removing an unused include from ipc_socket_factory.cc which I missed in https://chromium-review.googlesource.com/c/chromium/src/+/854947 Bug: 799180 Change-Id: Iaa733fff48e7334ceafb3b212866c83822f369d1 Reviewed-on: https://chromium-review.googlesource.com/857884 Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#533006} [modify] https://crrev.com/1f35e553f7c6e49b2a93037dc5a596af173ee7b7/content/browser/renderer_host/p2p/socket_host_udp.cc [modify] https://crrev.com/1f35e553f7c6e49b2a93037dc5a596af173ee7b7/content/browser/renderer_host/p2p/socket_host_udp.h [modify] https://crrev.com/1f35e553f7c6e49b2a93037dc5a596af173ee7b7/content/renderer/p2p/ipc_socket_factory.cc
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55424d2fddaf4ff539d6bccf0daba6496696e94d commit 55424d2fddaf4ff539d6bccf0daba6496696e94d Author: Alexei Svitkine <asvitkine@chromium.org> Date: Tue Feb 06 20:22:36 2018 Remove code from obsolete field trial from 2015. Originally added here: https://codereview.chromium.org/1117193004 Bug: 799180 Change-Id: I8e46beafdc57c249fb9909e39c197519b2652c7b Reviewed-on: https://chromium-review.googlesource.com/902769 Reviewed-by: Mark Mentovai <mark@chromium.org> Cr-Commit-Position: refs/heads/master@{#534776} [modify] https://crrev.com/55424d2fddaf4ff539d6bccf0daba6496696e94d/base/sys_info.cc
,
Feb 6 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/700874ec0071a915f7c0df6704b36c21e0788011 commit 700874ec0071a915f7c0df6704b36c21e0788011 Author: Alexei Svitkine <asvitkine@chromium.org> Date: Tue Feb 06 20:27:44 2018 Revert "Remove code from obsolete field trial from 2015." This reverts commit 55424d2fddaf4ff539d6bccf0daba6496696e94d. Reason for revert: Windows compile failure. Original change's description: > Remove code from obsolete field trial from 2015. > > Originally added here: https://codereview.chromium.org/1117193004 > > Bug: 799180 > Change-Id: I8e46beafdc57c249fb9909e39c197519b2652c7b > Reviewed-on: https://chromium-review.googlesource.com/902769 > Reviewed-by: Mark Mentovai <mark@chromium.org> > Cr-Commit-Position: refs/heads/master@{#534776} TBR=asvitkine@chromium.org,mark@chromium.org Change-Id: If512ffd90d5218190d3bddb4931491f76e161aed No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 799180 Reviewed-on: https://chromium-review.googlesource.com/905462 Reviewed-by: Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#534781} [modify] https://crrev.com/700874ec0071a915f7c0df6704b36c21e0788011/base/sys_info.cc
,
Feb 27 2018
,
May 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7803d8c58f9b02d3d434b6c6c9f90d1f7919da31 commit 7803d8c58f9b02d3d434b6c6c9f90d1f7919da31 Author: Pavel Yatsuk <pavely@google.com> Date: Wed May 09 16:41:52 2018 Remove expired RefreshTokenDeviceId experiment BUG= 799180 R=gayane@chromium.org Change-Id: I83d0a362b9f52cfdf0db4e9eba48c6494dfcdad7 Reviewed-on: https://chromium-review.googlesource.com/1050978 Reviewed-by: Gayane Petrosyan <gayane@chromium.org> Commit-Queue: Pavel Yatsuk <pavely@chromium.org> Cr-Commit-Position: refs/heads/master@{#557217} [modify] https://crrev.com/7803d8c58f9b02d3d434b6c6c9f90d1f7919da31/testing/variations/fieldtrial_testing_config.json
,
May 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1b7d9c1d7c947275c2c2ff137361354a91267852 commit 1b7d9c1d7c947275c2c2ff137361354a91267852 Author: Roger McFarlane <rogerm@chromium.org> Date: Tue May 15 14:20:45 2018 [autofill] Remove obsolete AutofillProfileCleanup field trial. This CL removes a reference to an expired/obsolete experiment. Bug: 799180 Change-Id: Idaea49886fe8d47e74ec917527b0e7e5a8e65f01 Reviewed-on: https://chromium-review.googlesource.com/1058694 Commit-Queue: Sebastien Seguin-Gagnon <sebsg@chromium.org> Reviewed-by: Gayane Petrosyan <gayane@chromium.org> Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#558696} [modify] https://crrev.com/1b7d9c1d7c947275c2c2ff137361354a91267852/testing/variations/fieldtrial_testing_config.json
,
May 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ea3b36067abe168c180c180961c8af0f2980d5d8 commit ea3b36067abe168c180c180961c8af0f2980d5d8 Author: Vaclav Brozek <vabr@chromium.org> Date: Wed May 16 17:17:06 2018 Remove reference to PasswordBranding PasswordBranding was an experiment to change how Chrome's password manager is called. It has been removed from Chrome over a year ago [1], but the last reference in the test config was forgotten. This CL removes it. [1] In 57.0.2958.0, by https://codereview.chromium.org/2579823003. Bug: 799180 Change-Id: Ic003dcb375c490e5d72be6d495962e9860e8bbb1 Reviewed-on: https://chromium-review.googlesource.com/1061694 Reviewed-by: Robert Kaplow <rkaplow@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#559158} [modify] https://crrev.com/ea3b36067abe168c180c180961c8af0f2980d5d8/testing/variations/fieldtrial_testing_config.json
,
Oct 25
|
|||
►
Sign in to add a comment |
|||
Comment 1 by bugdroid1@chromium.org
, Jan 5 2018