New issue
Advanced search Search tips

Issue 799179 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Catapult trace processor should emit heap dump metrics

Project Member Reported by ssid@chromium.org, Jan 4 2018

Issue description

The heap dumps from the slow reports need to be processed to get the top heap dump categories. So, the trace processor should be able to extract the top category and add it as a tbmv2 memory metric
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/969e3986e8b291ff262a0caa51a98d5a7b6e65e3

commit 969e3986e8b291ff262a0caa51a98d5a7b6e65e3
Author: Siddhartha <ssid@chromium.org>
Date: Fri Jan 05 20:55:30 2018

Add memory metrics about heap dump categories

This adds memory metrics under 'malloc', 'blinkgc' and
'partitionAlloc' about the top heap dump category if heap dumps were
present in the trace.

BUG= chromium:799179 

Change-Id: Ic19b0abd8fcb38e3bbe2cbe6417d0fa997c6a925
Reviewed-on: https://chromium-review.googlesource.com/851212
Reviewed-by: Fadi Meawad <fmeawad@chromium.org>
Commit-Queue: Siddhartha S <ssid@chromium.org>

[modify] https://crrev.com/969e3986e8b291ff262a0caa51a98d5a7b6e65e3/tracing/tracing/metrics/system_health/memory_metric_test.html
[modify] https://crrev.com/969e3986e8b291ff262a0caa51a98d5a7b6e65e3/tracing/tracing/metrics/system_health/memory_metric.html

Comment 2 by ssid@chromium.org, Jan 5 2018

Summary: Catapult trace processor should emit heap dump metrics (was: Catepult trace processor should emit heap dump metrics)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dd50cf0f1fd7b9534f4d7a1d3160112c8fc983db

commit dd50cf0f1fd7b9534f4d7a1d3160112c8fc983db
Author: catapult-deps-roller@chromium.org <catapult-deps-roller@chromium.org>
Date: Fri Jan 05 23:15:09 2018

Roll src/third_party/catapult/ e440cb663..969e3986e (2 commits)

https://chromium.googlesource.com/catapult.git/+log/e440cb663b6b..969e3986e8b2

$ git log e440cb663..969e3986e --date=short --no-merges --format='%ad %ae %s'
2018-01-04 ssid Add memory metrics about heap dump categories
2017-12-26 pasko Remove mentions of unused trace event

Created with:
  roll-dep src/third_party/catapult
BUG= 799179 


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: If55b46729705c605f3d55485e1f859cd0217e39c
Reviewed-on: https://chromium-review.googlesource.com/852528
Reviewed-by: <catapult-deps-roller@chromium.org>
Commit-Queue: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527423}
[modify] https://crrev.com/dd50cf0f1fd7b9534f4d7a1d3160112c8fc983db/DEPS

Comment 4 by ssid@chromium.org, Mar 22 2018

Status: Fixed (was: Untriaged)

Sign in to add a comment