New issue
Advanced search Search tips

Issue 799176 link

Starred by 2 users
Status: Fixed
Owner:
cjgrant@chromium.org
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR omnibox: Properly style suggestion text

Project Member Reported by cjgrant@chromium.org, Jan 4 2018 
AutocompleteController supplies metadata to let us emphasize and color parts of the suggestion content and description.  We should parse this, and pass it to the UI for rendering.

If possible, we should translate the representation to something general to the VR UI, in case we want to use it elsewhere (such as the URL representation on the URL bar).

Comment 1 by cjgrant@chromium.org, Jan 15 2018 

This is in progress now.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae83c7b322fb358846cd8d44d59d73a9d7224b3b

commit ae83c7b322fb358846cd8d44d59d73a9d7224b3b
Author: Christopher Grant <cjgrant@chromium.org>
Date: Wed Jan 17 19:01:36 2018

VR: Format omnibox suggestion text

This CL introduces a generic means of formatting single-line Text UI
elements, and uses it to apply the already-supplied suggestion
formatting to the appropriate elements.

BUG= 799176 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I355e8f97254b3c19c2506363f6f2685bf8976a52
Reviewed-on: https://chromium-review.googlesource.com/868991
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Reviewed-by: Ian Vollick <vollick@chromium.org>
Reviewed-by: Yash Malik <ymalik@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529833}
[modify] https://crrev.com/ae83c7b322fb358846cd8d44d59d73a9d7224b3b/chrome/browser/android/vr_shell/autocomplete_controller.cc
[modify] https://crrev.com/ae83c7b322fb358846cd8d44d59d73a9d7224b3b/chrome/browser/vr/BUILD.gn
[add] https://crrev.com/ae83c7b322fb358846cd8d44d59d73a9d7224b3b/chrome/browser/vr/elements/omnibox_formatting.cc
[add] https://crrev.com/ae83c7b322fb358846cd8d44d59d73a9d7224b3b/chrome/browser/vr/elements/omnibox_formatting.h
[add] https://crrev.com/ae83c7b322fb358846cd8d44d59d73a9d7224b3b/chrome/browser/vr/elements/omnibox_formatting_unittest.cc
[modify] https://crrev.com/ae83c7b322fb358846cd8d44d59d73a9d7224b3b/chrome/browser/vr/elements/render_text_wrapper.cc
[modify] https://crrev.com/ae83c7b322fb358846cd8d44d59d73a9d7224b3b/chrome/browser/vr/elements/render_text_wrapper.h
[modify] https://crrev.com/ae83c7b322fb358846cd8d44d59d73a9d7224b3b/chrome/browser/vr/elements/text.cc
[modify] https://crrev.com/ae83c7b322fb358846cd8d44d59d73a9d7224b3b/chrome/browser/vr/elements/text.h
[modify] https://crrev.com/ae83c7b322fb358846cd8d44d59d73a9d7224b3b/chrome/browser/vr/elements/text_unittest.cc
[modify] https://crrev.com/ae83c7b322fb358846cd8d44d59d73a9d7224b3b/chrome/browser/vr/elements/url_bar_texture_unittest.cc
[modify] https://crrev.com/ae83c7b322fb358846cd8d44d59d73a9d7224b3b/chrome/browser/vr/model/color_scheme.cc
[modify] https://crrev.com/ae83c7b322fb358846cd8d44d59d73a9d7224b3b/chrome/browser/vr/model/color_scheme.h
[modify] https://crrev.com/ae83c7b322fb358846cd8d44d59d73a9d7224b3b/chrome/browser/vr/model/omnibox_suggestions.cc
[modify] https://crrev.com/ae83c7b322fb358846cd8d44d59d73a9d7224b3b/chrome/browser/vr/model/omnibox_suggestions.h
[add] https://crrev.com/ae83c7b322fb358846cd8d44d59d73a9d7224b3b/chrome/browser/vr/test/mock_render_text.cc
[add] https://crrev.com/ae83c7b322fb358846cd8d44d59d73a9d7224b3b/chrome/browser/vr/test/mock_render_text.h
[modify] https://crrev.com/ae83c7b322fb358846cd8d44d59d73a9d7224b3b/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/ae83c7b322fb358846cd8d44d59d73a9d7224b3b/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/ae83c7b322fb358846cd8d44d59d73a9d7224b3b/chrome/browser/vr/ui_unittest.cc

Comment 3 by cjgrant@chromium.org, Jan 17 2018

Labels: M-65
Status: Fixed (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 17 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12f14108a21fe77c7021f72a51ec49c98cc57922

commit 12f14108a21fe77c7021f72a51ec49c98cc57922
Author: Stephen McGruer <smcgruer@chromium.org>
Date: Wed Jan 17 20:08:51 2018

Revert "VR: Format omnibox suggestion text"

This reverts commit ae83c7b322fb358846cd8d44d59d73a9d7224b3b.

Reason for revert: Breaks compile on at least linux-chromeos-rel

https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2Flinux-chromeos-rel%2F4396%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout

../../chrome/browser/vr/testapp/vr_test_context.cc:495:23: error: no member named 'MakeUnique' in namespace 'base'
  auto result = base::MakeUnique<OmniboxSuggestions>();

Original change's description:
> VR: Format omnibox suggestion text
> 
> This CL introduces a generic means of formatting single-line Text UI
> elements, and uses it to apply the already-supplied suggestion
> formatting to the appropriate elements.
> 
> BUG= 799176 
> 
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I355e8f97254b3c19c2506363f6f2685bf8976a52
> Reviewed-on: https://chromium-review.googlesource.com/868991
> Commit-Queue: Christopher Grant <cjgrant@chromium.org>
> Reviewed-by: Ian Vollick <vollick@chromium.org>
> Reviewed-by: Yash Malik <ymalik@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#529833}

TBR=vollick@chromium.org,cjgrant@chromium.org,ymalik@chromium.org

Change-Id: Ia299da20888617e3ebdacbc997dfc51a027eb072
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  799176 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/870893
Reviewed-by: Stephen McGruer <smcgruer@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529854}
[modify] https://crrev.com/12f14108a21fe77c7021f72a51ec49c98cc57922/chrome/browser/android/vr_shell/autocomplete_controller.cc
[modify] https://crrev.com/12f14108a21fe77c7021f72a51ec49c98cc57922/chrome/browser/vr/BUILD.gn
[delete] https://crrev.com/7458fbc6ca2ff2fcf38bb4320183d3304fbea671/chrome/browser/vr/elements/omnibox_formatting.cc
[delete] https://crrev.com/7458fbc6ca2ff2fcf38bb4320183d3304fbea671/chrome/browser/vr/elements/omnibox_formatting.h
[delete] https://crrev.com/7458fbc6ca2ff2fcf38bb4320183d3304fbea671/chrome/browser/vr/elements/omnibox_formatting_unittest.cc
[modify] https://crrev.com/12f14108a21fe77c7021f72a51ec49c98cc57922/chrome/browser/vr/elements/render_text_wrapper.cc
[modify] https://crrev.com/12f14108a21fe77c7021f72a51ec49c98cc57922/chrome/browser/vr/elements/render_text_wrapper.h
[modify] https://crrev.com/12f14108a21fe77c7021f72a51ec49c98cc57922/chrome/browser/vr/elements/text.cc
[modify] https://crrev.com/12f14108a21fe77c7021f72a51ec49c98cc57922/chrome/browser/vr/elements/text.h
[modify] https://crrev.com/12f14108a21fe77c7021f72a51ec49c98cc57922/chrome/browser/vr/elements/text_unittest.cc
[modify] https://crrev.com/12f14108a21fe77c7021f72a51ec49c98cc57922/chrome/browser/vr/elements/url_bar_texture_unittest.cc
[modify] https://crrev.com/12f14108a21fe77c7021f72a51ec49c98cc57922/chrome/browser/vr/model/color_scheme.cc
[modify] https://crrev.com/12f14108a21fe77c7021f72a51ec49c98cc57922/chrome/browser/vr/model/color_scheme.h
[modify] https://crrev.com/12f14108a21fe77c7021f72a51ec49c98cc57922/chrome/browser/vr/model/omnibox_suggestions.cc
[modify] https://crrev.com/12f14108a21fe77c7021f72a51ec49c98cc57922/chrome/browser/vr/model/omnibox_suggestions.h
[delete] https://crrev.com/7458fbc6ca2ff2fcf38bb4320183d3304fbea671/chrome/browser/vr/test/mock_render_text.cc
[delete] https://crrev.com/7458fbc6ca2ff2fcf38bb4320183d3304fbea671/chrome/browser/vr/test/mock_render_text.h
[modify] https://crrev.com/12f14108a21fe77c7021f72a51ec49c98cc57922/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/12f14108a21fe77c7021f72a51ec49c98cc57922/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/12f14108a21fe77c7021f72a51ec49c98cc57922/chrome/browser/vr/ui_unittest.cc

Comment 5 by ddorwin@chromium.org, Jan 17 2018

Status: Started (was: Fixed)
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 18 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7a1af3dc2561b5c7874db57ed62ce0da139b0c60

commit 7a1af3dc2561b5c7874db57ed62ce0da139b0c60
Author: Christopher Grant <cjgrant@chromium.org>
Date: Thu Jan 18 00:33:58 2018

Reland "VR: Format omnibox suggestion text"

This is a reland of ae83c7b322fb358846cd8d44d59d73a9d7224b3b
Original change's description:
> VR: Format omnibox suggestion text
>
> This CL introduces a generic means of formatting single-line Text UI
> elements, and uses it to apply the already-supplied suggestion
> formatting to the appropriate elements.
>
> BUG= 799176 
>
> Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
> Change-Id: I355e8f97254b3c19c2506363f6f2685bf8976a52
> Reviewed-on: https://chromium-review.googlesource.com/868991
> Commit-Queue: Christopher Grant <cjgrant@chromium.org>
> Reviewed-by: Ian Vollick <vollick@chromium.org>
> Reviewed-by: Yash Malik <ymalik@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#529833}

TBR=vollick

Bug:  799176 
Change-Id: If957e97c9c71a0f04ab75ebf6e810e9ad55baa27
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/871710
Reviewed-by: Christopher Grant <cjgrant@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#529978}
[modify] https://crrev.com/7a1af3dc2561b5c7874db57ed62ce0da139b0c60/chrome/browser/android/vr_shell/autocomplete_controller.cc
[modify] https://crrev.com/7a1af3dc2561b5c7874db57ed62ce0da139b0c60/chrome/browser/vr/BUILD.gn
[add] https://crrev.com/7a1af3dc2561b5c7874db57ed62ce0da139b0c60/chrome/browser/vr/elements/omnibox_formatting.cc
[add] https://crrev.com/7a1af3dc2561b5c7874db57ed62ce0da139b0c60/chrome/browser/vr/elements/omnibox_formatting.h
[add] https://crrev.com/7a1af3dc2561b5c7874db57ed62ce0da139b0c60/chrome/browser/vr/elements/omnibox_formatting_unittest.cc
[modify] https://crrev.com/7a1af3dc2561b5c7874db57ed62ce0da139b0c60/chrome/browser/vr/elements/render_text_wrapper.cc
[modify] https://crrev.com/7a1af3dc2561b5c7874db57ed62ce0da139b0c60/chrome/browser/vr/elements/render_text_wrapper.h
[modify] https://crrev.com/7a1af3dc2561b5c7874db57ed62ce0da139b0c60/chrome/browser/vr/elements/text.cc
[modify] https://crrev.com/7a1af3dc2561b5c7874db57ed62ce0da139b0c60/chrome/browser/vr/elements/text.h
[modify] https://crrev.com/7a1af3dc2561b5c7874db57ed62ce0da139b0c60/chrome/browser/vr/elements/text_unittest.cc
[modify] https://crrev.com/7a1af3dc2561b5c7874db57ed62ce0da139b0c60/chrome/browser/vr/elements/url_bar_texture_unittest.cc
[modify] https://crrev.com/7a1af3dc2561b5c7874db57ed62ce0da139b0c60/chrome/browser/vr/model/color_scheme.cc
[modify] https://crrev.com/7a1af3dc2561b5c7874db57ed62ce0da139b0c60/chrome/browser/vr/model/color_scheme.h
[modify] https://crrev.com/7a1af3dc2561b5c7874db57ed62ce0da139b0c60/chrome/browser/vr/model/omnibox_suggestions.cc
[modify] https://crrev.com/7a1af3dc2561b5c7874db57ed62ce0da139b0c60/chrome/browser/vr/model/omnibox_suggestions.h
[add] https://crrev.com/7a1af3dc2561b5c7874db57ed62ce0da139b0c60/chrome/browser/vr/test/mock_render_text.cc
[add] https://crrev.com/7a1af3dc2561b5c7874db57ed62ce0da139b0c60/chrome/browser/vr/test/mock_render_text.h
[modify] https://crrev.com/7a1af3dc2561b5c7874db57ed62ce0da139b0c60/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/7a1af3dc2561b5c7874db57ed62ce0da139b0c60/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/7a1af3dc2561b5c7874db57ed62ce0da139b0c60/chrome/browser/vr/ui_unittest.cc

Comment 7 by cjgrant@chromium.org, Jan 23 2018

Status: Fixed (was: Started)

Comment 8 by dougman@chromium.org, Feb 7 2018

Labels: Test-Complete
►

Sign in to add a comment