New issue
Advanced search Search tips

Issue 799174 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 821946
Owner:
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR omnibox: Make the URL portion of the URL bar highlight when hovered and clicked

Project Member Reported by cjgrant@chromium.org, Jan 4 2018

Issue description

Currently, there is no visual feedback that the URL is clickable.  We should give this feedback.

As part of this, the URL bar UI element should be decomposed to separate the back button, and generally modernize how the element is constructed.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 11 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9c931afc0261df936a45efa7a08085797877685f

commit 9c931afc0261df936a45efa7a08085797877685f
Author: Christopher Grant <cjgrant@chromium.org>
Date: Thu Jan 11 18:41:28 2018

VR: Partially split the URL bar into elements

The URL bar has always been a single element and texture. Now that the
UI framework has evolved, it's past time to start splitting this up.

This change hacks off the back button, and reduces the catch-all texture
to only the URL origin presentation part of the URL bar.  This could be
further split in the future, but not until we have a linear layout that
can resize children to limit its total size.

BUG= 799174 

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: Ic2aeffe9af9e3523fea032bffa4be05aa3426874
Reviewed-on: https://chromium-review.googlesource.com/861044
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Christopher Grant <cjgrant@chromium.org>
Cr-Commit-Position: refs/heads/master@{#528682}
[modify] https://crrev.com/9c931afc0261df936a45efa7a08085797877685f/chrome/browser/vr/elements/button.cc
[modify] https://crrev.com/9c931afc0261df936a45efa7a08085797877685f/chrome/browser/vr/elements/button.h
[modify] https://crrev.com/9c931afc0261df936a45efa7a08085797877685f/chrome/browser/vr/elements/button_unittest.cc
[modify] https://crrev.com/9c931afc0261df936a45efa7a08085797877685f/chrome/browser/vr/elements/disc_button.cc
[modify] https://crrev.com/9c931afc0261df936a45efa7a08085797877685f/chrome/browser/vr/elements/ui_element.cc
[modify] https://crrev.com/9c931afc0261df936a45efa7a08085797877685f/chrome/browser/vr/elements/ui_element_name.cc
[modify] https://crrev.com/9c931afc0261df936a45efa7a08085797877685f/chrome/browser/vr/elements/ui_element_name.h
[modify] https://crrev.com/9c931afc0261df936a45efa7a08085797877685f/chrome/browser/vr/elements/url_bar.cc
[modify] https://crrev.com/9c931afc0261df936a45efa7a08085797877685f/chrome/browser/vr/elements/url_bar.h
[modify] https://crrev.com/9c931afc0261df936a45efa7a08085797877685f/chrome/browser/vr/elements/url_bar_texture.cc
[modify] https://crrev.com/9c931afc0261df936a45efa7a08085797877685f/chrome/browser/vr/elements/url_bar_texture.h
[modify] https://crrev.com/9c931afc0261df936a45efa7a08085797877685f/chrome/browser/vr/model/color_scheme.cc
[modify] https://crrev.com/9c931afc0261df936a45efa7a08085797877685f/chrome/browser/vr/model/color_scheme.h
[modify] https://crrev.com/9c931afc0261df936a45efa7a08085797877685f/chrome/browser/vr/test/ui_test.cc
[modify] https://crrev.com/9c931afc0261df936a45efa7a08085797877685f/chrome/browser/vr/testapp/vr_test_context.cc
[modify] https://crrev.com/9c931afc0261df936a45efa7a08085797877685f/chrome/browser/vr/testapp/vr_test_context.h
[modify] https://crrev.com/9c931afc0261df936a45efa7a08085797877685f/chrome/browser/vr/ui_scene_constants.h
[modify] https://crrev.com/9c931afc0261df936a45efa7a08085797877685f/chrome/browser/vr/ui_scene_creator.cc
[modify] https://crrev.com/9c931afc0261df936a45efa7a08085797877685f/chrome/browser/vr/ui_scene_creator.h
[modify] https://crrev.com/9c931afc0261df936a45efa7a08085797877685f/chrome/browser/vr/ui_unittest.cc

Latest thinking here is to highlight the entire half of the URL bar, not just the URL text portion.

The security icon, which is a separate button, should remain separately clickable.
Status: WontFix (was: Assigned)
As per discussion with Gordon, there is no current issue with folks knowing to click the URL bar, and highlighting it on hover may not be what we want.

I'm closing this until we have a clear motive to implement this hover effect.
Labels: Test-Manual
Labels: Test-Manual
Labels: -Test-Manual Test-Complete
I would suggest filing a new bug at that time.  If not then remove the Test-Complete label so that Test will look at the future changes.
Status: Duplicate (was: WontFix)
Mergedinto: 821946

Sign in to add a comment