New issue
Advanced search Search tips

Issue 799169 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 772160



Sign in to add a comment

Clean up CdmWrapper

Project Member Reported by xhw...@chromium.org, Jan 4 2018

Issue description

After pepper CDM support is removed, CdmWrapper can depend on
media/ and we can clean this class up, e.g. pass CdmConfig directly.
 
Summary: Clean up CdmWrapper (was: Clearn up CdmWrapper)

Comment 2 by xhw...@chromium.org, Mar 23 2018

Labels: -M-67 M-68

Comment 3 by xhw...@chromium.org, Apr 13 2018

Labels: -M-68
Project Member

Comment 4 by bugdroid1@chromium.org, Apr 19 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff1f496d021b78cd49df2e26e1bcc2c47f2a4044

commit ff1f496d021b78cd49df2e26e1bcc2c47f2a4044
Author: Xiaohan Wang <xhwang@chromium.org>
Date: Thu Apr 19 17:38:50 2018

media: Refactor supported CDM version check

- Convert runtime DCHECK to compile time static_assert.
- Add helper function to simplify the check logic.
- Use CDM interface version as CdmWrapperImpl template argument to
  simplify some code and check logic.

Bug: 799169,733821
Test: No functionality change.
Change-Id: I2a97be9a507db853eb91b739bf26511492665eee
Reviewed-on: https://chromium-review.googlesource.com/1018144
Reviewed-by: John Rummell <jrummell@chromium.org>
Commit-Queue: Xiaohan Wang <xhwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#552070}
[modify] https://crrev.com/ff1f496d021b78cd49df2e26e1bcc2c47f2a4044/media/cdm/cdm_adapter.cc
[modify] https://crrev.com/ff1f496d021b78cd49df2e26e1bcc2c47f2a4044/media/cdm/cdm_wrapper.h
[modify] https://crrev.com/ff1f496d021b78cd49df2e26e1bcc2c47f2a4044/media/cdm/supported_cdm_versions.cc
[modify] https://crrev.com/ff1f496d021b78cd49df2e26e1bcc2c47f2a4044/media/cdm/supported_cdm_versions.h

Sign in to add a comment