New issue
Advanced search Search tips

Issue 799167 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

time_to_interactive metric causing widespread redness in loading.mobile (especially on Nexus7v2)

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jan 4 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of charliea@chromium.org

The callstack always looks like:

(WARNING) 2017-12-28 12:54:12,966 timeline_based_measurement._ComputeTimelineBasedMetrics:310  Processing resulting traces took 3.538 seconds
Traceback (most recent call last):
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/value/failure.py", line 41, in _GetExcInfoFromMessage
    raise Exception(message)
Exception: Error: Internal Error: List of tasks used to construct TaskCluster must be sorted.
    at new TaskCluster (/tracing/metrics/system_health/time_to_interactive.html:240:17)
    at findFCITaskClusters (/tracing/metrics/system_health/time_to_interactive.html:299:19)
    at Object.findFirstCpuIdleTime (/tracing/metrics/system_health/time_to_interactive.html:361:26)
    at computeInteractivityMetricSample_ (/tracing/metrics/system_health/loading_metric.html:394:23)
    at addSamples (/tracing/metrics/system_health/loading_metric.html:447:13)
    at collectFirstMeaningfulPaintAndInteractivityMetricsForRenderer (/tracing/metrics/system_health/loading_metric.html:485:9)
    at collectLoadingMetricsForRenderer (/tracing/metrics/system_health/loading_metric.html:514:9)
    at new loadingMetric (/tracing/metrics/system_health/loading_metric.html:620:11)
    at runMetrics (/b/swarming/w/ir/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:47:16)

Some links to examples:

https://logs.chromium.org/v/?s=chrome%2Fbb%2Fchromium.perf%2FAndroid_Nexus7v2_Perf%2F1059%2F%2B%2Frecipes%2Fsteps%2Floading.mobile_on_Android%2F0%2Fstdout

https://logs.chromium.org/v/?s=chrome%2Fbb%2Fchromium.perf%2FAndroid_Nexus7v2_Perf%2F1022%2F%2B%2Frecipes%2Fsteps%2Floading.mobile_on_Android%2F0%2Fstdout

https://logs.chromium.org/v/?s=chrome%2Fbb%2Fchromium.perf%2FAndroid_Nexus7v2_Perf%2F1046%2F%2B%2Frecipes%2Fsteps%2Floading.mobile_on_Android%2F0%2Fstdout

https://logs.chromium.org/v/?s=chrome%2Fbb%2Fchromium.perf%2FAndroid_One_Perf%2F877%2F%2B%2Frecipes%2Fsteps%2Floading.mobile_on_Android%2F0%2Fstdout

I'm not sure why this is disproportionately affecting Nexus 7v2.
 
Owner: dproy@chromium.org
Status: Assigned (was: Available)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/d14d29762cc0d6fd8c4738a8be98a91b965258ec

commit d14d29762cc0d6fd8c4738a8be98a91b965258ec
Author: Deepanjan Roy <dproy@chromium.org>
Date: Sat Jan 06 00:24:27 2018

TTI: Handle rounding error for duration between tasks

When two toplevel tasks have very little gap between them, rounding
errors can cause the end of the earlier task to be after the beginning
of the later task. This CL overlooks rounding errors up to 1e-7.

Bug:  chromium:799167 
Change-Id: Ia8f0de4da8e7929f2bc43f1fa900691ccc7bcd0d
Reviewed-on: https://chromium-review.googlesource.com/852485
Reviewed-by: Ben Hayden <benjhayden@chromium.org>
Commit-Queue: Deepanjan Roy <dproy@chromium.org>

[modify] https://crrev.com/d14d29762cc0d6fd8c4738a8be98a91b965258ec/tracing/tracing/metrics/system_health/time_to_interactive.html

Really appreciate you investigating and fixing this problem quickly Deep.

Comment 4 by dproy@chromium.org, Jan 23 2018

Charlie, can I close this bug? I'm not entirely sure how to verify the redness is gone. 
Status: Fixed (was: Assigned)
I'd use the flakiness dashboard for that: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=loading.mobile&builder=chromium.perf%3AAndroid%20Nexus7v2%20Perf

The greenness seems to confirm that you fixed it. Thanks!

Sign in to add a comment