New issue
Advanced search Search tips

Issue 799122 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

system_health.common_desktop's load:media:youtube failing on Mac due to estimated_input_latency error

Project Member Reported by charliea@chromium.org, Jan 4 2018

Issue description

It seems that the estimated_input_latency metric is causing regular failures on load:media:youtube on Mac Pro 10.11 Perf.

Here are some instances of this happening:

https://chromium-swarm.appspot.com/task?id=3ad56510f3aca410&refresh=10&show_raw=1

https://chromium-swarm.appspot.com/task?id=3ad56510f3aca410&refresh=10&show_raw=1

https://chromium-swarm.appspot.com/task?id=3ad31e928b5cd210&refresh=10&show_raw=1

The call stack generated is:

Traceback (most recent call last):
  File "/b/s/w/ir/third_party/catapult/telemetry/telemetry/value/failure.py", line 41, in _GetExcInfoFromMessage
    raise Exception(message)
Exception: Error: The sliding window must fit in the specified time range
    at Object.maxExpectedQueueingTimeInSlidingWindow (/tracing/extras/chrome/estimated_input_latency.html:308:13)
    at addExpectedQueueingTimeMetric_ (/tracing/metrics/system_health/expected_queueing_time_metric.html:139:23)
    at new expectedQueueingTimeMetric (/tracing/metrics/system_health/expected_queueing_time_metric.html:85:5)
    at runMetrics (/b/s/w/ir/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:47:16)
    at metricMapFunction (/b/s/w/ir/third_party/catapult/tracing/tracing/metrics/metric_map_function.html:149:24)
    at Object.mapSingleTrace (/tracing/mre/map_single_trace.html:39:7)
    at eval (/b/s/w/ir/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:61:18)
    at Object.runAndConvertErrorsToFailures (/tracing/mre/map_single_trace.html:24:10)
    at mapSingleTraceWithResult (/b/s/w/ir/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:52:12)
    at Object.mapSingleTraceMain (/b/s/w/ir/third_party/catapult/tracing/tracing/mre/map_single_trace_cmdline.html:77:20)

dproy@, could you investigate this? In the meanwhile, I'm going to go ahead and disable the story in the meanwhile, and (for some reason) it doesn't seem to be happening elsewhere.

 
Summary: system_health.common_desktop's load:media:youtube failing on Mac due to estimated_input_latency error (was: <test> failure on chromium.perf at <revisionrange>)
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7cc2d1e3088821423b41d15544ec15f83575ec58

commit 7cc2d1e3088821423b41d15544ec15f83575ec58
Author: Charlie Andrews <charliea@google.com>
Date: Thu Jan 04 18:46:50 2018

Disable several failing system health stories

NOTRY=true
TBR=nednguyen@google.com
CC=perezju@chromium.org

Bug:  799106 ,  799122 
Change-Id: I605dd95215ce0a3cfcaacf81be3a7b81ae5ec7c6
Reviewed-on: https://chromium-review.googlesource.com/850436
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527048}
[modify] https://crrev.com/7cc2d1e3088821423b41d15544ec15f83575ec58/tools/perf/expectations.config

Labels: -Pri-1 Pri-2
Lowering priority to P2 now that the story is disabled. 
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/a21a0349c3ad6563cd467e755bc58a2e0d4f3d50

commit a21a0349c3ad6563cd467e755bc58a2e0d4f3d50
Author: Deepanjan Roy <dproy@chromium.org>
Date: Fri Jan 05 22:51:51 2018

Do not compute EQT if renderer lifetime is too small

Youtube spawns a very short lived renderer for handling login. The
lifetime of the renderer is around 200ms, which is smaller than the
window size (500ms) for EQT, and triggers an assertion failure. Since
renderers this small do not have meaningful EQT, it is better to skip
them.

Bug:  chromium:799122 
Change-Id: Ibba548e511f47d76c1a3ea783e5761a65be9af5d
Reviewed-on: https://chromium-review.googlesource.com/852827
Commit-Queue: Deepanjan Roy <dproy@chromium.org>
Reviewed-by: Ben Hayden <benjhayden@chromium.org>

[modify] https://crrev.com/a21a0349c3ad6563cd467e755bc58a2e0d4f3d50/tracing/tracing/metrics/system_health/expected_queueing_time_metric.html

Comment 5 by dproy@chromium.org, Jan 5 2018

It should be fixed now. You can try re-enabling the story. 

Comment 6 by dproy@chromium.org, Jan 5 2018

Status: Fixed (was: Assigned)
Status: Available (was: Fixed)
Leaving this open to track re-enabling the test.
Deep, I think typically that you'd re-enable the test in this circumstance. Can you re-enable?
Status: Started (was: Available)
Thanks for addressing this quickly Deep!
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/90d231ef0b4e6bafc89c2abf616d1feefe0430cc

commit 90d231ef0b4e6bafc89c2abf616d1feefe0430cc
Author: Deepanjan Roy <dproy@chromium.org>
Date: Mon Jan 08 21:52:53 2018

Re-enable load:media:youtube story

Bug:  chromium:799122 
Change-Id: I1b0a8a34cf15f68e24004ffa71214337bbe28a84
Reviewed-on: https://chromium-review.googlesource.com/854616
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Deepanjan Roy <dproy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527769}
[modify] https://crrev.com/90d231ef0b4e6bafc89c2abf616d1feefe0430cc/tools/perf/expectations.config

Status: Fixed (was: Started)
Re-enabled story and marking as fixed. Reopen if errors appear again. 

Sign in to add a comment