[Findit] Flake Analyzer - failed to schedule try job due to missing revision |
|||
Issue description
TypeError: not all arguments converted during string formatting (/base/data/home/apps/s~findit-for-me/waterfall-backend:13208-3878285.406175012381044886/infra_api_clients/../third_party/pipeline/pipeline.py:2434)
Traceback (most recent call last):
File "/base/data/home/apps/s~findit-for-me/waterfall-backend:13208-3878285.406175012381044886/infra_api_clients/../third_party/pipeline/pipeline.py", line 2158, in evaluate
self, pipeline_key, root_pipeline_key, caller_output)
File "/base/data/home/apps/s~findit-for-me/waterfall-backend:13208-3878285.406175012381044886/infra_api_clients/../third_party/pipeline/pipeline.py", line 1113, in _run_internal
return self.run(*self.args, **self.kwargs)
File "/base/data/home/apps/s~findit-for-me/waterfall-backend:13208-3878285.406175012381044886/waterfall/flake/schedule_flake_try_job_pipeline.py", line 57, in run
cache_name, dimensions, self.pipeline_id)
File "/base/data/home/apps/s~findit-for-me/waterfall-backend:13208-3878285.406175012381044886/services/try_job.py", line 335, in TriggerTryJob
swarming_util.AssignWarmCacheHost(try_job, cache_name, FinditHttpClient())
File "/base/data/home/apps/s~findit-for-me/waterfall-backend:13208-3878285.406175012381044886/waterfall/swarming_util.py", line 898, in AssignWarmCacheHost
logging.error('Tryjob %s does not have a specified revision.' % tryjob)
TypeError: not all arguments converted during string formatting
,
Jan 4 2018
Here are more. We'd better fix it asap. https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyvQELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKGAWNocm9taXVtLm1lbW9yeS9MaW51eCBDaHJvbWl1bSBPUyBBU2FuIExTYW4gVGVzdHMgKDEpLzI1NTMxL2Jyb3dzZXJfdGVzdHMvVjJWaWRtbGxkMUJ5YjNoNVFYVjBhRXh2WjJsdVZHVnpkQzVRY205NGVVRjFkR2hVY21GdWMyWmxjZz09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVy0wELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKcAWNocm9taXVtLm1hYy9NYWMxMC4xMiBUZXN0cy84MzIwL2NvbnRlbnRfdW5pdHRlc3RzIG9uIE1hYy0xMC4xMi9SbXhwYm1kRGIyNTBjbTlzYkdWeVZHVnpkQzVGWVhKc2VVWnNhVzVuUTJGdVkyVnNZWFJwYjI1UGJrbHVaWEowYVdGc1IxTlZRV05yVG05MFEyOXVjM1Z0WldRPQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM
,
Jan 8 2018
The root cause is when triggering a try job using the new services pipeline, 'None' is being explicitly passed as the revision parameter when creating a buildbucket_client.TryJob instance. For compile/test try jobs, the code that consumes the try_job instance detects this and falls back to the 'properties' parameter to search for 'bad_revision' and uses that instead. However for flake try jobs there is no 'bad_revision', only 'test_revision' Options: 1. When creating the build_bucket.TryJob instance, have the calling code supply revision. For compile/test, supply None (so the existing functionality is unchanged). For flake, supply the git_hash of the try job. 2. Also check for 'test_revision' in addition to 'bad_revision' 3. Pass 'bad_revision' or 'git_hash' explicitly instead of 'None'
,
Jan 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/9dc3c619f7363475e5c581bf48c81017bd33436c commit 9dc3c619f7363475e5c581bf48c81017bd33436c Author: Jeffrey Li <lijeffrey@google.com> Date: Mon Jan 08 23:15:03 2018 [Findit] Pass test_revision to flake try jobs Bug: 799102 Change-Id: I0049a5d9651b1eaf5c09204943a6b87bf2c1b149 Reviewed-on: https://chromium-review.googlesource.com/855037 Commit-Queue: Jeffrey Li <lijeffrey@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> [modify] https://crrev.com/9dc3c619f7363475e5c581bf48c81017bd33436c/appengine/findit/waterfall/swarming_util.py [modify] https://crrev.com/9dc3c619f7363475e5c581bf48c81017bd33436c/appengine/findit/waterfall/test/swarming_util_test.py
,
Jan 8 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/9dc3c619f7363475e5c581bf48c81017bd33436c commit 9dc3c619f7363475e5c581bf48c81017bd33436c Author: Jeffrey Li <lijeffrey@google.com> Date: Mon Jan 08 23:15:03 2018 [Findit] Pass test_revision to flake try jobs Bug: 799102 Change-Id: I0049a5d9651b1eaf5c09204943a6b87bf2c1b149 Reviewed-on: https://chromium-review.googlesource.com/855037 Commit-Queue: Jeffrey Li <lijeffrey@chromium.org> Reviewed-by: Shuotao Gao <stgao@chromium.org> [modify] https://crrev.com/9dc3c619f7363475e5c581bf48c81017bd33436c/appengine/findit/waterfall/swarming_util.py [modify] https://crrev.com/9dc3c619f7363475e5c581bf48c81017bd33436c/appengine/findit/waterfall/test/swarming_util_test.py
,
Jan 10 2018
,
Feb 9 2018
The following revision refers to this bug: https://chromium.googlesource.com/infra/infra/+/5d8951d92de087e486d9725b563f3462068e0a5d commit 5d8951d92de087e486d9725b563f3462068e0a5d Author: Shuotao Gao <stgao@chromium.org> Date: Fri Feb 09 17:34:45 2018 [Findit] Remove TryJob.revision to avoid confusion. Bug: 799102 Change-Id: Iff91b5cde3064da4699ced1d7517fe7e1624db20 Reviewed-on: https://chromium-review.googlesource.com/857538 Commit-Queue: Shuotao Gao <stgao@chromium.org> Reviewed-by: Roberto Carrillo <robertocn@chromium.org> [modify] https://crrev.com/5d8951d92de087e486d9725b563f3462068e0a5d/appengine/findit/common/waterfall/buildbucket_client.py [modify] https://crrev.com/5d8951d92de087e486d9725b563f3462068e0a5d/appengine/findit/common/waterfall/test/buildbucket_client_test.py [modify] https://crrev.com/5d8951d92de087e486d9725b563f3462068e0a5d/appengine/findit/handlers/periodic_bot_update.py |
|||
►
Sign in to add a comment |
|||
Comment 1 by lijeffrey@chromium.org
, Jan 4 2018