New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 799089 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Mar 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug

Blocking:
issue 799085



Sign in to add a comment

Chrome Testing Survey: Click to Open PDF

Project Member Reported by laforge@google.com, Jan 4 2018

Issue description

Test Planning
1. Does the feature need manual testing?
Yes.

2. Feature implementation status (what is currently working and not working/known issues, all the code landed in canary, ready for testing etc.)
Fully implemented, currently behind a flag (Jan 4, 2017).  We'll plan to enable it by default on trunk today.

3. Link to Design Doc:
https://docs.google.com/document/d/1-BTkjvsgRK6FqgKTjDPNMB79pOdiwnD-kzGObR6ekEM/edit?ts=5a4d4c79#heading=h.xgjl2srtytjt

4. Link to Test Plan:
https://docs.google.com/document/d/1-BTkjvsgRK6FqgKTjDPNMB79pOdiwnD-kzGObR6ekEM/edit?ts=5a4d4c79#heading=h.xeygfqamq9gw

5. Are there any special points of interest from a testing perspective?
No.

6. Link to demos (if any):  
NA

7. Targeted Platforms.
Chrome, Linux, Mac, Windows

8. Is the work flow same as desktop and mobile? (Answer if applicable to both Desktop and Mobile)
The placeholder appears on both desktop and mobile.

Automation
9. What's automated? (Unit tests, API tests, Browser tests)  Please provide links to automated tests.
We have unit tests here: https://cs.chromium.org/chromium/src/chrome/browser/plugins/pdf_iframe_navigation_throttle_unittest.cc

10. What’s not automated that needs manual testing?
The automated tests should provide good coverage, however having a final confirmation/ integration test would be valuable.

11. List reasons for still needing manual testing.
Final integration tests.

Feature-Component-Ownership Details
12. What is the crbug label/component for the feature?
Internals>Plugins>PDF

13. Are there any other team members or mailing lists that should be notified if issues are found?
tommycli

Stability
14. Is there a mechanism to turn off the feature if it breaks product functionality or performance?
Yes, Finch.

15. List the names of the finch studies and the experiment groups if any. What % rollout are you requesting for each group.
We plan to ship at 100% to all channels (i.e., standard waterfall roll-out).

16. How are you monitoring the stability of the experiment groups.
Via uma dashboard and checking https://crash.

Performance:
17. Any performance impact? Did the feature get tested on perf waterfall?
Should be no performance impact.

 

Comment 1 by laforge@google.com, Jan 4 2018

Blocking: 799085
Cc: ligim...@chromium.org
Status: Fixed (was: Assigned)
Flipping to Fixed since Launch-Testing-Yes on the main bug.

Sign in to add a comment