New issue
Advanced search Search tips

Issue 799083 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
finnur@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

|git drover| edits Gerrit CL to 1) add TBR to CL description, but 2) doesn't actually add reviewers

Project Member Reported by lukasza@chromium.org, Jan 4 2018 
This is a follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/847639#message-27bfffd31bf8be05f5b42a4587fc6e9756989cb4

REPRO STEPS:
1. Use |git drover| command to merge a CL

EXPECTED BEHAVIOR:
A. |git drover| creates a CL in Gerrit
B. Original reviewers are included on TBR line in the CL description 
C. Original reviewers are added to the Reviewers field of the CL

ACTUAL BEHAVIOR:
A. and B. work as expected
C. Doesn't happen

Comment 1 by aga...@chromium.org, Jan 4 2018

Components: -Infra>Git
Status: Available (was: Untriaged)
Fascinating, thanks for the heads-up. I'm not sure if this is endemic, or caused by some git-drover getting confused by the "Tbr: someone or someonelse" line in the original change's trailer paragraph. Will have to do some investigation, but probably won't get to this before other more-urgent changes.
Project Member

Comment 2 by sheriffbot@chromium.org, Jan 7

Labels: Hotlist-Recharge-Cold
Status: Untriaged (was: Available)
This issue has been Available for over a year. If it's no longer important or seems unlikely to be fixed, please consider closing it out. If it is important, please re-triage the issue.

Sorry for the inconvenience if the bug really should have been left as Available.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 3 by ehmaldonado@chromium.org, Jan 9

Status: Available (was: Untriaged)
►

Sign in to add a comment