New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 799080 link

Starred by 5 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----

Blocked on:
issue 799436
issue 799439



Sign in to add a comment

v8.browsing_mobile-future failing on multiple builders

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Jan 4 2018

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of charliea@chromium.org

v8.browsing_mobile-future failing on multiple builders

Both flaky and consistent failures seem to be happening across a wide range of builders. It looks like they've been happening for at least 11 days.

Some of the (many) failures with their associated failure rates:

Android One
- 100% browse:social:pinterest_infinite_scroll 
- 100% browse:social:facebook_infinite_scroll
- 15% browse:media:youtube

Nexus 7v2:
- 100% browse:news:cnn
- 15% browse:shopping:avito
- 15% browse:social:pinterest_infinite_scroll

Nexus 5X:
- 33% browse:social:tumblr_infinite_scroll

I'm going to submit a CL disabling anything with over a 10% failure rate or so.
 
Cc: u...@chromium.org mythria@chromium.org
Owner: charliea@chromium.org
Status: Assigned (was: Available)
CCing owners, disable in flight now.
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 4 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e5e85474e1201da8393a0c6cb109c5422efdab0f

commit e5e85474e1201da8393a0c6cb109c5422efdab0f
Author: Charlie Andrews <charliea@google.com>
Date: Thu Jan 04 18:19:41 2018

Disable consistently failing v8.browsing_mobile-future stories

TBR=nednguyen@google.com
CC=​mythria@chromium.org, ulan@chromium.org

NOTRY=true

Bug:  799080 
Change-Id: Ibdf38fd714074cb2f83dd57a91b873d0ea8f8c79
Reviewed-on: https://chromium-review.googlesource.com/850720
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527039}
[modify] https://crrev.com/e5e85474e1201da8393a0c6cb109c5422efdab0f/tools/perf/expectations.config

Owner: mythria@chromium.org
Assigning to owner now that the disable is complete.
I took a look at the failures on the android perf bot. Looks like the infinite_scroll pages (facebook_infinite_scroll, pinterest_infinite_scroll, tumblr_infinite_scroll) are failing with WebSocketUnreachable exception. I can also see them when running locally though with lesser frequency. Unfortunately, I don't have any further information on what has gone wrong, it looks like something has timedout since may be the device is slow?. I will try to have a look at these failures.

I also noticed other failures that I think are not related to the benchmark. There are several failures because the browser process could not start. This usually appears as a failure on Amazon page, which is the first story run on the benchmark. An example log here: https://logs.chromium.org/v/?s=chrome%2Fbb%2Fchromium.perf%2FAndroid_One_Perf%2F938%2F%2B%2Frecipes%2Fsteps%2Fv8.browsing_mobile-future.reference_on_Android%2F0%2Fstdout

A snippet from the above log:
(ERROR) 2018-01-03 08:29:59,025 browser.__init__:49  Failed with CommandTimeoutError while starting the browser backend.
(INFO) 2018-01-03 08:29:59,026 cmd_helper._ValidateAndLogCommand:160  [host]> /b/swarming/w/ir/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb -s AG860442028A4GC shell '( ps | grep -F com.google.android.apps.chrome; echo "PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'
(INFO) 2018-01-03 08:29:59,127 cmd_helper._ValidateAndLogCommand:160  [host]> /b/swarming/w/ir/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb -s AG860442028A4GC shell '( ps | grep -F com.google.android.apps.chrome; echo "PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'
(INFO) 2018-01-03 08:29:59,229 cmd_helper._ValidateAndLogCommand:160  [host]> /b/swarming/w/ir/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb -s AG860442028A4GC shell '( ps | grep -F com.google.android.apps.chrome; echo "PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'
(INFO) 2018-01-03 08:29:59,329 browser.Close:220  Browser is closed.
(ERROR) 2018-01-03 08:29:59,330 android_browser_finder.Create:141  Failed with CommandTimeoutError while creating Android browser.
(INFO) 2018-01-03 08:29:59,331 cmd_helper._ValidateAndLogCommand:160  [host]> /b/swarming/w/ir/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb -s AG860442028A4GC shell '( ps | grep -F com.google.android.apps.chrome; echo "PIPESTATUS: ${PIPESTATUS[@]}" );echo %$?'
(WARNING) 2018-01-03 08:29:59,431 shared_page_state.DumpStateUponFailure:128  Cannot dump browser state: No browser.
(INFO) 2018-01-03 08:29:59,433 cmd_helper._ValidateAndLogCommand:160  [host]> /b/swarming/w/ir/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb -s AG860442028A4GC shell '( /system/bin/screencap -p /data/local/tmp/temp_file-f1ca07597c641.png );echo %$?'
(INFO) 2018-01-03 08:29:59,932 cmd_helper._ValidateAndLogCommand:160  [host]> /b/swarming/w/ir/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb -s AG860442028A4GC pull /data/local/tmp/temp_file-f1ca07597c641.png /b/swarming/w/itpWwLIf/tmpgP_kNM.png
(INFO) 2018-01-03 08:30:00,108 cmd_helper._ValidateAndLogCommand:160  [host]> /b/swarming/w/ir/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb -s AG860442028A4GC shell 'rm -f /data/local/tmp/temp_file-f1ca07597c641.png'
(WARNING) 2018-01-03 08:30:00,135 artifact_results.AddArtifact:113  Moving artifact file '/b/swarming/w/itpWwLIf/tmpgP_kNM.png' to '/b/swarming/w/itpWwLIf/tmp0esBx5telemetry/artifacts'
Traceback (most recent call last):
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 117, in _RunStoryAndProcessErrorIfNeeded
    state.WillRunStory(story)
  File "/b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 232, in WillRunStory
    self._StartBrowser(page)
  File "/b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 196, in _StartBrowser
    self._browser = self._possible_browser.Create(finder_options_for_page)
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome/android_browser_finder.py", line 136, in Create
    browser_backend, self._platform_backend)
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/browser/browser.py", line 41, in __init__
    self._browser_backend.Start()
  File "/b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome/android_browser_backend.py", line 124, in Start
    blocking=True)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/android/decorators.py", line 57, in timeout_retry_wrapper
    retry_if_func=retry_if_func)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/timeout_retry.py", line 157, in Run
    error_log_func=error_log_func)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 186, in JoinAll
    self._JoinAll(watcher, timeout)
  File "/b/swarming/w/ir/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 151, in _JoinAll
    (len(alive_threads), len(self._threads)))
CommandTimeoutError: Timed out waiting for 1 of 1 threads.
(INFO) 2018-01-03 08:30:00,137 exception_formatter.PrintFormatt


There are also another set of failures that looks like are not related to this particular benchmark. For example failures on twitter in this log: https://logs.chromium.org/v/?s=chrome%2Fbb%2Fchromium.perf%2FAndroid_One_Perf%2F930%2F%2B%2Frecipes%2Fsteps%2Fv8.browsing_mobile-future_on_Android%2F0%2Fstdout


INFO) 2018-01-01 16:00:44,549 cmd_helper._ValidateAndLogCommand:160  [host]> /b/swarming/w/ir/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb -s AG860442028A4GC shell '( dumpsys battery reset );echo %$?'
(INFO) 2018-01-01 16:00:44,622 cmd_helper._ValidateAndLogCommand:160  [host]> /b/swarming/w/ir/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb -s AG860442028A4GC shell '( dumpsys battery );echo %$?'
(INFO) 2018-01-01 16:00:44,693 timeout_retry.WaitFor:105  condition 'battery_updates_enabled' met (0.1s)
(INFO) 2018-01-01 16:00:44,713 battery_utils.LetBatteryCoolToTemperature:558  Waiting for the device to cool down to 350 (0.1 C)
(INFO) 2018-01-01 16:00:44,714 cmd_helper._ValidateAndLogCommand:160  [host]> /b/swarming/w/ir/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb -s AG860442028A4GC shell '( dumpsys battery );echo %$?'
(INFO) 2018-01-01 16:00:44,815 battery_utils.cool_device:547  Current battery temperature: 260
(INFO) 2018-01-01 16:00:44,815 timeout_retry.WaitFor:105  condition 'cool_device' met
(INFO) 2018-01-01 16:00:44,821 webpagereplay_go_server.StartServer:222  Starting Web-Page-Replay: [u'/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/bin/linux/x86_64/wpr', 'replay', '--http_port=0', '--https_port=0', '--https_key_file=/b/swarming/w/ir/third_party/catapult/web_page_replay_go/wpr_key.pem', '--https_cert_file=/b/swarming/w/ir/third_party/catapult/web_page_replay_go/wpr_cert.pem', '--inject_scripts=/b/swarming/w/ir/third_party/catapult/web_page_replay_go/deterministic.js', u'/b/swarming/w/ir/tools/perf/page_sets/data/system_health_mobile_023.wprgo']
(INFO) 2018-01-01 16:00:45,033 webpagereplay_go_server.StartServer:230  WPR ports: {'http': 55085, 'https': 46463}
(INFO) 2018-01-01 16:00:45,034 ts_proxy_server._IssueCommand:97  Issuing command to ts_proxy_server: set mapports 443:46463,*:55085
(INFO) 2018-01-01 16:00:45,036 browser.DumpStateUponFailure:339  *************** BROWSER STANDARD OUTPUT ***************
(INFO) 2018-01-01 16:00:45,036 browser.DumpStateUponFailure:341  Cannot get standard output on Android
(INFO) 2018-01-01 16:00:45,036 browser.DumpStateUponFailure:344  *********** END OF BROWSER STANDARD OUTPUT ************
(INFO) 2018-01-01 16:00:45,037 browser.DumpStateUponFailure:346  ********************* BROWSER LOG *********************
(INFO) 2018-01-01 16:00:45,037 browser.DumpStateUponFailure:348  No log file
(INFO) 2018-01-01 16:00:45,037 browser.DumpStateUponFailure:351  ***************** END OF BROWSER LOG ******************
(INFO) 2018-01-01 16:00:45,038 cmd_helper._ValidateAndLogCommand:160  [host]> /b/swarming/w/ir/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb -s AG860442028A4GC shell '( /system/bin/screencap -p /data/local/tmp/temp_file-ec08ae4dded62.png );echo %$?'
(INFO) 2018-01-01 16:00:45,624 cmd_helper._ValidateAndLogCommand:160  [host]> /b/swarming/w/ir/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb -s AG860442028A4GC pull /data/local/tmp/temp_file-ec08ae4dded62.png /b/swarming/w/itasknq7/tmpYeb0qC.png
(INFO) 2018-01-01 16:00:45,808 cmd_helper._ValidateAndLogCommand:160  [host]> /b/swarming/w/ir/third_party/catapult/devil/bin/deps/linux2/x86_64/bin/adb -s AG860442028A4GC shell 'rm -f /data/local/tmp/temp_file-ec08ae4dded62.png'
(WARNING) 2018-01-01 16:00:45,840 artifact_results.AddArtifact:113  Moving artifact file '/b/swarming/w/itasknq7/tmpYeb0qC.png' to '/b/swarming/w/itasknq7/tmpLV1vJCtelemetry/artifacts'
Traceback (most recent call last):
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 117, in _RunStoryAndProcessErrorIfNeeded
    state.WillRunStory(story)
  File "/b/swarming/w/ir/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 75, in traced_function
    return func(*args, **kwargs)
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/page/shared_page_state.py", line 235, in WillRunStory
    if len(self.browser.tabs) == 0:
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/browser/tab_list.py", line 15, in __len__
    return self._tab_list_backend.__len__()
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend_list.py", line 95, in __len__
    self._Update()
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_backend_list.py", line 99, in _Update
    backends_map = self._devtools_client.GetUpdatedInspectableContexts()
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py", line 372, in GetUpdatedInspectableContexts
    contexts = self._ListInspectableContexts()
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py", line 297, in _ListInspectableContexts
    return self._devtools_http.RequestJson('')
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/devtools_http.py", line 107, in RequestJson
    return json.loads(self.Request(path, timeout))
  File "/b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/devtools_http.py", line 88, in Request
    response = self._conn.getresponse()
  File "/usr/lib/python2.7/httplib.py", line 1136, in getresponse
    response.begin()
  File "/usr/lib/python2.7/httplib.py", line 453, in begin
    version, status, reason = self._read_status()
  File "/usr/lib/python2.7/httplib.py", line 409, in _read_status
    line = self.fp.readline(_MAXLINE + 1)
  File "/usr/lib/python2.7/socket.py", line 480, in readline
    data = self._sock.recv(self._rbufsize)
DevToolsClientConnectionError: [Errno 104] Connection reset by peer
(INFO) 2018-01-01 16:00:45,856 exception_formatter.PrintFormattedException:19  Try printing formatted exception: None None None
Exception raised when cleaning story run: 
Traceback (most recent call last):
  _RunStoryAndProcessErrorIfNeeded at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/story_runner.py:150
    test.DidRunStory(state.platform, results)
  DidRunStory at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/web_perf/timeline_based_measurement.py:290
    trace_result, _ = platform.tracing_controller.StopTracing()
  StopTracing at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/core/tracing_controller.py:53
    return self._tracing_controller_backend.StopTracing()
  StopTracing at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/platform/tracing_controller_backend.py:109
    self._IssueClockSyncMarker()
  _IssueClockSyncMarker at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/platform/tracing_controller_backend.py:215
    self._RecordIssuerClockSyncMarker)
  RecordClockSyncMarker at /b/swarming/w/ir/third_party/catapult/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py:178
    raise ChromeClockSyncError('Cannot issue clock sync. No devtools clients')
ChromeClockSyncError: Cannot issue clock sync. No devtools clients
Cc: hablich@chromium.org
Labels: v8-benchmarks
In summary, I think there are three different kinds of failures:

1. Failures on infinite scroll pages (with a WebSocketConnectionClosedException). I suspect this is because it is timing out somewhere. This also reproducible (flakily) locally. I will try to have a look into it.

2. Failure to start a browser process. This appears as a failure on amazon page which is the first page of the benchmark. It happens quite often on the reference builds and also sometimes on the non reference build. I will file another bug for this.

3. Failures on twitter, qq (4 times out of the 30 builds so not very frequent) with a ChromeClockSyncError. I am not sure what is wrong here, and these failures are not reproducible locally. I will also file another bug for this.
Blockedon: 799436
Blockedon: 799439
Since the failures are mostly on infinite scroll and youtube, and few on twitter and qq how about disabling those stories and enabling the benchmark for other pages while we debug these issues. If it turns out that other stories are flaky too, then we can disable them again.
The stack trace that I get locally for the infinite scroll pages:

Traceback (most recent call last):
  File "/usr/local/google/code/clankium/src/third_party/catapult/telemetry/telemetry/internal/story_runner.py", line 127, in _RunStoryAndProcessErrorIfNeeded
    test.Measure(state.platform, results)
  File "/usr/local/google/code/clankium/src/third_party/catapult/telemetry/telemetry/web_perf/timeline_based_measurement.py", line 261, in Measure
    trace_result, _ = platform.tracing_controller.StopTracing()
  File "/usr/local/google/code/clankium/src/third_party/catapult/telemetry/telemetry/core/tracing_controller.py", line 53, in StopTracing
    return self._tracing_controller_backend.StopTracing()
  File "/usr/local/google/code/clankium/src/third_party/catapult/telemetry/telemetry/internal/platform/tracing_controller_backend.py", line 140, in StopTracing
    '\n'.join(raised_exception_messages))
TracingException: Exceptions raised when trying to stop tracing:
Traceback (most recent call last):
  File "/usr/local/google/code/clankium/src/third_party/catapult/telemetry/telemetry/internal/platform/tracing_controller_backend.py", line 128, in StopTracing
    agent.CollectAgentTraceData(builder)
  File "/usr/local/google/code/clankium/src/third_party/catapult/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py", line 250, in CollectAgentTraceData
    '\n'.join(raised_exception_messages))
ChromeTracingStoppedError: Exceptions raised when trying to collect Chrome devtool tracing:
Error when collecting Chrome tracing on devtools at port localabstract:chrome_devtools_remote:
Traceback (most recent call last):
  File "/usr/local/google/code/clankium/src/third_party/catapult/telemetry/telemetry/internal/platform/tracing_agent/chrome_tracing_agent.py", line 239, in CollectAgentTraceData
    client.CollectChromeTracingData(trace_data_builder)
  File "/usr/local/google/code/clankium/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/devtools_client_backend.py", line 458, in CollectChromeTracingData
    self._tracing_backend.CollectTraceData(trace_data_builder, timeout)
  File "/usr/local/google/code/clankium/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py", line 231, in CollectTraceData
    self._CollectTracingData(trace_data_builder, timeout)
  File "/usr/local/google/code/clankium/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py", line 259, in _CollectTracingData
    traceback.format_exc())
TracingUnrecoverableException: Exception raised while collecting tracing data:
Traceback (most recent call last):
  File "/usr/local/google/code/clankium/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/tracing_backend.py", line 252, in _CollectTracingData
    self._inspector_websocket.DispatchNotifications(timeout)
  File "/usr/local/google/code/clankium/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket.py", line 140, in DispatchNotifications
    self._Receive(timeout)
  File "/usr/local/google/code/clankium/src/third_party/catapult/telemetry/telemetry/internal/backends/chrome_inspector/inspector_websocket.py", line 155, in _Receive
    data = self._socket.recv()
  File "/usr/local/google/code/clankium/src/third_party/catapult/telemetry/third_party/websocket-client/websocket/_core.py", line 293, in recv
    opcode, data = self.recv_data()
  File "/usr/local/google/code/clankium/src/third_party/catapult/telemetry/third_party/websocket-client/websocket/_core.py", line 310, in recv_data
    opcode, frame = self.recv_data_frame(control_frame)
  File "/usr/local/google/code/clankium/src/third_party/catapult/telemetry/third_party/websocket-client/websocket/_core.py", line 323, in recv_data_frame
    frame = self.recv_frame()
  File "/usr/local/google/code/clankium/src/third_party/catapult/telemetry/third_party/websocket-client/websocket/_core.py", line 357, in recv_frame
    return self.frame_buffer.recv_frame()
  File "/usr/local/google/code/clankium/src/third_party/catapult/telemetry/third_party/websocket-client/websocket/_abnf.py", line 336, in recv_frame
    self.recv_header()
  File "/usr/local/google/code/clankium/src/third_party/catapult/telemetry/third_party/websocket-client/websocket/_abnf.py", line 286, in recv_header
    header = self.recv_strict(2)
  File "/usr/local/google/code/clankium/src/third_party/catapult/telemetry/third_party/websocket-client/websocket/_abnf.py", line 371, in recv_strict
    bytes_ = self.recv(min(16384, shortage))
  File "/usr/local/google/code/clankium/src/third_party/catapult/telemetry/third_party/websocket-client/websocket/_core.py", line 427, in _recv
    return recv(self.sock, bufsize)
  File "/usr/local/google/code/clankium/src/third_party/catapult/telemetry/third_party/websocket-client/websocket/_socket.py", line 93, in recv
    "Connection is already closed.")
WebSocketConnectionClosedException: Connection is already closed.
Cc: perezju@chromium.org
The call stack in #12 shows that the error happens during     self._CollectTracingData(trace_data_builder, timeout), so the cause is pretty likely due to problems receiving a very large trace.

Not sure if we have any good alternative for that at the moment? Maybe it's ok to keep the infinite_scroll stories disabled on this benchmark?
Project Member

Comment 15 by bugdroid1@chromium.org, Jan 5 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b7adce80f653fb2fabd370f1e9353500d7ffa89

commit 5b7adce80f653fb2fabd370f1e9353500d7ffa89
Author: Charlie Andrews <charliea@chromium.org>
Date: Fri Jan 05 19:48:18 2018

Disable v8.browsing_mobile/browse:news:cnn on Nexus 7v2

I disabled it in the "future" stories yesterday, but missed that we were
experiencing the same failures on v8.browsing_mobile.

NOTRY=true
TBR=perezju@chromium.org, mythria@chromium.org

Bug:  799080 
Change-Id: I577b7912e21858e82747afa482a0077904a9076d
Reviewed-on: https://chromium-review.googlesource.com/852933
Reviewed-by: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527352}
[modify] https://crrev.com/5b7adce80f653fb2fabd370f1e9353500d7ffa89/tools/perf/expectations.config

Project Member

Comment 16 by bugdroid1@chromium.org, Jan 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7463caf8b95a8e1a70021aace0bab4a82f909946

commit 7463caf8b95a8e1a70021aace0bab4a82f909946
Author: Mythri Alle <mythria@chromium.org>
Date: Mon Jan 08 12:35:04 2018

Enable v8.browsing_mobile-future benchmark on Android one

Disable facebook_infinite_scroll and pinterest_infinite_scroll
that are consistently failing on android one perf bot. Enable
the v8.browsing_mobile-future on Android one.

Bug:  chromium:799439 ,  chromium:799080 
Change-Id: I72d59336c35387cba927b2ff89f38929cb2e749c
Reviewed-on: https://chromium-review.googlesource.com/852492
Reviewed-by: Juan Antonio Navarro PΓ©rez <perezju@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527614}
[modify] https://crrev.com/7463caf8b95a8e1a70021aace0bab4a82f909946/tools/perf/expectations.config

Cc: ashleymarie@google.com
 Issue 803870  has been merged into this issue.
I have disabled the infinite scroll stories. Though the real issue is that we cannot handle large traces yet. Is there a bug to track that already? Should we keep this bug open or create another one to track that? 

Juan, any suggestions?
Cc: nedngu...@google.com
+nednguyen see #18, do we already have a bug for that?
The bug that I knew about wrt. large traces was fixed a while ago, where Javascript was unable to handle traces that were larger than 50MB or so because they violated the ~250k string length limit when unzipped.

I'm not sure what step this is breaking at now, and it would probably take some time to investigate. It looks like Telemetry is struggling to handle this large of a trace. Even if this wasn't the case, I think that this trace is likely to take a very long time to load into trace viewer.

One major problem seems to be that the most common type of trace events, toplevel, occur _very_ frequently (O(thousands/second)) and it's not unusual for each to take up 100-120 bytes. In a large trace of around ~250MB, it's not unusual for something like a third to half of those events to be toplevel events like task_runner.RunTask which is one of the most useful events for people to see when they open a trace. That being said, we just don't have a concise way to store it.

All of this goes back to Perfetto / tracing v2, which is still a ways out.
Project Member

Comment 21 by bugdroid1@chromium.org, Jan 30 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8ff58008d07deab081151db0497adb97488dc4f1

commit 8ff58008d07deab081151db0497adb97488dc4f1
Author: Mythri Alle <mythria@chromium.org>
Date: Tue Jan 30 16:50:28 2018

Disable youtube on v8.browsing-mobile and v8.browsing-mobile-future.

Bug:  chromium:799080 ,  chromium:804828 
Change-Id: Ia53c46840b47086dd55f989d190b063af54eb2a4
Reviewed-on: https://chromium-review.googlesource.com/892442
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#532915}
[modify] https://crrev.com/8ff58008d07deab081151db0497adb97488dc4f1/tools/perf/expectations.config

Cc: pmeenan@chromium.org altimin@chromium.org jbudorick@chromium.org
 Issue 788797  has been merged into this issue.
 Issue 804828  has been merged into this issue.
Project Member

Comment 24 by 42576172...@developer.gserviceaccount.com, Mar 15 2018

πŸ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/10406bf6440000
Project Member

Comment 25 by 42576172...@developer.gserviceaccount.com, Mar 15 2018

πŸ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/15a76461440000
Project Member

Comment 26 by 42576172...@developer.gserviceaccount.com, Mar 15 2018

πŸ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/11b4e12e440000
Project Member

Comment 27 by 42576172...@developer.gserviceaccount.com, Mar 15 2018

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/11b4e12e440000
Project Member

Comment 28 by 42576172...@developer.gserviceaccount.com, Mar 15 2018

πŸ“ Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/10406bf6440000
Project Member

Comment 29 by 42576172...@developer.gserviceaccount.com, Mar 15 2018

πŸ“ Couldn't reproduce a difference.
https://pinpoint-dot-chromeperf.appspot.com/job/15a76461440000
Project Member

Comment 30 by 42576172...@developer.gserviceaccount.com, Mar 16 2018

πŸ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/16144abe440000
Project Member

Comment 31 by 42576172...@developer.gserviceaccount.com, Mar 16 2018

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/16144abe440000
Project Member

Comment 32 by 42576172...@developer.gserviceaccount.com, Mar 16 2018

πŸ“ Pinpoint job started.
https://pinpoint-dot-chromeperf.appspot.com/job/17dba5fe440000
Project Member

Comment 33 by 42576172...@developer.gserviceaccount.com, Mar 16 2018

😿 Pinpoint job stopped with an error.
https://pinpoint-dot-chromeperf.appspot.com/job/17dba5fe440000
Cc: dtu@chromium.org
+dtu@chromium.org

Dave, it looks like there's some internal pinpoint error happening here w/ buildbucket: any idea what's going on?

Comment 35 by dtu@chromium.org, Mar 16 2018

Ah, sorry, try jobs are not working on webview right now.
https://github.com/catapult-project/catapult/issues/4224
Project Member

Comment 36 by bugdroid1@chromium.org, Mar 27 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2c1de00e850243f7cb374b698cf80d8fd2042d84

commit 2c1de00e850243f7cb374b698cf80d8fd2042d84
Author: Mythri Alle <mythria@chromium.org>
Date: Tue Mar 27 11:44:25 2018

Enable stories on v8.browsing_mobile-future and v8.browsing_mobile.

When investigating failures due to handling of large traces,
we disabled some of the pages on v8.browsing_mobile benchmarks.
Some of these are enabled later on v8.browsing_mobile but not
on v8.browsing_mobile-future. Enabling them now.

BUG= chromium:799080 

Change-Id: I8b25464be3f01d71d1b3cce07e0c66db8b0b5427
Reviewed-on: https://chromium-review.googlesource.com/962244
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Michael Hablich <hablich@chromium.org>
Commit-Queue: Mythri Alle <mythria@chromium.org>
Cr-Commit-Position: refs/heads/master@{#546081}
[modify] https://crrev.com/2c1de00e850243f7cb374b698cf80d8fd2042d84/tools/perf/expectations.config

Cc: -pmeenan@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment