Issue metadata
Sign in to add a comment
|
WPT import: [ Skip ] lines are removed when tests need to be rebaselined |
||||||||||||||||||||||||
Issue descriptionWPT imports are currently blocked because win7_chromium_rel_ng is failing on external/wpt/service-workers/service-worker/navigation-redirect.https.html. This test used to be Skipped on Windows, but the WPT import code is: * Dropping the [ Skip ] line from TestExpectations * Updating the test's expectations only on Linux and Mac, as if Windows was still being skipped. Either the [ Skip ] line must remain untouched, or the WPT code must rebaseline after identifying that Windows is no longer skipped and deduplicate the expectations.
,
Jan 4 2018
I think I would expect it to leave the Skip line untouched. This might be a bug in rebaseline.py (https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/tool/commands/rebaseline.py?l=383).
,
Jan 4 2018
Looking. Bumping to P1 as it's blocking import and might also represent a new category of failures.
,
Jan 4 2018
,
Jan 5 2018
Thank you all very much! I'm working for a manual import. |
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by raphael....@intel.com
, Jan 4 2018