New issue
Advanced search Search tips

Issue 799074 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Feb 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Proj-XR

Blocked on:
issue 792218



Sign in to add a comment

VR: Deprecate UMA histogram VR.Component.Assets.DurationUntilReady.OnChromeStart

Project Member Reported by tiborg@chromium.org, Jan 4 2018

Issue description

VR.Component.Assets.DurationUntilReady.OnChromeStart measures the duration between launching Chrome and the assets component being ready to use. It is intended to give an indication how long it takes to update the component. It is based on the assumption that the component is always registered at Chrome start which is not the case for non-VR users. Thus, it makes more sense to measure the duration between registering the component until it is ready to use (see  issue 792218 ).

Make VR.Component.Assets.DurationUntilReady.OnChromeStart obsolete once we measure the duration until ready on component register.
 
Status: Started (was: Assigned)
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 6 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e11c44872a249262d4babb664f62b3aee1505a93

commit e11c44872a249262d4babb664f62b3aee1505a93
Author: Tibor Goldschwendt <tiborg@chromium.org>
Date: Tue Feb 06 23:14:43 2018

[vr] Deprecate VR.Component.Assets.DurationUntilReady.OnChromeStart

Bug:  799074 
Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_vr;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I06c20525b10187804949ed9bed7485e483802d15
Reviewed-on: https://chromium-review.googlesource.com/903047
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Reviewed-by: David Dorwin <ddorwin@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#534827}
[modify] https://crrev.com/e11c44872a249262d4babb664f62b3aee1505a93/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java
[modify] https://crrev.com/e11c44872a249262d4babb664f62b3aee1505a93/chrome/browser/android/vr_shell/vr_shell_delegate.cc
[modify] https://crrev.com/e11c44872a249262d4babb664f62b3aee1505a93/chrome/browser/vr/metrics_helper.cc
[modify] https://crrev.com/e11c44872a249262d4babb664f62b3aee1505a93/chrome/browser/vr/metrics_helper.h
[modify] https://crrev.com/e11c44872a249262d4babb664f62b3aee1505a93/tools/metrics/histograms/histograms.xml

Status: Fixed (was: Started)
Labels: Test-Complete
Components: Internals>XR

Sign in to add a comment