mus: Test event latency without support_lazy_initialization on window service mojo methods |
|||
Issue descriptionFor issue 798800 I turned on support_lazy_initialization for window service mojo methods, which means they don't do IPC serialization while the window service runs in the browser process. In theory this makes things faster. However, it causes a 130KB code size increase. It's theoretically possible this will consume more instruction cache, so it would be good to test if it actually improves latency. Once we have latency metrics, comment out the lines in the //services/ui BUILD.gn files and test the impact. Blocking on the metrics bugs.
,
Apr 24 2018
Migrating Proj-Mustash-Mus to components Internals>Services>WindowService and Internals>Services>Ash
,
May 25 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7855923f7dd1510813a39fafbf299a9488f2c68e commit 7855923f7dd1510813a39fafbf299a9488f2c68e Author: James Cook <jamescook@chromium.org> Date: Fri May 25 22:32:51 2018 chromeos: Remove lazy serialization from window service mojo methods This saves 140 KB of chrome binary size on 64-bit Intel. Previously for --enable-features=Mus we were running the window service on a background thread in the browser process, so it was slightly more efficient to use lazy serialization for mojo calls. We have eliminated the "Mus" config and with ws2 the window service mojo implementations will be directly implemented in the "ash" service/process. All mojo calls will be cross-process, so there's no advantage to using lazy serialization. This is a revert of: https://chromium-review.googlesource.com/c/chromium/src/+/849657 Bug: 798800 , 799072 Test: bots Change-Id: I3f1ffe0e598e6bee7d3a54f41ffbbce23fd592e6 Reviewed-on: https://chromium-review.googlesource.com/1072460 Reviewed-by: Xiyuan Xia <xiyuan@chromium.org> Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#562040} [modify] https://crrev.com/7855923f7dd1510813a39fafbf299a9488f2c68e/services/ui/public/interfaces/BUILD.gn [modify] https://crrev.com/7855923f7dd1510813a39fafbf299a9488f2c68e/services/ui/public/interfaces/ime/BUILD.gn
,
May 25 2018
Obsolete. |
|||
►
Sign in to add a comment |
|||
Comment 1 by lafo...@chromium.org
, Feb 26 2018