These suppressions are necessary as we remove tools-lint in issue 798833
Will file android_webview bugs against the new suppressions introduced in https://crrev.com/c/857694.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/60990c11cee109af3dbe79fa2423362ed706dbcd commit 60990c11cee109af3dbe79fa2423362ed706dbcd Author: Peter Wen <wnwen@chromium.org> Date: Mon Jan 15 15:46:08 2018 Android: Prepare to remove tools-lint Use tools/bin/lint instead of tools-lint/bin/lint as it is updated. Effectively this moves lint from 25.3.2 to 26.0.0. BUG= 798833 , 799070 TBR=torne@chromium.org,mdjones@chromium.org,jrummell@chromium.org,alexmos@chromium.org,lambroslambrou@chromium.org,nyquist@chromium.org Change-Id: Ic3e67694d8b19d2a0e7d33a9594e9dc3d9db0223 Reviewed-on: https://chromium-review.googlesource.com/857694 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by: Peter Wen <wnwen@chromium.org> Reviewed-by: John Rummell <jrummell@chromium.org> Reviewed-by: Matthew Jones <mdjones@chromium.org> Reviewed-by: Alex Moshchuk <alexmos@chromium.org> Reviewed-by: Changwan Ryu <changwan@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#529287} [modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/android_webview/glue/java/src/com/android/webview/chromium/WebViewContentsClientAdapter.java [modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegateAdapter.java [modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/build/android/lint/suppressions.xml [modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/build/config/android/internal_rules.gni [modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/chrome/android/java/AndroidManifest.xml [modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/chrome/android/java/src/org/chromium/chrome/browser/SSLClientCertificateRequest.java [modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateTabLayout.java [modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/chrome/android/java/src/org/chromium/chrome/browser/ssl/CaptivePortalHelper.java [modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/chrome/android/java/src/org/chromium/chrome/browser/survey/ChromeHomeSurveyController.java [modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/chrome/android/javatests/src/org/chromium/chrome/browser/crash/LogcatExtractionRunnableTest.java [modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/chrome/android/javatests/src/org/chromium/chrome/browser/crash/MinidumpUploadServiceTest.java [modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java [modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkVerifySignature.java [modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/chrome/android/webapk/shell_apk/shell_apk_version.gni [modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/WebApkSandboxedProcessService.java [modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/chrome/test/android/javatests/src/org/chromium/chrome/test/util/ApplicationTestUtils.java [modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/components/background_task_scheduler/android/java/src/org/chromium/components/background_task_scheduler/BackgroundTaskJobService.java [modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncherHelper.java [modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/content/public/android/java/src/org/chromium/content/browser/ContentView.java [modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java [modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/content/shell/android/java/src/org/chromium/content_shell/Shell.java [modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java [modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/media/base/android/java/src/org/chromium/media/MediaPlayerBridge.java [modify] https://crrev.com/60990c11cee109af3dbe79fa2423362ed706dbcd/remoting/android/java/src/org/chromium/chromoting/HostListAdapter.java
#1 fixed by filing issue 804422
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3955da70d67e9e6018208b9f7f89f92d803cfe40 commit 3955da70d67e9e6018208b9f7f89f92d803cfe40 Author: Peter Wen <wnwen@chromium.org> Date: Wed Jan 24 18:42:31 2018 Android: Update suppressions and fix NewApi Now that separate bugs have been filed to fix lint suppressions the code should be updated accordingly. Unforunately the NewApi suppression was wrongly added and allowed a whole bunch of failures into the codebase in a matter of days. Fixing that in this CL. BUG= 799070 , 804449 , 804438 , 805509 TBR=bauerb@chromium.org,michaelbai@chromium.org Change-Id: I22222837a70da3680a5968e7e002862ecdf12d04 Reviewed-on: https://chromium-review.googlesource.com/884004 Reviewed-by: agrieve <agrieve@chromium.org> Reviewed-by: Peter Beverloo <peter@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#531622} [modify] https://crrev.com/3955da70d67e9e6018208b9f7f89f92d803cfe40/build/android/lint/suppressions.xml [modify] https://crrev.com/3955da70d67e9e6018208b9f7f89f92d803cfe40/chrome/android/java/src/org/chromium/chrome/browser/notifications/NotificationPlatformBridge.java [modify] https://crrev.com/3955da70d67e9e6018208b9f7f89f92d803cfe40/chrome/android/java/src/org/chromium/chrome/browser/preferences/password/SavePasswordsPreferences.java [modify] https://crrev.com/3955da70d67e9e6018208b9f7f89f92d803cfe40/tools/android/memconsumer/java/AndroidManifest.xml
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/78988928ff8dd13b8fd16017c617ee5ad76c7cd8 commit 78988928ff8dd13b8fd16017c617ee5ad76c7cd8 Author: Peter Wen <wnwen@chromium.org> Date: Mon Jan 29 15:16:52 2018 Android: Remove unused strings Update suppressions from android_tools upgrades resulting in unused resources (mostly strings) being left behind after their feature is removed. Also update some suppressions as expected. BUG= 799070 , 806060 TBR=nyquist@chromium.org Change-Id: I30d35320ad20b318a921972529f139b3b3e65453 Reviewed-on: https://chromium-review.googlesource.com/886863 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by: Peter Wen <wnwen@chromium.org> Reviewed-by: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#532433} [modify] https://crrev.com/78988928ff8dd13b8fd16017c617ee5ad76c7cd8/build/android/lint/suppressions.xml [modify] https://crrev.com/78988928ff8dd13b8fd16017c617ee5ad76c7cd8/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/78988928ff8dd13b8fd16017c617ee5ad76c7cd8/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/78988928ff8dd13b8fd16017c617ee5ad76c7cd8/chrome/test/android/javatests/src/org/chromium/chrome/test/util/TranslateUtil.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4719ef1a70a4f19bf8546d124e684074450f5985 commit 4719ef1a70a4f19bf8546d124e684074450f5985 Author: Peter Wen <wnwen@chromium.org> Date: Mon Jan 29 16:42:04 2018 Revert "Android: Remove unused strings" This reverts commit 78988928ff8dd13b8fd16017c617ee5ad76c7cd8. Reason for revert: Broke clank downstream unused resources Original change's description: > Android: Remove unused strings > > Update suppressions from android_tools upgrades resulting in unused > resources (mostly strings) being left behind after their feature is > removed. > > Also update some suppressions as expected. > > BUG= 799070 , 806060 > TBR=nyquist@chromium.org > > Change-Id: I30d35320ad20b318a921972529f139b3b3e65453 > Reviewed-on: https://chromium-review.googlesource.com/886863 > Commit-Queue: Peter Wen <wnwen@chromium.org> > Reviewed-by: Peter Wen <wnwen@chromium.org> > Reviewed-by: Theresa <twellington@chromium.org> > Cr-Commit-Position: refs/heads/master@{#532433} TBR=nyquist@chromium.org,wnwen@chromium.org,twellington@chromium.org Change-Id: I0681082ac3fdfe80d1ad6f3ba182e81f75678dce No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 799070 , 806060 Reviewed-on: https://chromium-review.googlesource.com/890660 Reviewed-by: Peter Wen <wnwen@chromium.org> Commit-Queue: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#532458} [modify] https://crrev.com/4719ef1a70a4f19bf8546d124e684074450f5985/build/android/lint/suppressions.xml [modify] https://crrev.com/4719ef1a70a4f19bf8546d124e684074450f5985/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/4719ef1a70a4f19bf8546d124e684074450f5985/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/4719ef1a70a4f19bf8546d124e684074450f5985/chrome/test/android/javatests/src/org/chromium/chrome/test/util/TranslateUtil.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/694bf0eb3c5de0a290054716b548e4cadf9284ee commit 694bf0eb3c5de0a290054716b548e4cadf9284ee Author: Peter Wen <wnwen@chromium.org> Date: Mon Jan 29 18:54:57 2018 Reland "Android: Remove unused strings" Original CL: https://chromium-review.googlesource.com/886863 Fix: - Suppress unused resources for clank/ widgets BUG= 799070 , 806060 TBR=nyquist@chromium.org,twellington@chromium.org Change-Id: Id42c5a626f4a0754bea3d4db7a10af9756c0002d Reviewed-on: https://chromium-review.googlesource.com/891339 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#532516} [modify] https://crrev.com/694bf0eb3c5de0a290054716b548e4cadf9284ee/build/android/lint/suppressions.xml [modify] https://crrev.com/694bf0eb3c5de0a290054716b548e4cadf9284ee/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/694bf0eb3c5de0a290054716b548e4cadf9284ee/chrome/android/java/strings/android_chrome_strings.grd [modify] https://crrev.com/694bf0eb3c5de0a290054716b548e4cadf9284ee/chrome/test/android/javatests/src/org/chromium/chrome/test/util/TranslateUtil.java
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/7a2ea9742208c6e3393783d3c056bd8c6d75b5da commit 7a2ea9742208c6e3393783d3c056bd8c6d75b5da Author: Peter Wen <wnwen@chromium.org> Date: Wed Jan 31 21:12:54 2018 Android: File bugs for remaining lint errors These suppressions were leftover from the last lint upgrade from 25.3.2 to 26.0.0. Now bugs have been filed and comments updated from tracking bug. TBR=dalecurtis@chromium.org,mdjones@chromium.org,tedchoc@chromium.org,sdefresne@chromium.org Bug: 799070 Change-Id: I30ad7a7c9e2494e8c246b0d76968a1f6902f8aa7 Reviewed-on: https://chromium-review.googlesource.com/895814 Commit-Queue: Peter Wen <wnwen@chromium.org> Reviewed-by: agrieve <agrieve@chromium.org> Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#533411} [modify] https://crrev.com/7a2ea9742208c6e3393783d3c056bd8c6d75b5da/build/android/lint/suppressions.xml [modify] https://crrev.com/7a2ea9742208c6e3393783d3c056bd8c6d75b5da/chrome/android/java/src/org/chromium/chrome/browser/SSLClientCertificateRequest.java [modify] https://crrev.com/7a2ea9742208c6e3393783d3c056bd8c6d75b5da/chrome/android/java/src/org/chromium/chrome/browser/infobar/translate/TranslateTabLayout.java [modify] https://crrev.com/7a2ea9742208c6e3393783d3c056bd8c6d75b5da/chrome/android/java/src/org/chromium/chrome/browser/survey/ChromeHomeSurveyController.java [modify] https://crrev.com/7a2ea9742208c6e3393783d3c056bd8c6d75b5da/components/background_task_scheduler/android/java/src/org/chromium/components/background_task_scheduler/BackgroundTaskJobService.java [modify] https://crrev.com/7a2ea9742208c6e3393783d3c056bd8c6d75b5da/content/public/android/java/src/org/chromium/content/browser/ChildProcessLauncherHelper.java [modify] https://crrev.com/7a2ea9742208c6e3393783d3c056bd8c6d75b5da/content/public/android/java/src/org/chromium/content/browser/ContentView.java [modify] https://crrev.com/7a2ea9742208c6e3393783d3c056bd8c6d75b5da/content/shell/android/java/src/org/chromium/content_shell/Shell.java [modify] https://crrev.com/7a2ea9742208c6e3393783d3c056bd8c6d75b5da/media/base/android/java/src/org/chromium/media/MediaCodecBridge.java
Comment 1 by wnwen@chromium.org
, Jan 11 2018