New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 799050 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

No Client Hints in Chrome 64 or 65

Reported by johannes...@sevenval.com, Jan 4 2018

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3310.0 Safari/537.36

Example URL:
http://waldbaer.leute.server.de/ch-bugs/

Steps to reproduce the problem:
1. Load given URL
2. See response headers in Network tab of developer tools

What is the expected behavior?
I would expect headers DPR and Viewport-Width for ext.css and ext.js

What went wrong?
No client hints response headers in Chrome 65 canary, Opera 51 developer edition (based on Chrome 64)

Did this work before? Yes Chrome 63

Chrome version: 65.0.3310.0  Channel: canary
OS Version: 10.0
Flash Version:
 
Labels: Needs-Bisect Needs-Triage-M65
Components: Blink>Loader Blink>HTML
Labels: -Pri-2 -Needs-Bisect hasbisect-per-revision ReleaseBlock-Stable Triaged-ET M-64 OS-Linux OS-Mac Pri-1
Owner: tbansal@chromium.org
Status: Assigned (was: Unconfirmed)
Able to reproduce the issue on Windows 10, mac 10.12.6 and Ubuntu 14.04 using chrome reported version #65.0.3310.0 and latest beta #64.0.3282.71.

Bisect Information:
=====================
Good build: 64.0.3263.0    
Bad Build : 64.0.3264.0    

Change Log URL: 
https://chromium.googlesource.com/chromium/src/+log/b3047508f076e2da056f967b8ca43d6ae4e5aad7..3b330b0c1222235d98d691572dbe43147adbdbc3

From the above change log suspecting below change
Change-Id: I50a184d7aa19813eacc59e4d9fca5e74ec8855f2
Reviewed-on: https://chromium-review.googlesource.com/758464

tbansal@ - Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.
Note: Adding stable blocker for M-64 as it seems to be a recent regression. Please feel free to remove the same if not appropriate.

Thanks...!!
Labels: -Arch-x86_64 -Needs-Triage-M65 OS-Android OS-Chrome
Cc: igrigo...@chromium.org
igrigorik: Thoughts on this? Client hints were blocked on non-HTTPS websites as part of  Issue 782381 . Should this change be reverted until we get a blink-dev i2s out?
igrigorik@ please take a look as soon as possible.
We have consensus in the WG that HTTPS-only the right path forward for CH. As such, I don't believe deploying this should be gated on rolling out 735518. 

That said, this is a deprecation for HTTP support and we did not signal it externally at this point. I think my recommendation here would be to revert for this release and either (a) do an intent to deprecate + some developer outreach for HTTPS-only restriction and then ship this in next release, or (b) couple HTTPS-only with rollout of 735518.
Status: Started (was: Assigned)
Project Member

Comment 8 by bugdroid1@chromium.org, Jan 8 2018

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/699c5ca0e24e2932dbc83eec9c9f4724bed42526

commit 699c5ca0e24e2932dbc83eec9c9f4724bed42526
Author: Tarun Bansal <tbansal@chromium.org>
Date: Mon Jan 08 05:38:54 2018

Reenable client hints on non-secure transports

This only affects the client hints that are requested by
origins using "Accept-CH" header. Requesting Client hints
using "Accept-CH-Lifetime" feature is still not enabled, and
is unaffected by this change.

Before this change, origins can request client hints
using the main frame response. Chrome would then attach
the requested client hints on only the
HTTPS subresources. With this change, the client hints
would be attached on HTTP subresources as well.

This is a partial revert of
https://chromium-review.googlesource.com/c/chromium/src/+/758464

Bug:  799050 
Change-Id: I293f144334cac90fafb38eab95dd7529fc8b9add
Reviewed-on: https://chromium-review.googlesource.com/852863
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527576}
[modify] https://crrev.com/699c5ca0e24e2932dbc83eec9c9f4724bed42526/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/699c5ca0e24e2932dbc83eec9c9f4724bed42526/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp

Labels: Merge-Request-64
Merge request for the CL in #8. It's a pretty safe CL with sufficient test coverage, and I have tested that the fix works against the server provided by the bug reporter. Thanks.
Project Member

Comment 10 by sheriffbot@chromium.org, Jan 8 2018

Labels: -Merge-Request-64 Hotlist-Merge-Review Merge-Review-64
This bug requires manual review: M64 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: cmasso@(Android), cmasso@(iOS), kbleicher@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: abdulsyed@chromium.org cma...@chromium.org
This doesn't seem to have hit Canary yet? Can you please verify it in Canary tomorrow and confirm if everything looks good?
https://chromium.googlesource.com/chromium/src.git/+log/refs/branch-heads/3315?n=1000
tbansal@ please update here so this can be merged today and be ready for Beta tomorrow.
I have verified this is working in 65.0.3316.0. Merge requested for M-65.
Leaning towards approving this for M64. But will let Abdul decide.
Labels: -Merge-Review-64 Merge-Approved-64
Approved for M64. Branch:3282

Project Member

Comment 17 by bugdroid1@chromium.org, Jan 9 2018

Labels: -merge-approved-64 merge-merged-3282
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7342e7111c112e3f7a3abe9784a6c13bb6831ac2

commit 7342e7111c112e3f7a3abe9784a6c13bb6831ac2
Author: Tarun Bansal <tbansal@chromium.org>
Date: Tue Jan 09 20:57:37 2018

Reenable client hints on non-secure transports

This only affects the client hints that are requested by
origins using "Accept-CH" header. Requesting Client hints
using "Accept-CH-Lifetime" feature is still not enabled, and
is unaffected by this change.

Before this change, origins can request client hints
using the main frame response. Chrome would then attach
the requested client hints on only the
HTTPS subresources. With this change, the client hints
would be attached on HTTP subresources as well.

This is a partial revert of
https://chromium-review.googlesource.com/c/chromium/src/+/758464

Bug:  799050 
Change-Id: I293f144334cac90fafb38eab95dd7529fc8b9add
Reviewed-on: https://chromium-review.googlesource.com/852863
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#527576}(cherry picked from commit 699c5ca0e24e2932dbc83eec9c9f4724bed42526)
Reviewed-on: https://chromium-review.googlesource.com/857802
Reviewed-by: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/branch-heads/3282@{#469}
Cr-Branched-From: 5fdc0fab22ce7efd32532ee989b223fa12f8171e-refs/heads/master@{#520840}
[modify] https://crrev.com/7342e7111c112e3f7a3abe9784a6c13bb6831ac2/third_party/WebKit/Source/core/loader/FrameFetchContext.cpp
[modify] https://crrev.com/7342e7111c112e3f7a3abe9784a6c13bb6831ac2/third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp

Status: Fixed (was: Started)

Sign in to add a comment