Simplify unittest callback handling in device/fido/fido_ble_connection_unittest.cc |
||||||
Issue descriptionPer engedy@: "this can be greatly simplified: https://cs.chromium.org/chromium/src/base/run_loop.h?type=cs&sq=package:chromium&l=98-101"
,
Mar 31 2018
Looks like we are using TestCallbackReceiver everywhere except in `fido_ble_connection_unittest.cc`. Although we seem to be needing RepeatingCallbacks in a couple of places there, there are also OnceCallbacks which can be immediately simplified to use the TestCallbackReceiver.
,
Mar 31 2018
,
Apr 13 2018
,
Apr 13 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/823719a7d863dbcd569d764890a5fa300385da78 commit 823719a7d863dbcd569d764890a5fa300385da78 Author: Kim Paulhamus <kpaulhamus@chromium.org> Date: Fri Apr 13 18:13:46 2018 Simplify unittest callback handling in FidoBleConnection unittests Changes OnceCallbacks to use TestCallbackReceiver. Bug: 799044 Change-Id: Ifdad6592537490cdae8d9a8c95809db350fd4f11 Reviewed-on: https://chromium-review.googlesource.com/1011628 Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#550685} [modify] https://crrev.com/823719a7d863dbcd569d764890a5fa300385da78/device/fido/fido_ble_connection_unittest.cc
,
Apr 13 2018
,
Apr 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/369740d6f94e501b8a59559fe360470631e31584 commit 369740d6f94e501b8a59559fe360470631e31584 Author: jdoerrie <jdoerrie@chromium.org> Date: Mon Apr 16 09:23:54 2018 [fido] TestCallbackReceiver improvements This change fixes a subtle bug in TestCallbackReceiver, renames StatusCallbackReceiver to ValueCallbackReceiver and adds usages where appropriate. Bug: 785955 , 799044 Change-Id: Iac686ec59c48e33d75155e67d615a6bdb4c042a0 Reviewed-on: https://chromium-review.googlesource.com/1009744 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#550954} [modify] https://crrev.com/369740d6f94e501b8a59559fe360470631e31584/device/fido/fido_ble_connection_unittest.cc [modify] https://crrev.com/369740d6f94e501b8a59559fe360470631e31584/device/fido/fido_ble_device_unittest.cc [modify] https://crrev.com/369740d6f94e501b8a59559fe360470631e31584/device/fido/fido_hid_device_unittest.cc [modify] https://crrev.com/369740d6f94e501b8a59559fe360470631e31584/device/fido/test_callback_receiver.h [modify] https://crrev.com/369740d6f94e501b8a59559fe360470631e31584/device/fido/test_callback_receiver_unittest.cc [modify] https://crrev.com/369740d6f94e501b8a59559fe360470631e31584/device/fido/u2f_request_unittest.cc
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/823719a7d863dbcd569d764890a5fa300385da78 commit 823719a7d863dbcd569d764890a5fa300385da78 Author: Kim Paulhamus <kpaulhamus@chromium.org> Date: Fri Apr 13 18:13:46 2018 Simplify unittest callback handling in FidoBleConnection unittests Changes OnceCallbacks to use TestCallbackReceiver. Bug: 799044 Change-Id: Ifdad6592537490cdae8d9a8c95809db350fd4f11 Reviewed-on: https://chromium-review.googlesource.com/1011628 Reviewed-by: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org> Cr-Commit-Position: refs/heads/master@{#550685} [modify] https://crrev.com/823719a7d863dbcd569d764890a5fa300385da78/device/fido/fido_ble_connection_unittest.cc
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/369740d6f94e501b8a59559fe360470631e31584 commit 369740d6f94e501b8a59559fe360470631e31584 Author: jdoerrie <jdoerrie@chromium.org> Date: Mon Apr 16 09:23:54 2018 [fido] TestCallbackReceiver improvements This change fixes a subtle bug in TestCallbackReceiver, renames StatusCallbackReceiver to ValueCallbackReceiver and adds usages where appropriate. Bug: 785955 , 799044 Change-Id: Iac686ec59c48e33d75155e67d615a6bdb4c042a0 Reviewed-on: https://chromium-review.googlesource.com/1009744 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#550954} [modify] https://crrev.com/369740d6f94e501b8a59559fe360470631e31584/device/fido/fido_ble_connection_unittest.cc [modify] https://crrev.com/369740d6f94e501b8a59559fe360470631e31584/device/fido/fido_ble_device_unittest.cc [modify] https://crrev.com/369740d6f94e501b8a59559fe360470631e31584/device/fido/fido_hid_device_unittest.cc [modify] https://crrev.com/369740d6f94e501b8a59559fe360470631e31584/device/fido/test_callback_receiver.h [modify] https://crrev.com/369740d6f94e501b8a59559fe360470631e31584/device/fido/test_callback_receiver_unittest.cc [modify] https://crrev.com/369740d6f94e501b8a59559fe360470631e31584/device/fido/u2f_request_unittest.cc |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by kpaulhamus@chromium.org
, Jan 4 2018Status: Available (was: Assigned)