Issue metadata
Sign in to add a comment
|
Security DCHECK failure: value.IsValuePair() in CSSValuePair.h |
||||||||||||||||||||||
Issue descriptionDetailed report: https://clusterfuzz.com/testcase?key=5599281049501696 Fuzzer: inferno_twister Job Type: linux_asan_content_shell_drt Platform Id: linux Crash Type: Security DCHECK failure Crash Address: Crash State: value.IsValuePair() in CSSValuePair.h blink::CSSPositionValue::FromCSSValue blink::CreateStyleValueWithProperty Sanitizer: address (ASAN) Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=526884:526887 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5599281049501696 Issue filed automatically. See https://github.com/google/clusterfuzz-tools for more information.
,
Jan 4 2018
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/efd690f517a0758bd37bb701c3ab84656922fd39 ([css-typed-om] Implement declared style property map.). If this is incorrect, please remove the owner and apply the Test-Predator-Wrong-CLs label.
,
Jan 4 2018
,
Jan 4 2018
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it. If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 4 2018
,
Jan 5 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/64bd68a928aebf4399f03eaf53ee15785e78fe54 commit 64bd68a928aebf4399f03eaf53ee15785e78fe54 Author: Darren Shen <shend@chromium.org> Date: Fri Jan 05 04:34:34 2018 [css-typed-om] Fix crash by always considering css wide keywords. Currently, when we convert a CSSValue to a CSSStyleValue, we would first look at what property we are doing it for (e.g. object-position) and then converting the CSSValue to the appropriate CSSStyleValue (for object-position, it's CSSPositionValue). However, every css property can take 3 "css wide" or "global" keywords: inherit, initial and unset. These become CSSIdentifierValues. Thus, when we do something like "object-position: inherit", it would try to convert a CSSIdentifierValue to a CSSPositionValue, which is an error. We can fix this by always considering css wide keywords first and converting them to CSSKeywordValues. Bug: 799017 , 798956 Change-Id: Id7f9d89bf42d3fce85fef748fd40a06a0a05566b Reviewed-on: https://chromium-review.googlesource.com/851232 Commit-Queue: Darren Shen <shend@chromium.org> Reviewed-by: nainar <nainar@chromium.org> Cr-Commit-Position: refs/heads/master@{#527212} [modify] https://crrev.com/64bd68a928aebf4399f03eaf53ee15785e78fe54/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/config-templates.js [add] https://crrev.com/64bd68a928aebf4399f03eaf53ee15785e78fe54/third_party/WebKit/LayoutTests/typedcssom/inlinestyle/properties/object-position.html [modify] https://crrev.com/64bd68a928aebf4399f03eaf53ee15785e78fe54/third_party/WebKit/Source/core/css/cssom/StyleValueFactory.cpp
,
Jan 5 2018
ClusterFuzz has detected this issue as fixed in range 527199:527221. Detailed report: https://clusterfuzz.com/testcase?key=5599281049501696 Fuzzer: inferno_twister Job Type: linux_asan_content_shell_drt Platform Id: linux Crash Type: Security DCHECK failure Crash Address: Crash State: value.IsValuePair() in CSSValuePair.h blink::CSSPositionValue::FromCSSValue blink::CreateStyleValueWithProperty Sanitizer: address (ASAN) Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=526884:526887 Fixed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=527199:527221 Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5599281049501696 See https://github.com/google/clusterfuzz-tools for more information. If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
,
Jan 5 2018
ClusterFuzz testcase 5599281049501696 is verified as fixed, so closing issue as verified. If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
,
Jan 5 2018
,
Feb 13 2018
,
Mar 27 2018
,
Apr 13 2018
This bug has been closed for more than 14 weeks. Removing security view restrictions. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ClusterFuzz
, Jan 4 2018Labels: Test-Predator-Auto-Components