New issue
Advanced search Search tips

Issue 799000 link

Starred by 5 users

Issue metadata

Status: WontFix
Owner:
Closed: Jan 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug-Regression



Sign in to add a comment

2.3%-65% regression in system_health.memory_mobile at 526553:526619

Project Member Reported by rmcilroy@chromium.org, Jan 4 2018

Issue description

See the link to graphs below.
 
All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=799000

(For debugging:) Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?sid=d773611742b2aa7561515fb11cbcc2fed3a146c2b329a0e103e90b7b9b97c88e


Bot(s) for this bug's original alert(s):

android-webview-nexus5X
android-webview-nexus6
Cc: fmea...@chromium.org
Owner: fmea...@chromium.org
Status: Assigned (was: Untriaged)

=== Auto-CCing suspected CL author fmeawad@chromium.org ===

Hi fmeawad@chromium.org, the bisect results pointed to your CL, please take a look at the
results.


=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Fadi Meawad
  Commit : b85b48382bd9087a89afdc6fe0ac33dd71f1487e
  Date   : Wed Jan 03 02:18:33 2018
  Subject: Revert "Reland "[PageLifecyle] Move the launch process state to Webkit/common""

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_chrome:cc:effective_size_avg/browse_social/browse_social_facebook
  Change       : 61.18% | 88682056.0 -> 142937344.0

Revision             Result                     N
chromium@526574      88682056 +- 27750774       6      good
chromium@526580      91244390 +- 30033717       6      good
chromium@526583      82162986 +- 17130472       6      good
chromium@526585      79713702 +- 3033439        5      good
chromium@526586      140179212 +- 21945244      6      bad       <--
chromium@526597      139056712 +- 20953051      6      bad
chromium@526619      142937344 +- 3673313       6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=browse.social.facebook system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8958334310033139664


For feedback, file a bug with component Speed>Bisection

=== BISECT JOB RESULTS ===
Perf regression found with culprit

Suspected Commit
  Author : Fadi Meawad
  Commit : b85b48382bd9087a89afdc6fe0ac33dd71f1487e
  Date   : Wed Jan 03 02:18:33 2018
  Subject: Revert "Reland "[PageLifecyle] Move the launch process state to Webkit/common""

Bisect Details
  Configuration: android_webview_nexus6_aosp_perf_bisect
  Benchmark    : system_health.memory_mobile
  Metric       : memory:webview:all_processes:reported_by_chrome:malloc:effective_size_avg/load_news/load_news_irctc
  Change       : 2.71% | 24727674.2222 -> 25397804.0

Revision             Result                   N
chromium@526574      24727674 +- 943642       9      good
chromium@526580      24694788 +- 510300       6      good
chromium@526583      24696903 +- 237004       6      good
chromium@526585      24846545 +- 871295       6      good
chromium@526586      25745675 +- 768360       6      bad       <--
chromium@526597      25747867 +- 1026356      6      bad
chromium@526619      25397804 +- 701907       6      bad

Please refer to the following doc on diagnosing memory regressions:
  https://chromium.googlesource.com/chromium/src/+/master/docs/memory-infra/memory_benchmarks.md

To Run This Test
  src/tools/perf/run_benchmark -v --browser=android-webview --output-format=chartjson --upload-results --pageset-repeat=1 --also-run-disabled-tests --story-filter=load.news.irctc system_health.memory_mobile

More information on addressing performance regressions:
  http://g.co/ChromePerformanceRegressions

Debug information about this bisect:
  https://chromeperf.appspot.com/buildbucket_job_status/8958313595356017248


For feedback, file a bug with component Speed>Bisection
Cc: benjhayden@chromium.org
 Issue 799624  has been merged into this issue.
 Issue 799624  has been merged into this issue.
Issue 799643 has been merged into this issue.
 Issue 800023  has been merged into this issue.
Issue 799957 has been merged into this issue.
Cc: jgruber@chromium.org
 Issue 800299  has been merged into this issue.
Project Member

Comment 12 by 42576172...@developer.gserviceaccount.com, Jan 10 2018

Cc: hjd@google.com
 Issue 800716  has been merged into this issue.
Status: WontFix (was: Assigned)
The original CL introduced an incorrect throttling in webview that caused reduce memory usage that was captured by the graphs as an optimization.

The bisect bots are blaming the revert of the CL since the throttling was removed and the memory usage returned to normal. But otherwise this is not a real regression.

P.S. The original CL has since been re-landed, but the memory usage was not affected as webview is no longer unexpectedly throttled.
Issue 800342 has been merged into this issue.

Sign in to add a comment