New issue
Advanced search Search tips

Issue 798999 link

Starred by 1 user
Status: Fixed
Owner:
jochen@chromium.org
Closed: Jan 2018
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Media Controls Download button initiate a navigation to the URL

Project Member Reported by mlamouri@chromium.org, Jan 4 2018 
STR:
1. Go to https://mounirlamouri.github.io/sandbox/media/dynamic-controls.html
2. Press download button

Expected result: downloads the file
Actual result: opens the file (triggers a VIEW intent on Android)

This is because the download button is implemented as <a download>.

Comment 1 by mlamouri@chromium.org, Jan 4 2018

Labels: ReleaseBlock-Beta

Comment 2 by jochen@chromium.org, Jan 4 2018

Labels: -OS-Linux -OS-Windows -ReleaseBlock-Beta -OS-Chrome -OS-Mac ReleaseBlock-Stable

Comment 3 by jochen@chromium.org, Jan 5 2018

Status: WontFix (was: Assigned)
can't repro on android either

Comment 4 by mlamouri@chromium.org, Jan 5 2018

Status: Assigned (was: WontFix)
Re-opening as we discovered that it happens reliably on N5 running Android 6.0.

Comment 5 by mlamouri@chromium.org, Jan 5 2018 

After further investigation, this isn't specific to N5 nor Android 6 as I was able to reproduce this on a Pixel 2 (Android 8+).
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 8 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c10a53aec83120e0ee0ca69d6bffae647570990b

commit c10a53aec83120e0ee0ca69d6bffae647570990b
Author: Jochen Eisinger <jochen@chromium.org>
Date: Mon Jan 08 09:34:09 2018

Plumb suggested filename to navigation interceptor

This avoids firing a view intent if we'd later change the navigation
to a download

BUG= 798999 
R=clamy@chromium.org,mlamouri@chromium.org

Change-Id: Icc5a7d971c37f34a0cbb138acb1c371acdb9586c
Reviewed-on: https://chromium-review.googlesource.com/852273
Commit-Queue: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Camille Lamy <clamy@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#527589}
[modify] https://crrev.com/c10a53aec83120e0ee0ca69d6bffae647570990b/chrome/android/java/src/org/chromium/chrome/browser/tab/InterceptNavigationDelegateImpl.java
[modify] https://crrev.com/c10a53aec83120e0ee0ca69d6bffae647570990b/chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappInterceptNavigationDelegate.java
[modify] https://crrev.com/c10a53aec83120e0ee0ca69d6bffae647570990b/chrome/android/javatests/src/org/chromium/chrome/browser/contextualsearch/ContextualSearchManagerTest.java
[modify] https://crrev.com/c10a53aec83120e0ee0ca69d6bffae647570990b/chrome/android/javatests/src/org/chromium/chrome/browser/webapps/WebappNavigationTest.java
[modify] https://crrev.com/c10a53aec83120e0ee0ca69d6bffae647570990b/chrome/browser/ui/android/external_protocol_dialog_android.cc
[modify] https://crrev.com/c10a53aec83120e0ee0ca69d6bffae647570990b/components/navigation_interception/android/java/src/org/chromium/components/navigation_interception/NavigationParams.java
[modify] https://crrev.com/c10a53aec83120e0ee0ca69d6bffae647570990b/components/navigation_interception/intercept_navigation_throttle.cc
[modify] https://crrev.com/c10a53aec83120e0ee0ca69d6bffae647570990b/components/navigation_interception/navigation_params.cc
[modify] https://crrev.com/c10a53aec83120e0ee0ca69d6bffae647570990b/components/navigation_interception/navigation_params.h
[modify] https://crrev.com/c10a53aec83120e0ee0ca69d6bffae647570990b/components/navigation_interception/navigation_params_android.cc
[modify] https://crrev.com/c10a53aec83120e0ee0ca69d6bffae647570990b/content/browser/frame_host/data_url_navigation_throttle.cc
[modify] https://crrev.com/c10a53aec83120e0ee0ca69d6bffae647570990b/content/browser/frame_host/navigation_handle_impl.cc
[modify] https://crrev.com/c10a53aec83120e0ee0ca69d6bffae647570990b/content/browser/frame_host/navigation_handle_impl.h
[modify] https://crrev.com/c10a53aec83120e0ee0ca69d6bffae647570990b/content/public/browser/navigation_handle.h

Comment 7 by jochen@chromium.org, Jan 8 2018

Status: Fixed (was: Assigned)

Comment 8 by krav...@chromium.org, Jan 9 2018 

Verified in M65-65.0.3316.0
►

Sign in to add a comment