New issue
Advanced search Search tips

Issue 798981 link

Starred by 1 user
Status: Verified
Owner:
gambard@chromium.org
Closed: Jan 2018
Cc:
sczs@chromium.org
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

Clean Toolbar Bug: forward button misplaced after doing a search

Project Member Reported by gambard@chromium.org, Jan 4 2018 
What steps will reproduce the problem?
-Navigate to any site.
-Navigate to another link/site.
-Go back. (So the Fwd button is visible).
-Tap Omnibox, do a search, and tap it.
-Go back.

What is the expected result?
The forward button is moved to the left.

What happens instead?
The forward button should be in its previous place.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 4 2018 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4ad722d62cb8b12b91e5cf770a9bc7605c94c961

commit 4ad722d62cb8b12b91e5cf770a9bc7605c94c961
Author: Gauthier Ambard <gambard@chromium.org>
Date: Thu Jan 04 13:57:28 2018

Reset position of toolbar buttons on animation completion

When the animation to fade buttons out completes, the buttons have a
transformation translating them. This translation is canceled in the
contract animation.
But if the contract animation doesn't occur, the hidden buttons keep
this translation, making them visually misplaced.

This CL fixes it by resetting the position of all elements in the
completion of the animator.

Bug:  798981 
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: If84ab49f9fb1b6971f5901a741004dd4c623dcaf
Reviewed-on: https://chromium-review.googlesource.com/849952
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#526978}
[modify] https://crrev.com/4ad722d62cb8b12b91e5cf770a9bc7605c94c961/ios/chrome/browser/ui/toolbar/clean/toolbar_view_controller.mm

Comment 2 by gambard@chromium.org, Jan 4 2018

Status: Fixed (was: Started)

Comment 3 by subhashi...@chromium.org, Jan 9 2018

Status: Verified (was: Fixed)
Verified in:

App Version: 65.0.3316.0 canary
Devices: iPhone 7, iPhone 8 Plus, iPad Mini
iOS Versions: 10.3.3, 11.2.2, 11.2.5 beta

Forward button is aligned properly after a search. issue is fixed. Please refer to the screenshot
ForwardButton.PNG
784 KB View Download
►

Sign in to add a comment